collectd.git
3 years agoUpdate to resolve conflicts due to renamed files
usev6 [Mon, 29 Apr 2019 18:03:14 +0000 (20:03 +0200)]
Update to resolve conflicts due to renamed files

Merge branch 'master' into write_graphite_reverse_host

3 years agoMerge pull request #3137 from dangowrt/master
Pavel Rochnyak [Sat, 13 Apr 2019 03:57:28 +0000 (10:57 +0700)]
Merge pull request #3137 from dangowrt/master

Add support for RS485 to modbus plugin

3 years agoAdd support for RS485 to modbus plugin
Daniel Golle [Thu, 28 Mar 2019 00:52:04 +0000 (01:52 +0100)]
Add support for RS485 to modbus plugin

Allow setting up RS485 mode for Modbus-RTU

3 years agoMerge pull request #3136 from mrunge/systemd_service
Ruben Kerkhof [Wed, 10 Apr 2019 09:09:25 +0000 (11:09 +0200)]
Merge pull request #3136 from mrunge/systemd_service

Remove ProtectSystem from service file

3 years agoRemove ProtectSystem from service file
Matthias Runge [Fri, 5 Apr 2019 13:19:19 +0000 (15:19 +0200)]
Remove ProtectSystem from service file

This prevents showing eg. /etc if that's a separate file system.

Resolves: https://github.com/collectd/collectd/issues/3134

3 years agoMerge pull request #2891 from elfiesmelfie/feat_intel_rdt
Matthias Runge [Thu, 4 Apr 2019 05:58:51 +0000 (07:58 +0200)]
Merge pull request #2891 from elfiesmelfie/feat_intel_rdt

Intel RDT plugin: add support for groups of PIDs.

3 years agoMerge pull request #3117 from elfiesmelfie/virt_fix_option_parsing
Matthias Runge [Thu, 4 Apr 2019 05:57:42 +0000 (07:57 +0200)]
Merge pull request #3117 from elfiesmelfie/virt_fix_option_parsing

virt: Fix parsing config file options

3 years agoMerge pull request #3116 from rpv-tomsk/collectd-master
Matthias Runge [Thu, 4 Apr 2019 05:46:52 +0000 (07:46 +0200)]
Merge pull request #3116 from rpv-tomsk/collectd-master

virt plugin: Fix segfaults on shutdown

3 years agovirt: Add NULL checking to multiple config strings validation
Antoine Naud [Thu, 28 Mar 2019 13:25:23 +0000 (13:25 +0000)]
virt: Add NULL checking to multiple config strings validation

Remove ERROR messages as requested by reviewer and one unnecessary condition in
if statement.

Change-Id: I2fc01f16789f7720b09d923c72339d7123d3863a
Signed-off-by: Antoine Naud <antoinex.naud@intel.com>
3 years agointel_rdt: multiple options are explicitly denied
Kamil Wiatrowski [Fri, 22 Mar 2019 13:49:57 +0000 (14:49 +0100)]
intel_rdt: multiple options are explicitly denied

Add a check to avoid placing multiple Cores or Processes options in
intel_rdt configuration in order to avoid misuse and errors.

Change-Id: I82504a650bf9c568862da9f129a84a3079990496
Signed-off-by: Kamil Wiatrowski <kamilx.wiatrowski@intel.com>
3 years agovirt: Add NULL checking to multiple config strings validation
Radoslaw Jablonski [Fri, 15 Mar 2019 06:42:55 +0000 (06:42 +0000)]
virt: Add NULL checking to multiple config strings validation

Change-Id: Ic1595a9438f5af6872dc030db949223477b3f238
Signed-off-by: Radoslaw Jablonski <radoslawx.jablonski@intel.com>
3 years agocollect.conf.pod: Add more info about virt filtering options
Radoslaw Jablonski [Mon, 4 Feb 2019 13:35:35 +0000 (13:35 +0000)]
collect.conf.pod: Add more info about virt filtering options

Added more info and examples regarding virt filtering options:
-filtering by domain name
-filtering block devices
-filtering network interfaces

Change-Id: I5cfe41658f62f429b799aa93a3d0f96f7cf8b780
Signed-off-by: Radoslaw Jablonski <radoslawx.jablonski@intel.com>
3 years agovirt: Fix domain filtering option
Radoslaw Jablonski [Fri, 1 Feb 2019 15:46:29 +0000 (15:46 +0000)]
virt: Fix domain filtering option

Previously all domains were visible even if certain domains
should be filtered (only block devices and interface devices
were filtered instead of entire domains)
Now entire domains are filtered - if domain should be filtered
out, then it won't be visible the same way as filtered
block devices and network interfaces.

Change-Id: Ib4e50ad32fd94c900c3e83353d28ae06cbfdb442
Signed-off-by: Radoslaw Jablonski <radoslawx.jablonski@intel.com>
3 years agovirt: Fix network interface filtering
Radoslaw Jablonski [Thu, 31 Jan 2019 14:05:28 +0000 (14:05 +0000)]
virt: Fix network interface filtering

Previously network device filtering was not working properly
if InterfaceFormat was set to 'name' or 'address' values.
Additionally implementation for filtering by interface number
was missing.

Change-Id: Ic6aa1d355423305d08bcab8282dc29009b200b5a
Signed-off-by: Radoslaw Jablonski <radoslawx.jablonski@intel.com>
3 years agovirt: Fix parsing configuration options
Radoslaw Jablonski [Tue, 12 Mar 2019 09:02:06 +0000 (09:02 +0000)]
virt: Fix parsing configuration options

-lv_config function was re-written to use complex config callback

-fixed invalid parsing that caused collectd termination even if values
in config file for virt were correct(ExtraStats and RefreshInterval)

-added return statement to properly finish successful parsing
'ExtraStats' option value - without that, parsing of config file will
fail if 'ExtraStats' option is used in the collectd config file
because return code is the one for unrecognized parameter key.

-fixed parsing of RefreshInterval - previously error was thrown by
mistake if value was not written between double quotes(i.e. "60" was
fine but 60 was not)

-previously validation for boolean option value(such as value of
'IgnoreSelected' parameter) in virt plugin was missing and bad input
in config file could be unnoticed by user(in config file, boolean
value is parsed from its string representation). Now validation is
added and error is thrown whenever value can't be parsed directly as
'true'|'yes'|'on' or 'false'|'no'|'off'.

-additionally error messages have been added in all places where
parsing failed in order to notify the user about the reason of
collectd initialization failure.

Change-Id: I2069977395371e89f4a02eb544ffb7bda8c5c5ce
Signed-off-by: Radoslaw Jablonski <radoslawx.jablonski@intel.com>
3 years agovirt plugin: Changed place of event loop start/stop debug messages output
Pavel Rochnyack [Tue, 12 Mar 2019 15:51:33 +0000 (22:51 +0700)]
virt plugin: Changed place of event loop start/stop debug messages output

3 years agoMerge pull request #2874 from elfiesmelfie/feat_virt_block_info
Pavel Rochnyak [Thu, 7 Mar 2019 18:26:15 +0000 (01:26 +0700)]
Merge pull request #2874 from elfiesmelfie/feat_virt_block_info

virt: Add block info statistics for disk devices

3 years agovirt: Fetch block info stats from libvirt only if needed
Radoslaw Jablonski [Thu, 28 Feb 2019 14:14:01 +0000 (14:14 +0000)]
virt: Fetch block info stats from libvirt only if needed

Domain block info statistics will be retrieved from libvirt
only if one of extra stats is enabled:
- ex_stats_disk_allocation
- ex_stats_disk_capacity
- ex_stats_disk_physical

Change-Id: I0367c6ec7aafbf9558aaa100a12d40605ab9ba72
Signed-off-by: Radoslaw Jablonski <radoslawx.jablonski@intel.com>
3 years agoMerge pull request #3108 from rubenk/cirrus-improvements
Marc Fournier [Thu, 7 Mar 2019 10:31:10 +0000 (11:31 +0100)]
Merge pull request #3108 from rubenk/cirrus-improvements

Cirrus improvements

3 years agointel_rdt: Added check if name group is defined before updating of pids list
Aleksinski, MichalX [Wed, 6 Mar 2019 13:50:17 +0000 (13:50 +0000)]
intel_rdt: Added check if name group is defined before updating of pids list

Change-Id: Ic99acd51be69d2678f25bdde9ca37011ad24fe99

3 years agointel_rdt: Fixed compile error in debug build
Aleksinski, MichalX [Thu, 28 Feb 2019 07:20:15 +0000 (07:20 +0000)]
intel_rdt: Fixed compile error in debug build

Change-Id: Ia932f377c5194240aab910d052e422b99ea542a5

3 years agoutils_proc_pids: moved to utils directory
Aleksinski, MichalX [Wed, 20 Feb 2019 12:32:50 +0000 (12:32 +0000)]
utils_proc_pids: moved to utils directory

Change-Id: Ia7c9bf5dca2b871b05c9ed3876059e6d34bd943e

3 years agointel_rdt: refactored proc utils to increase efficiency
Aleksinski, MichalX [Wed, 7 Nov 2018 23:59:26 +0000 (23:59 +0000)]
intel_rdt: refactored proc utils to increase efficiency

Change-Id: Ibb0dc6fe59eb77a217ab3b45ec0c1437bc9eb281

3 years agointel_rdt: updated pqos mocks for pqos version 3.0
Aleksinski, MichalX [Fri, 22 Feb 2019 07:10:00 +0000 (07:10 +0000)]
intel_rdt: updated pqos mocks for pqos version 3.0

Change-Id: Ibcf8c2fd6d1b490cbeeef7480c49da84389104f4

3 years agointel_rdt: close file descriptor on error
Aleksinski, MichalX [Fri, 26 Oct 2018 01:02:09 +0000 (02:02 +0100)]
intel_rdt: close file descriptor on error

Change-Id: I161c8df1e6a4c4c4e0dd4e20601323ef7a1c18f5

3 years agoFix for CI error in test code on epel6 platform.
Wojciech Andralojc [Mon, 6 Aug 2018 12:43:02 +0000 (13:43 +0100)]
Fix for CI error in test code on epel6 platform.

Signed-off-by: Wojciech Andralojc <wojciechx.andralojc@intel.com>
Change-Id: I325ea0728dd1eb65776f239b0d7977cc02f9c8db

3 years agointel_rdt: refactor pids monitoring code.
Mateusz Starzyk [Thu, 14 Jun 2018 05:28:39 +0000 (06:28 +0100)]
intel_rdt: refactor pids monitoring code.
Extract pids config to seperate file.
Extract pids config tests to seperate file.

Change-Id: I2978db56b15a126eced12f40baac631517303e04
Signed-off-by: Mateusz Starzyk <mateuszx.starzyk@intel.com>
3 years agointel-rdt: Changed memory allocation of new and lost pids tables from static to dynamic
Aleksinski, MichalX [Mon, 30 Jul 2018 08:09:00 +0000 (09:09 +0100)]
intel-rdt: Changed memory allocation of new and lost pids tables from static to dynamic

Change-Id: I3936fe78cfcbb4ce053d38ff1a3236c21eac9fd7
Signed-off-by: Michal Aleksinski <michalx.aleksinski@intel.com>
3 years agoCorrected issues reported by klockwork
Aleksinski, MichalX [Tue, 24 Jul 2018 07:39:20 +0000 (08:39 +0100)]
Corrected issues reported by klockwork

Change-Id: I3737a39c40d89a8782ef9c3d8195351f0fdeb278

3 years agointel_rdt: update unit-tests for process monitoring
Starzyk, MateuszX [Wed, 21 Mar 2018 08:14:53 +0000 (08:14 +0000)]
intel_rdt: update unit-tests for process monitoring

Refactor certain functions to be testable.

Change-Id: I5adb6ed1b076f0cebc70641f04dd101d4e89b9cc
Signed-off-by: Starzyk, MateuszX <mateuszx.starzyk@intel.com>
3 years agointel_rdt: collect data for monitored processes
Starzyk, MateuszX [Fri, 9 Mar 2018 12:20:01 +0000 (12:20 +0000)]
intel_rdt: collect data for monitored processes

Change-Id: Ib5a7d318bde69ee8f496b39ca74b3ee4e58d8f5b
Signed-off-by: Starzyk, MateuszX <mateuszx.starzyk@intel.com>
3 years agointel_rdt: Backwards compatibility, libpqos v1
Andralojc, WojciechX [Thu, 8 Mar 2018 15:00:26 +0000 (15:00 +0000)]
intel_rdt: Backwards compatibility, libpqos v1

Change-Id: I677c8215f89c04cedcb4c9e7d630f187a76a6cc7
Signed-off-by: Andralojc, WojciechX <wojciechx.andralojc@intel.com>
3 years agointel_rdt: PID groups change detection
Mateusz Starzyk [Fri, 15 Jun 2018 10:13:10 +0000 (11:13 +0100)]
intel_rdt: PID groups change detection

Change-Id: I569d72d0f12dca314e865f0b9236dc09a053c5e5
Signed-off-by: Andralojc, WojciechX <wojciechx.andralojc@intel.com>
3 years agointel_rdt: Update config parser for PID monitoring
Andralojc, WojciechX [Fri, 23 Feb 2018 14:44:57 +0000 (14:44 +0000)]
intel_rdt: Update config parser for PID monitoring

"Processes" option added.

Change-Id: I7f62a51fc06e0c7503caa7860807f1c8e09b2fa1
Signed-off-by: Andralojc, WojciechX <wojciechx.andralojc@intel.com>
3 years agointel_rdt: add PQOS API stubs for pid monitoring.
Starzyk, MateuszX [Thu, 1 Mar 2018 10:08:28 +0000 (10:08 +0000)]
intel_rdt: add PQOS API stubs for pid monitoring.

Add temporary functions to enable further development of rdt plugin.
These stubbed functions will be removed once libpqos extends it's API.

Change-Id: I39dd428e39fd6055774dfc39b4c0690aedee4ebe
Signed-off-by: Starzyk, MateuszX <mateuszx.starzyk@intel.com>
3 years agointel_rdt: adds pids extraction for given processes list
Starzyk, MateuszX [Mon, 19 Feb 2018 14:52:38 +0000 (14:52 +0000)]
intel_rdt: adds pids extraction for given processes list

adds intel_rdt_tests file with unit-tests of newly introduced functions.

Change-Id: I0e26322caa19f57b7d660807646bd437586cd80d
Signed-off-by: Starzyk, MateuszX <mateuszx.starzyk@intel.com>
3 years agovirt plugin: Fix segfaults on shutdown
Pavel Rochnyack [Tue, 26 Feb 2019 19:59:17 +0000 (02:59 +0700)]
virt plugin: Fix segfaults on shutdown

If connection has failed then `lv_init' returns early without initializing `notif_thread'.
This causes segfault due to incorrect `pthread_join()` call on Collectd shutdown.

Closes: #3082

3 years agoMerge pull request #3110 from rubenk/configure-ac-keep-plugin-list-sorted
Pavel Rochnyak [Thu, 21 Feb 2019 19:24:12 +0000 (02:24 +0700)]
Merge pull request #3110 from rubenk/configure-ac-keep-plugin-list-sorted

configure.ac: keep the list of plugins sorted

3 years agoconfigure.ac: keep the list of plugins sorted
Ruben Kerkhof [Thu, 21 Feb 2019 15:01:38 +0000 (16:01 +0100)]
configure.ac: keep the list of plugins sorted

3 years agoCirrus CI: remove musl-libc job
Ruben Kerkhof [Thu, 21 Feb 2019 10:59:29 +0000 (11:59 +0100)]
Cirrus CI: remove musl-libc job

3 years agoCirrus CI: use clang++ where we use clang
Ruben Kerkhof [Thu, 21 Feb 2019 10:55:39 +0000 (11:55 +0100)]
Cirrus CI: use clang++ where we use clang

3 years agoCirrus CI: remove Fedora 26
Ruben Kerkhof [Thu, 21 Feb 2019 10:53:59 +0000 (11:53 +0100)]
Cirrus CI: remove Fedora 26

It's been EOL for a while

3 years agoCirrus CI: remove Wheezy
Ruben Kerkhof [Thu, 21 Feb 2019 10:52:55 +0000 (11:52 +0100)]
Cirrus CI: remove Wheezy

It's been EOL for a while

3 years agoMerge pull request #3104 from rubenk/intel-rdt-fix-compiler-warnings
Pavel Rochnyak [Wed, 20 Feb 2019 13:36:58 +0000 (20:36 +0700)]
Merge pull request #3104 from rubenk/intel-rdt-fix-compiler-warnings

intel_rdt plugin: fix compiler warnings

3 years agointel_rdt plugin: fix compiler warnings
Ruben Kerkhof [Wed, 20 Feb 2019 12:25:00 +0000 (13:25 +0100)]
intel_rdt plugin: fix compiler warnings

make[1]: Entering directory '/home/ruben/src/collectd'
  CC       src/intel_rdt_la-intel_rdt.lo
src/intel_rdt.c: In function ‘rdt_dump_cgroups’:
src/intel_rdt.c:74:23: warning: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]
   74 |     for (int j = 0; j < cgroup->num_cores; j++) {
      |                       ^
src/intel_rdt.c: In function ‘rdt_dump_data’:
src/intel_rdt.c:103:21: warning: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]
  103 |   for (int i = 0; i < g_rdt->num_groups; i++) {
      |                     ^
  CCLD     intel_rdt.la

3 years agoMerge pull request #3102 from rubenk/oauth-fix-compiler-warning
Pavel Rochnyak [Wed, 20 Feb 2019 11:37:40 +0000 (18:37 +0700)]
Merge pull request #3102 from rubenk/oauth-fix-compiler-warning

oauth.c: fix compiler warning

3 years agoMerge pull request #3103 from rubenk/write_prometheus-fix-compiler-warning
Pavel Rochnyak [Wed, 20 Feb 2019 11:36:23 +0000 (18:36 +0700)]
Merge pull request #3103 from rubenk/write_prometheus-fix-compiler-warning

write_prometheus plugin: fix compiler warning

3 years agowrite_prometheus plugin: fix compiler warning
Ruben Kerkhof [Wed, 20 Feb 2019 11:14:18 +0000 (12:14 +0100)]
write_prometheus plugin: fix compiler warning

make[1]: Entering directory '/home/ruben/src/collectd'
  CC       src/write_prometheus_la-write_prometheus.lo
In file included from src/write_prometheus.c:29:
src/write_prometheus.c: In function ‘metric_family_get’:
./src/daemon/plugin.h:393:20: warning: ‘%s’ directive argument is null [-Wformat-overflow=]
  393 | #define ERROR(...) plugin_log(LOG_ERR, __VA_ARGS__)
      |                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/write_prometheus.c:725:5: note: in expansion of macro ‘ERROR’
  725 |     ERROR("write_prometheus plugin: Adding \"%s\" failed.", name);
      |     ^~~~~
src/write_prometheus.c:725:46: note: format string is defined here
  725 |     ERROR("write_prometheus plugin: Adding \"%s\" failed.", name);
      |                                              ^~
  CCLD     write_prometheus.la

3 years agooauth.c: fix compiler warning
Ruben Kerkhof [Wed, 20 Feb 2019 11:06:27 +0000 (12:06 +0100)]
oauth.c: fix compiler warning

make[1]: Entering directory '/home/ruben/src/collectd'
  CC       src/utils/oauth/liboauth_la-oauth.lo
src/utils/oauth/oauth.c: In function ‘get_assertion’:
src/utils/oauth/oauth.c:283:19: warning: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]
  283 |   else if (status >= buffer_size)
      |                   ^~

3 years agoMerge pull request #3100 from rubenk/virt-fix-compiler-warning
Florian Forster [Wed, 20 Feb 2019 10:43:16 +0000 (11:43 +0100)]
Merge pull request #3100 from rubenk/virt-fix-compiler-warning

virt plugin: fix compiler warning

3 years agoMerge pull request #3099 from rubenk/turbostat-fix-compiler-warnings
Florian Forster [Wed, 20 Feb 2019 10:42:26 +0000 (11:42 +0100)]
Merge pull request #3099 from rubenk/turbostat-fix-compiler-warnings

turbostat plugin: fix two compiler warnings

3 years agoMerge pull request #3098 from rubenk/ovs-stats-fix-compiler-warning
Florian Forster [Wed, 20 Feb 2019 10:41:31 +0000 (11:41 +0100)]
Merge pull request #3098 from rubenk/ovs-stats-fix-compiler-warning

ovs_stats plugin: fix compiler warning

3 years agovirt plugin: fix compiler warning
Ruben Kerkhof [Wed, 20 Feb 2019 10:25:50 +0000 (11:25 +0100)]
virt plugin: fix compiler warning

src/virt.c:725:7: warning: no previous prototype for function 'metadata_get_hostname' [-Wmissing-prototypes]
char *metadata_get_hostname(virDomainPtr dom) {
      ^
1 warning generated.

3 years agoturbostat plugin: fix two compiler warnings
Ruben Kerkhof [Wed, 20 Feb 2019 10:22:30 +0000 (11:22 +0100)]
turbostat plugin: fix two compiler warnings

src/turbostat.c:1466:5: warning: no previous prototype for function 'save_affinity' [-Wmissing-prototypes]
int save_affinity(void) {
    ^
src/turbostat.c:1479:6: warning: no previous prototype for function 'restore_affinity' [-Wmissing-prototypes]
void restore_affinity(void) {
     ^

3 years agoovs_stats plugin: fix compiler warning
Ruben Kerkhof [Wed, 20 Feb 2019 10:19:16 +0000 (11:19 +0100)]
ovs_stats plugin: fix compiler warning

src/ovs_stats.c:863:23: warning: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long') [-Wsign-compare]
    for (int i = 0; i < YAJL_GET_ARRAY(ifaces_list)->len; i++) {
                    ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.

3 years agoCirrus CI: enable parallel builds
Ruben Kerkhof [Wed, 20 Feb 2019 10:00:05 +0000 (11:00 +0100)]
Cirrus CI: enable parallel builds

3 years agoCirrus CI: do not clone the full branch
Ruben Kerkhof [Wed, 20 Feb 2019 09:46:14 +0000 (10:46 +0100)]
Cirrus CI: do not clone the full branch

We only need the last commit

3 years agoAuto-Merge pull request #3097 from octo/ff/build
collectd bot [Wed, 20 Feb 2019 09:44:21 +0000 (10:44 +0100)]
Auto-Merge pull request #3097 from octo/ff/build

Automatically merged due to "Automerge" label

3 years agoconfigure.ac: Fix include of "utils/mount/mount.h".
Florian Forster [Wed, 20 Feb 2019 09:20:00 +0000 (10:20 +0100)]
configure.ac: Fix include of "utils/mount/mount.h".

3 years agoMerge pull request #3096 from rubenk/remove-errors-option-from-pod2man
Florian Forster [Wed, 20 Feb 2019 09:26:47 +0000 (10:26 +0100)]
Merge pull request #3096 from rubenk/remove-errors-option-from-pod2man

pod2man: remove --errors argument

3 years agoMerge branch 'collectd-5.8'
Florian Forster [Wed, 20 Feb 2019 09:10:35 +0000 (10:10 +0100)]
Merge branch 'collectd-5.8'

3 years agopod2man: remove --errors argument
Ruben Kerkhof [Wed, 20 Feb 2019 09:09:09 +0000 (10:09 +0100)]
pod2man: remove --errors argument

Older versions of pod2man don't have this

3 years agoMerge branch 'collectd-5.7' into collectd-5.8
Florian Forster [Wed, 20 Feb 2019 09:05:09 +0000 (10:05 +0100)]
Merge branch 'collectd-5.7' into collectd-5.8

3 years agoBuild system: enable the "df" plugin when getmntent_r() is available. collectd-5.7
Florian Forster [Wed, 20 Feb 2019 08:37:53 +0000 (09:37 +0100)]
Build system: enable the "df" plugin when getmntent_r() is available.

Looks like the check result used to be stored in a variable of a
different name.

3 years agoAuto-Merge pull request #3065 from btoneill/rrdcached
collectd bot [Wed, 20 Feb 2019 08:38:59 +0000 (09:38 +0100)]
Auto-Merge pull request #3065 from btoneill/rrdcached

Automatically merged due to "Automerge" label

3 years agorrdcached plugin: Inline time conversion.
Florian Forster [Tue, 19 Feb 2019 19:25:16 +0000 (20:25 +0100)]
rrdcached plugin: Inline time conversion.

3 years agorrdcached plugin: fixed issue with typing
Brian ONeill [Mon, 11 Feb 2019 17:17:24 +0000 (12:17 -0500)]
rrdcached plugin: fixed issue with typing

3 years agorrdcached plugin: changed time format to no longer lose microseconds when sending...
Brian ONeill [Fri, 8 Feb 2019 16:41:18 +0000 (11:41 -0500)]
rrdcached plugin: changed time format to no longer lose microseconds when sending to rrdcached.

See https://lists.oetiker.ch/pipermail/rrd-developers/2003-March/001007.html for we want this

3 years agoMerge pull request #3060 from octo/issue/2973
Ruben Kerkhof [Wed, 20 Feb 2019 08:05:11 +0000 (09:05 +0100)]
Merge pull request #3060 from octo/issue/2973

contrib/docker/: Switch to Debian slim, separate ENTRYPOINT/CMD, install suggestions.

3 years agoAuto-Merge pull request #3090 from rubenk/lua-plugin-prevent-leak-on-shutdown
collectd bot [Tue, 19 Feb 2019 19:28:48 +0000 (20:28 +0100)]
Auto-Merge pull request #3090 from rubenk/lua-plugin-prevent-leak-on-shutdown

Automatically merged due to "Automerge" label

3 years agoMerge pull request #3074 from mfournier/ci-setup
Florian Forster [Tue, 19 Feb 2019 19:17:50 +0000 (20:17 +0100)]
Merge pull request #3074 from mfournier/ci-setup

Re-implement CI using cirrus-ci

3 years agoFormat src/lua.c.
Florian Forster [Tue, 19 Feb 2019 19:16:19 +0000 (20:16 +0100)]
Format src/lua.c.

3 years agoMerge pull request #3092 from rubenk/pod2man-dont-hide-errors
Florian Forster [Tue, 19 Feb 2019 19:04:42 +0000 (20:04 +0100)]
Merge pull request #3092 from rubenk/pod2man-dont-hide-errors

Don't hide errors when creating manpage

3 years agoMerge pull request #3093 from rubenk/sensu-fix-warning
Florian Forster [Tue, 19 Feb 2019 19:02:59 +0000 (20:02 +0100)]
Merge pull request #3093 from rubenk/sensu-fix-warning

Sensu fix warning

3 years agosensu plugin: fix compiler warning when build with --enable-debug
Ruben Kerkhof [Tue, 19 Feb 2019 17:53:19 +0000 (18:53 +0100)]
sensu plugin: fix compiler warning when build with --enable-debug

In file included from src/write_sensu.c:31:
src/write_sensu.c: In function ‘sensu_config’:
./src/daemon/plugin.h:398:20: warning: ‘%s’ directive argument is null [-Wformat-overflow=]
  398 | #define DEBUG(...) plugin_log(LOG_DEBUG, __VA_ARGS__)
      |                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/write_sensu.c:1227:7: note: in expansion of macro ‘DEBUG’
 1227 |       DEBUG("write_sensu plugin: Got tag: %s", tmp);
      |       ^~~~~
src/write_sensu.c:1227:43: note: format string is defined here
 1227 |       DEBUG("write_sensu plugin: Got tag: %s", tmp);
      |

3 years agoDon't hide errors when creating manpage
Ruben Kerkhof [Tue, 19 Feb 2019 17:27:46 +0000 (18:27 +0100)]
Don't hide errors when creating manpage

Apparently the default behaviour for pod2man changed at some point and
now it exits with a syntax error instead of exiting successfully with a
<POD ERRORS> section.

Now we do display the syntax issue:
[ruben@localhost collectd]$ make -j
  POD2MAN  src/collectd.conf.5
src/collectd.conf.pod around line 10361: You forgot a '=back' before '=head2'
POD document had syntax errors at /usr/bin/pod2man line 69.
make: *** [Makefile:9641: src/collectd.conf.5] Error 255

3 years agoMerge pull request #3091 from rubenk/reduce-allocations
Pavel Rochnyak [Tue, 19 Feb 2019 12:15:01 +0000 (19:15 +0700)]
Merge pull request #3091 from rubenk/reduce-allocations

Reduce the nr of allocations when parsing types.db

3 years agoPlease clang
Ruben Kerkhof [Tue, 19 Feb 2019 11:39:00 +0000 (12:39 +0100)]
Please clang

3 years agoReduce the nr of allocations when parsing types.db
Ruben Kerkhof [Tue, 19 Feb 2019 10:58:26 +0000 (11:58 +0100)]
Reduce the nr of allocations when parsing types.db

We allocate a number of times for each line in types.db.
Since plugin_register_dataset() makes a copy of the dataset anyway, we
can create the dataset on the stack instead of the heap.

This reduces the number of calloc calls on my system from 624 to 337
when running collectd -T with the default types.db.

3 years agolua plugin: cleanup properly when shutting down
Ruben Kerkhof [Tue, 19 Feb 2019 09:57:03 +0000 (10:57 +0100)]
lua plugin: cleanup properly when shutting down

Found while running collectd -T under valgrind:

==25971== 75 (64 direct, 11 indirect) bytes in 1 blocks are definitely lost in loss record 154 of 274
==25971==    at 0x483AB1A: calloc (vg_replace_malloc.c:762)
==25971==    by 0x4854009: lua_cb_register_read (lua.c:288)
==25971==    by 0x4FBE886: ???
==25971==    by 0x4FD4900: ???
==25971==    by 0x4FBEAD7: ???
==25971==    by 0x4FBEB04: ???
==25971==    by 0x4FBDF16: ???
==25971==    by 0x4FBEE5E: ???
==25971==    by 0x4FB53ED: ???
==25971==    by 0x48536E7: lua_script_load (lua.c:465)
==25971==    by 0x485387E: lua_config_script (lua.c:532)
==25971==    by 0x485395E: lua_config (lua.c:557)

3 years agoMerge pull request #3085 from rubenk/handle_simple_config_errors
Ruben Kerkhof [Tue, 19 Feb 2019 09:08:04 +0000 (10:08 +0100)]
Merge pull request #3085 from rubenk/handle_simple_config_errors

Handle failure of simple config callbacks

3 years agoMerge pull request #3086 from rubenk/reduce-configure-noise
Pavel Rochnyak [Tue, 19 Feb 2019 08:14:30 +0000 (15:14 +0700)]
Merge pull request #3086 from rubenk/reduce-configure-noise

Reduce the amount of output from ./configure

3 years agoMerge pull request #3088 from rubenk/fix-syntax-in-collectd-lua-manpage
Pavel Rochnyak [Tue, 19 Feb 2019 04:58:05 +0000 (11:58 +0700)]
Merge pull request #3088 from rubenk/fix-syntax-in-collectd-lua-manpage

Fix syntax in collectd lua manpage

3 years agoFix some rendering issues in collectd-lua(5)
Ruben Kerkhof [Mon, 18 Feb 2019 16:10:49 +0000 (17:10 +0100)]
Fix some rendering issues in collectd-lua(5)

3 years agocollectd.conf(5): fix a typo
Ruben Kerkhof [Mon, 18 Feb 2019 15:59:48 +0000 (16:59 +0100)]
collectd.conf(5): fix a typo

3 years agoReduce the amount of output from ./configure
Ruben Kerkhof [Mon, 18 Feb 2019 15:59:08 +0000 (16:59 +0100)]
Reduce the amount of output from ./configure

All these flags can be found in config.log if needed.

3 years agoMerge pull request #3080 from rubenk/rrdcached-cleanup
Pavel Rochnyak [Mon, 18 Feb 2019 14:31:39 +0000 (21:31 +0700)]
Merge pull request #3080 from rubenk/rrdcached-cleanup

Rrdcached cleanup

3 years agoClarify error message a bit
Ruben Kerkhof [Mon, 18 Feb 2019 14:02:00 +0000 (15:02 +0100)]
Clarify error message a bit

It's not really the reading of the file(s) that fails, they can be read
fine, there are just errors in the config.

3 years agoDo not suggest to read the logs if parsing config fails
Ruben Kerkhof [Mon, 18 Feb 2019 14:00:30 +0000 (15:00 +0100)]
Do not suggest to read the logs if parsing config fails

There are no logs at this point, all output goes to stderr.

Furthermore, spreading a log message over two lines is bad practice.

3 years agoHandle failure of simple config callbacks
Ruben Kerkhof [Mon, 18 Feb 2019 13:46:55 +0000 (14:46 +0100)]
Handle failure of simple config callbacks

When they return an error, collectd should not ignore this.
Fixes #3076

3 years agorrdcached: a few minor cleanups
Ruben Kerkhof [Mon, 18 Feb 2019 11:09:46 +0000 (12:09 +0100)]
rrdcached: a few minor cleanups

3 years agoMerge pull request #3078 from nward/document_snmp_complex_reads
Florian Forster [Sat, 16 Feb 2019 06:11:11 +0000 (07:11 +0100)]
Merge pull request #3078 from nward/document_snmp_complex_reads

Document the snmp plugin's use of complex reads

3 years agoUpdate documentation to reflect how threads really work these days.
Nathan Ward [Sat, 16 Feb 2019 04:26:47 +0000 (17:26 +1300)]
Update documentation to reflect how threads really work these days.
Tidy up a few end of line whitespaces (editor does it automatically).

3 years agoMerge pull request #3070 from rubenk/travis-improvements
Florian Forster [Fri, 15 Feb 2019 21:05:59 +0000 (22:05 +0100)]
Merge pull request #3070 from rubenk/travis-improvements

Travis improvements

3 years agocirrus.yml: add --disable-dependency-tracking option by default
Marc Fournier [Fri, 15 Feb 2019 19:38:02 +0000 (20:38 +0100)]
cirrus.yml: add --disable-dependency-tracking option by default

3 years agocirrus.yml: fix a couple of typos
Marc Fournier [Fri, 15 Feb 2019 19:32:26 +0000 (20:32 +0100)]
cirrus.yml: fix a couple of typos

3 years agorrdcached plugin: use designated structure initializer
Ruben Kerkhof [Wed, 13 Feb 2019 18:13:11 +0000 (19:13 +0100)]
rrdcached plugin: use designated structure initializer

3 years agorrdcached plugin: use same attribute name for both prototypes
Ruben Kerkhof [Wed, 13 Feb 2019 17:45:53 +0000 (18:45 +0100)]
rrdcached plugin: use same attribute name for both prototypes

3 years agoTravis: try to fix env settings
Ruben Kerkhof [Tue, 12 Feb 2019 13:13:34 +0000 (14:13 +0100)]
Travis: try to fix env settings

3 years agoTravis: try to fix protobuf header detection
Ruben Kerkhof [Tue, 12 Feb 2019 13:12:13 +0000 (14:12 +0100)]
Travis: try to fix protobuf header detection