Antoine Naud [Mon, 28 Aug 2017 09:55:19 +0000 (10:55 +0100)]
src/virt.c: add lifecycle transition notifications
Notifications about VM state are received on every read interval, so the same
notification about specific VM state is received several times within a minute,
which lead to growing log files. This issue is fixed by generating notifications
only for VM state changes (denoted also here lifecycle transitions).
This commit adds a binary option PersistentNotification to virt plugin. When
this option is set to false (default value), only VM state changes are notified
as soon as they occur. When this option is set to true, VM states are notified
on every read interval.
Change-Id: I46ebe2d2f1b72432e7b458530c4cc0eac3e26c6a
Signed-off-by: Antoine Naud <antoinex.naud@intel.com>
Kamil Wiatrowski [Mon, 12 Feb 2018 11:12:44 +0000 (11:12 +0000)]
intel_pmu: fix epel6 compilation issue
To avoid compilation error on some versions of gcc the
saveptr for strtok_r needs to be initilised to NULL.
Change-Id: I7b30e51ecae33a6994ba7ea181cac0f33eef023f
Signed-off-by: Kamil Wiatrowski <kamilx.wiatrowski@intel.com>
Kamil Wiatrowski [Fri, 2 Feb 2018 14:25:56 +0000 (14:25 +0000)]
intel_pmu,intel_rdt plugins: apply formatting rules
Run script contrib/format.sh to format the code.
Replace zu with new collectd macro PRIsz.
Change-Id: I167b1065461e924d7ab260a35f85f5ab162c4165
Signed-off-by: Kamil Wiatrowski <kamilx.wiatrowski@intel.com>
Kamil Wiatrowski [Thu, 2 Nov 2017 13:12:45 +0000 (13:12 +0000)]
intel_rdt: remove redundant code with utils_config_cores
Use utils_config_cores for core groups configuration so it is
in line with intel_pmu and reduce amount of redundant code.
Change-Id: If02e2eeea8bcf3e0df705ebcd9a6310b549b5ebe
Signed-off-by: Kamil Wiatrowski <kamilx.wiatrowski@intel.com>
Kamil Wiatrowski [Tue, 8 Aug 2017 14:04:46 +0000 (15:04 +0100)]
intel_pmu plugin: implement core groups option
Having this option will allow to configure monitoring of PMU
events only on specific CPUs thus decrease number of opened
descriptors significantly and avoid 'Too many open files' errors.
New "Cores" option is similar to that available in intel_rdt plugin.
New tool utils_config_cores is added to parse "Cores" option.
Change-Id: I8f792e1f2560c4cf19aee101fdb07c925d682778
Signed-off-by: Kamil Wiatrowski <kamilx.wiatrowski@intel.com>
Pavel Rochnyak [Sun, 18 Feb 2018 18:39:03 +0000 (01:39 +0700)]
Merge pull request #2692 from shastah/fix-readiness-spelling
s/readyness/readiness/
Jakub Jankowski [Sat, 17 Feb 2018 22:49:10 +0000 (23:49 +0100)]
s/readyness/readiness/
Signed-off-by: Jakub Jankowski <shasta@toxcorp.com>
Jakub Jankowski [Fri, 16 Feb 2018 23:52:48 +0000 (00:52 +0100)]
spec: fix mbmon/mcelog typo
Fix a typo in collectd.spec which manifested when building with
with_mcelog set to false, invalidating with_mbmon setting.
Signed-off-by: Jakub Jankowski <shasta@toxcorp.com>
Dylan Stephano-Shachter [Thu, 15 Feb 2018 21:37:33 +0000 (16:37 -0500)]
change HAVE_UDEV_H to HAVE_LIBUDEV_H for bug 2651
Pavel Rochnyak [Wed, 14 Feb 2018 08:13:09 +0000 (15:13 +0700)]
Merge pull request #2687 from jeis2497052/master
Propose fix some typos
John Eismeier [Tue, 13 Feb 2018 18:52:43 +0000 (13:52 -0500)]
Propose fix some typos
Pavel Rochnyak [Mon, 12 Feb 2018 08:20:10 +0000 (15:20 +0700)]
Merge pull request #2676 from elfiesmelfie/fix_intel_pmu_crash
intel_pmu: fix for possible null pointer dereference
Kamil Wiatrowski [Mon, 5 Feb 2018 13:57:13 +0000 (13:57 +0000)]
intel_pmu: fix for possible null pointer dereference
Null pointer dereference could occur for invalid first hardware event.
In pmu_add_hw_events if the first event was not resolved, on the second
iteration the eventlist_last could be dereferenced to mark previous
event as group leader.
Change-Id: Ic2a2a3572d6835ca892d71f3e66812f356592d9e
Signed-off-by: Kamil Wiatrowski <kamilx.wiatrowski@intel.com>
Pavel Rochnyak [Sat, 10 Feb 2018 11:23:08 +0000 (18:23 +0700)]
Merge pull request #2684 from rpv-tomsk/fix-2673
write_prometheus: Set SO_REUSEADDR on listening socket
Pavel Rochnyak [Sat, 10 Feb 2018 11:19:02 +0000 (18:19 +0700)]
Merge pull request #2613 from elfiesmelfie/update_dpdk_note
docs: update dpdkstats documentation
Pavel Rochnyack [Sat, 10 Feb 2018 10:46:30 +0000 (17:46 +0700)]
write_prometheus: Set SO_REUSEADDR on listening socket
Otherwise Collectd fails to bind the socket after restart.
Thanks to Richard Weinberger and Brandon Hume for reporting.
Closes: #2570
Closes: #2673
collectd bot [Sat, 10 Feb 2018 10:12:50 +0000 (11:12 +0100)]
Auto-Merge pull request #2683 from rpv-tomsk/fix-2607
Automatically merged due to "Automerge" label
Pavel Rochnyack [Sat, 10 Feb 2018 09:20:41 +0000 (09:20 +0000)]
write_kafka: 'rd_kafka_errno2err' is deprecated, fix failed builds
Since librdkafka-0.11.0 applications should use rd_kafka_last_error()
to retrieve the error code from the legacy APIs.
Thanks to hikdo.
Closes: #2607
Closes: #2628
Closes: #2640
Maryam Tahhan [Fri, 26 Jan 2018 11:41:57 +0000 (11:41 +0000)]
Update BUILD.dpdkstat.md
fixed trailing word "Version"
Pavel Rochnyak [Wed, 24 Jan 2018 05:19:17 +0000 (12:19 +0700)]
Merge pull request #2660 from pbostley/master
Adding support for CDAB endian 32-bit modbus polls
PJ Bostley [Tue, 23 Jan 2018 22:33:23 +0000 (15:33 -0700)]
Adding documentation for the Modbus little endian modes where 32 bit values have thier registers swapped
PJ Bostley [Sat, 20 Jan 2018 23:39:36 +0000 (16:39 -0700)]
Adding support for CDAB endian 32-bit modbus polls
Andrew Smith [Sat, 20 Jan 2018 16:32:29 +0000 (11:32 -0500)]
fix src format
Andrew Smith [Mon, 15 Jan 2018 14:09:21 +0000 (09:09 -0500)]
Add notify handler
collectd bot [Tue, 19 Dec 2017 14:09:45 +0000 (15:09 +0100)]
Auto-Merge pull request #2629 from rpv-tomsk/fix-2626
Automatically merged due to "Automerge" label
Pavel Rochnyack [Tue, 19 Dec 2017 13:30:12 +0000 (20:30 +0700)]
ipmi plugin: Fix broken 'Sensor' configuration option
Sebastian Harl [Fri, 15 Dec 2017 13:10:08 +0000 (14:10 +0100)]
Merge pull request #2512 from Stackdriver/pri
Replace zu with PRIsz and llu with PRIu64.
Pavel Rochnyack [Thu, 14 Dec 2017 16:38:05 +0000 (23:38 +0700)]
Merge branch 'collectd-5.8'
collectd bot [Thu, 14 Dec 2017 15:05:23 +0000 (16:05 +0100)]
Auto-Merge pull request #2611 from rpv-tomsk/fix-2587
Automatically merged due to "Automerge" label
Pavel Rochnyack [Sun, 10 Dec 2017 17:14:01 +0000 (17:14 +0000)]
tail plugin, latency: Fix regressions after #2535
- Remove two fixed decimal places from type instance of percentiles
- Recover accuracy of bounds in type instance of buckets
+ Allow (compared to state before #2535) to report percentiles with fractional values
* Changed maximum length of reported type and type instance to 50 chars
References: #2535
Closes: #2587
Andrew Smith [Thu, 10 Aug 2017 14:00:30 +0000 (10:00 -0400)]
initial commit for amqp1 plugin
Maryam Tahhan [Tue, 12 Dec 2017 16:36:52 +0000 (16:36 +0000)]
docs: dpdk extended the initial note
Maryam Tahhan [Mon, 11 Dec 2017 16:14:20 +0000 (16:14 +0000)]
docs: update dpdkstats documentation
Update the dpdkstats documentation to state that it shouldn't be used with
OVS-with-DPDK. The Open vSwitch plugins is what should be used.
Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
collectd bot [Sun, 10 Dec 2017 21:10:59 +0000 (22:10 +0100)]
Auto-Merge pull request #2612 from rpv-tomsk/collectd-5.8-memcached
Automatically merged due to "Automerge" label
Pavel Rochnyack [Sun, 10 Dec 2017 20:24:33 +0000 (03:24 +0700)]
memcached: Check for closed connection to avoid deadloop
Check for 'recv(...) == 0' condition was missing.
collectd bot [Sun, 10 Dec 2017 16:17:05 +0000 (17:17 +0100)]
Auto-Merge pull request #2610 from rpv-tomsk/fix-2609
Automatically merged due to "Automerge" label
Pavel Rochnyack [Sun, 10 Dec 2017 15:06:00 +0000 (22:06 +0700)]
processes plugin: Fix compilation when ps_delay() not used.
Remove unused ps_delay() function when compiled without libtaskstats/libmnl
Closes: #2609
Florian Forster [Fri, 8 Dec 2017 18:51:50 +0000 (19:51 +0100)]
Merge pull request #2598 from octo/ff/delayacct
processes plugin: Add support for Linux Delay Accounting.
Florian Forster [Fri, 8 Dec 2017 08:39:59 +0000 (09:39 +0100)]
processes plugin: Use the new "delay_rate" type for Delay Accounting.
Florian Forster [Fri, 8 Dec 2017 07:28:35 +0000 (08:28 +0100)]
processes plugin: Add the "delay-" prefix to type instances.
This fixes a regression introduced in
17b81d4fa4eabbb7c029ccf424f43e4d89c27e35.
Florian Forster [Thu, 7 Dec 2017 21:20:28 +0000 (22:20 +0100)]
processes plugin: Fix error message.
Florian Forster [Thu, 7 Dec 2017 20:51:22 +0000 (21:51 +0100)]
processes plugin: Make delay metric reporting less repetitive.
Florian Forster [Thu, 7 Dec 2017 20:25:40 +0000 (21:25 +0100)]
contrib/systemd.collectd.service: Add the processes plugin.
Florian Forster [Thu, 7 Dec 2017 20:20:40 +0000 (21:20 +0100)]
processes plugin: Check for the CAP_NET_ADMIN capability.
This allows us to print helpful error messages to the user if something
goes wrong.
collectd bot [Thu, 7 Dec 2017 18:03:14 +0000 (19:03 +0100)]
Auto-Merge pull request #2605 from maryamtahhan/feat_turbostat_report_skl
Automatically merged due to "Automerge" label
Gordon Kelly [Thu, 7 Dec 2017 17:08:14 +0000 (12:08 -0500)]
turbostat: Add support of reporting GPU power on SKL in turbostat
Change-Id: Icb57cf5ab116069b1e4d9580e248af1207e3282b
Toshiaki Takahashi [Wed, 6 Dec 2017 12:19:41 +0000 (12:19 +0000)]
df: fix memory leak in error case
Because the memory of the STATANYFS list is not released
when the read callback function error occurs,
a memory leak may occur.
With this change, the memory is always released
by not returning in the loop.
Signed-off-by: Florian Forster <octo@collectd.org>
Florian Forster [Thu, 7 Dec 2017 16:12:35 +0000 (17:12 +0100)]
Merge branch 'collectd-5.8'
Florian Forster [Thu, 7 Dec 2017 16:10:05 +0000 (17:10 +0100)]
Merge branch 'collectd-5.7' into collectd-5.8
Florian Forster [Thu, 7 Dec 2017 16:06:49 +0000 (17:06 +0100)]
Makefile.am: Fix out-of-tree builds.
Fixes: #2602
Florian Forster [Wed, 6 Dec 2017 21:24:34 +0000 (22:24 +0100)]
processes plugin: Implement the "CollectDelayAccounting" option.
Florian Forster [Wed, 6 Dec 2017 21:03:52 +0000 (22:03 +0100)]
src/utils_taskstats.[ch]: Add library for Linux Delay Accounting.
collectd bot [Wed, 6 Dec 2017 10:12:13 +0000 (11:12 +0100)]
Auto-Merge pull request #2593 from octo/ff/grpc
Automatically merged due to "Automerge" label
Florian Forster [Wed, 6 Dec 2017 09:00:09 +0000 (10:00 +0100)]
configure: Be more verbose about why the grpc plugin cannot be built.
Florian Forster [Wed, 6 Dec 2017 08:58:06 +0000 (09:58 +0100)]
configure: Improve detection of grpc_cpp_plugin.
When the `--with-libgrpc++=<path>` command line argument is given, add
`<path>/bin` to the search path for grpc_cpp_plugin.
Sean Campbell [Wed, 6 Dec 2017 00:05:08 +0000 (19:05 -0500)]
Merge branch 'master' into pri
campbellsean@google.com [Tue, 31 Oct 2017 16:21:08 +0000 (12:21 -0400)]
Replace zu with PRIu64 and llu with new macro, PRIsz, which will make it easier to make the code platform-independent.
Florian Forster [Tue, 5 Dec 2017 15:58:29 +0000 (16:58 +0100)]
liboconfig: Coding style changes.
Mostly whitespace.
Florian Forster [Tue, 5 Dec 2017 15:56:53 +0000 (16:56 +0100)]
liboconfig: Improve error handling.
* Use the YYERROR macro instead of exit(3).
* Remove newlines from strings passed to yyerror().
* Change return valud or yyerror() from int to void.
Florian Forster [Tue, 5 Dec 2017 15:53:34 +0000 (16:53 +0100)]
liboconfig: Check return values of calloc() and realloc().
CID: 38123
Florian Forster [Tue, 5 Dec 2017 15:50:33 +0000 (16:50 +0100)]
email plugin: Avoid strtok_r to tokenize input.
Coverity (wrongly) thinks that "type" might have been NULL (since its
first argument is non-NULL, this cannot happen). It has a point about
insufficient NULL-ness checks, though, as "tmp" may very well be NULL and
we're passing it to atoi() which will likely not take this well.
CID: 37988
Florian Forster [Tue, 5 Dec 2017 11:15:17 +0000 (12:15 +0100)]
contrib/format.sh src/grpc.cc
Florian Forster [Tue, 5 Dec 2017 11:15:00 +0000 (12:15 +0100)]
grpc plugin: Implement the VerifyPeer option for servers.
Florian Forster [Tue, 5 Dec 2017 06:33:18 +0000 (07:33 +0100)]
Merge branch 'collectd-5.8'
Florian Forster [Tue, 5 Dec 2017 06:33:13 +0000 (07:33 +0100)]
.travis.yml: Send notifications to the changes ML.
Florian Forster [Mon, 4 Dec 2017 08:53:48 +0000 (09:53 +0100)]
Merge pull request #2590 from maryamtahhan/fix_collectd_ovs_deadlock
Fix collectd ovs deadlock
Aleksei Zakharov [Fri, 1 Dec 2017 16:07:04 +0000 (19:07 +0300)]
ceph plugin: Fix #2572
Signed-off-by: Florian Forster <octo@collectd.org>
Florian Forster [Mon, 4 Dec 2017 07:23:26 +0000 (08:23 +0100)]
Merge branch 'collectd-5.7' into collectd-5.8
Florian Forster [Mon, 4 Dec 2017 07:18:33 +0000 (08:18 +0100)]
table plugin: Add explicit NULL checks to clear functions.
CID: 37966
Florian Forster [Fri, 1 Dec 2017 20:05:00 +0000 (21:05 +0100)]
exec plugin: Check return value of plugin_thread_create().
CID: 37942, 37943
Florian Forster [Fri, 1 Dec 2017 19:45:04 +0000 (20:45 +0100)]
rrdtool plugin: Check return value of c_avl_get().
CID: 37940
collectd bot [Fri, 1 Dec 2017 15:14:57 +0000 (16:14 +0100)]
Auto-Merge pull request #2589 from octo/cid/37960
Automatically merged due to "Automerge" label
Tahhan, Maryam [Wed, 29 Nov 2017 12:50:18 +0000 (12:50 +0000)]
utils_ovs: fix #2574
Poll thread was trying to reconnect after event thread was terminated.
Change-Id: I48bf196302139ddf99bb96b49a6c3b4ede345240
Signed-off-by: Mytnyk, Volodymyr <volodymyrx.mytnyk@intel.com>
collectd bot [Fri, 1 Dec 2017 14:20:59 +0000 (15:20 +0100)]
Auto-Merge pull request #2588 from octo/cid/37968
Automatically merged due to "Automerge" label
Florian Forster [Fri, 1 Dec 2017 13:59:55 +0000 (14:59 +0100)]
contrib/format.sh src/perl.c
Florian Forster [Fri, 1 Dec 2017 13:18:50 +0000 (14:18 +0100)]
powerdns plugin: Remove the unused ret_buffer_size argument …
… from powerdns_get_data().
Florian Forster [Fri, 1 Dec 2017 13:30:23 +0000 (14:30 +0100)]
perl plugin: Fix exporting notification meta data.
Previously, the while loop ensured that meta was NULL, causing the for
loop to never been executed. This introduces a new temporary variable to
avoid changing meta before the for loop.
CID: 37960
Florian Forster [Fri, 1 Dec 2017 11:06:26 +0000 (12:06 +0100)]
powerdns plugin: Declare variables on first use.
Florian Forster [Fri, 1 Dec 2017 11:05:21 +0000 (12:05 +0100)]
powerdns plugin: Ensure powerdns_get_data() returns a non-NULL buffer.
Coverity is concerned that if buffer is NULL, strtok_r() is called with
two NULL arguments, causing a NULL pointer dereference.
CID: 37968
Florian Forster [Fri, 1 Dec 2017 10:26:17 +0000 (11:26 +0100)]
Merge branch 'collectd-5.8'
Florian Forster [Fri, 1 Dec 2017 10:25:18 +0000 (11:25 +0100)]
Merge branch 'collectd-5.8'
Florian Forster [Fri, 1 Dec 2017 10:25:06 +0000 (11:25 +0100)]
.travis.yml: Call coverity scan from job 1 only.
The logic was inverted.
Florian Forster [Thu, 30 Nov 2017 16:11:49 +0000 (17:11 +0100)]
Merge branch 'collectd-5.7' into collectd-5.8
collectd bot [Thu, 30 Nov 2017 09:09:13 +0000 (10:09 +0100)]
Auto-Merge pull request #2586 from octo/issue/2583
Automatically merged due to "Automerge" label
Florian Forster [Thu, 30 Nov 2017 08:33:50 +0000 (09:33 +0100)]
network_parse_test.c: Only test security features if libgcrypt is available.
Fixes: #2583
collectd bot [Wed, 29 Nov 2017 12:32:30 +0000 (13:32 +0100)]
Auto-Merge pull request #2584 from octo/coverity
Automatically merged due to "Automerge" label
Florian Forster [Wed, 29 Nov 2017 07:20:38 +0000 (08:20 +0100)]
.travis.yml: Try to work around travis-ci/travis-ci#1975.
collectd bot [Tue, 28 Nov 2017 08:32:33 +0000 (09:32 +0100)]
Auto-Merge pull request #2580 from octo/cid/179235
Automatically merged due to "Automerge" label
collectd bot [Tue, 28 Nov 2017 08:11:23 +0000 (09:11 +0100)]
Auto-Merge pull request #2579 from octo/cid/179238
Automatically merged due to "Automerge" label
Florian Forster [Tue, 28 Nov 2017 07:24:14 +0000 (08:24 +0100)]
contrib/format.sh src/aggregation.c
Florian Forster [Tue, 28 Nov 2017 07:21:48 +0000 (08:21 +0100)]
aggregation plugin: Check return value of config functions.
CID: 179235
Florian Forster [Tue, 28 Nov 2017 07:17:05 +0000 (08:17 +0100)]
aggregation plugin: Declare variables on initialization.
Florian Forster [Tue, 28 Nov 2017 07:11:07 +0000 (08:11 +0100)]
virt plugin: Remove `do {} while(0)` loop around macro.
The `continue` in the macro was supposed to continue the `for` loop, but
was (unexpectedly) exiting the do…while loop instead.
CID: 179238
Florian Forster [Mon, 27 Nov 2017 21:35:21 +0000 (22:35 +0100)]
.travis.yml: Import list of dependencies from collectd-ci.
Florian Forster [Mon, 27 Nov 2017 21:07:33 +0000 (22:07 +0100)]
.travis.yml: Add coverity addon.
collectd bot [Mon, 27 Nov 2017 21:10:38 +0000 (22:10 +0100)]
Auto-Merge pull request #2576 from octo/collectd-5.8
Automatically merged due to "Automerge" label
Florian Forster [Mon, 27 Nov 2017 20:09:14 +0000 (21:09 +0100)]
contrib/format.sh: Switch to custom domain name.
collectd bot [Sat, 25 Nov 2017 08:18:51 +0000 (09:18 +0100)]
Auto-Merge pull request #2575 from octo/cid/37934
Automatically merged due to "Automerge" label
Florian Forster [Sat, 25 Nov 2017 07:28:35 +0000 (08:28 +0100)]
ping plugin: Lock the mutex later.
Coverity gets confused if holding the lock while allocating pingobj.
CID: 37934
collectd bot [Wed, 22 Nov 2017 07:14:52 +0000 (08:14 +0100)]
Auto-Merge pull request #2568 from octo/cid/157645
Automatically merged due to "Automerge" label