collectd.git
3 years agoMerge branch 'collectd-5.7' into collectd-5.8
Florian Forster [Wed, 20 Feb 2019 09:05:09 +0000 (10:05 +0100)]
Merge branch 'collectd-5.7' into collectd-5.8

3 years agoBuild system: enable the "df" plugin when getmntent_r() is available. collectd-5.7
Florian Forster [Wed, 20 Feb 2019 08:37:53 +0000 (09:37 +0100)]
Build system: enable the "df" plugin when getmntent_r() is available.

Looks like the check result used to be stored in a variable of a
different name.

3 years agoMerge branch 'collectd-5.7' into collectd-5.8
Florian Forster [Sun, 10 Feb 2019 20:44:20 +0000 (21:44 +0100)]
Merge branch 'collectd-5.7' into collectd-5.8

3 years agoAuto-Merge pull request #3063 from octo/issue/3062
collectd bot [Thu, 7 Feb 2019 13:19:41 +0000 (14:19 +0100)]
Auto-Merge pull request #3063 from octo/issue/3062

Automatically merged due to "Automerge" label

3 years agostrjoin(): Fix behavior if output buffer is NULL.
Florian Forster [Thu, 7 Feb 2019 10:33:16 +0000 (11:33 +0100)]
strjoin(): Fix behavior if output buffer is NULL.

Additionally, test the (NULL, 0) output buffer for all test cases rather
than an individual, isolated test case.

Fixes: #3062

3 years agoMerge pull request #3059 from octo/sock_cloexec
Florian Forster [Wed, 6 Feb 2019 22:16:01 +0000 (23:16 +0100)]
Merge pull request #3059 from octo/sock_cloexec

write_prometheus plugin: Only use SOCK_CLOEXEC if it is defined.

3 years agowrite_prometheus plugin: Only use SOCK_CLOEXEC if it is defined.
Florian Forster [Wed, 6 Feb 2019 14:47:00 +0000 (15:47 +0100)]
write_prometheus plugin: Only use SOCK_CLOEXEC if it is defined.

Fixes compilation issue on Mac OS X. See also #3055.

3 years agoMerge pull request #3040 from AlexZzz/collectd-5.8
Pavel Rochnyak [Wed, 30 Jan 2019 07:44:10 +0000 (14:44 +0700)]
Merge pull request #3040 from AlexZzz/collectd-5.8

Backport: netlink plugin: Use of less strict rules in link_filter_cb()

3 years agonetlink plugin: Use of less strict rules in link_filter_cb()
Pavel Rochnyack [Mon, 7 May 2018 15:53:23 +0000 (22:53 +0700)]
netlink plugin: Use of less strict rules in link_filter_cb()

mnl_attr_validate2() function implements strict equality check of kernel and
userspace structures size. Additional counters was added to 4.6 Linux kernel,
sizes was changed and mismatch can occur.

This patch weakened validation.
Now Collectd just checks if structures, received from kernel space, has enough
data.

Closes: #2510

# Conflicts:
# src/netlink.c

4 years agoMerge pull request #3017 from rpv-tomsk/collectd-collectd-5.8
Pavel Rochnyak [Thu, 6 Dec 2018 17:14:04 +0000 (00:14 +0700)]
Merge pull request #3017 from rpv-tomsk/collectd-collectd-5.8

configure.ac: run dpdk build tests only if pkgconfig fails

4 years agoconfigure.ac: run dpdk build tests only if pkgconfig fails
Luca Boccassi [Mon, 3 Dec 2018 15:56:13 +0000 (15:56 +0000)]
configure.ac: run dpdk build tests only if pkgconfig fails

The AC_CHECK_LIB test runs unconditionally, and fails with DPDK 18.11
when built with Meson as there is no longer a libdpdk.so linker script,
but only a pkg-config file, so -ldpdk (which is what AC_CHECK_LIB runs)
fails.

Use AC_LINK_IFELSE instead, with compiler and linker flags set
appropriately.

Signed-off-by: Luca Boccassi <bluca@debian.org>
4 years agoMerge pull request #3013 from rpv-tomsk/collectd-collectd-5.8
Pavel Rochnyak [Mon, 3 Dec 2018 11:57:29 +0000 (18:57 +0700)]
Merge pull request #3013 from rpv-tomsk/collectd-collectd-5.8

sensors: Removed checks for upper limit of SENSORS_API_VERSION

4 years agosensors: Removed checks for upper limit of SENSORS_API_VERSION
Pavel Rochnyack [Mon, 3 Dec 2018 11:34:14 +0000 (18:34 +0700)]
sensors: Removed checks for upper limit of SENSORS_API_VERSION

That makes no more sense after lm-sensors got new maintainers.

Closes: #3006

4 years agoMerge pull request #3010 from rpv-tomsk/collectd-5.8
Pavel Rochnyak [Sun, 2 Dec 2018 20:03:17 +0000 (03:03 +0700)]
Merge pull request #3010 from rpv-tomsk/collectd-5.8

write_mongodb: Fix plugin dependencies

4 years agowrite_mongodb: Fix plugin dependencies
Pavel Rochnyack [Sun, 2 Dec 2018 19:48:08 +0000 (02:48 +0700)]
write_mongodb: Fix plugin dependencies

Issue: #2900

4 years agoMerge pull request #2994 from octo/tail-doc
Florian Forster [Thu, 15 Nov 2018 16:59:49 +0000 (17:59 +0100)]
Merge pull request #2994 from octo/tail-doc

collectd.conf(5): Improve the tail plugin's documentation.

4 years agocollectd.conf(5): Improve the tail plugin's documentation.
Florian Forster [Thu, 15 Nov 2018 10:46:27 +0000 (11:46 +0100)]
collectd.conf(5): Improve the tail plugin's documentation.

4 years agoMerge pull request #2988 from octo/ff/struct-init-syntax
Florian Forster [Tue, 6 Nov 2018 15:39:11 +0000 (16:39 +0100)]
Merge pull request #2988 from octo/ff/struct-init-syntax

log_logstash plugin: Fix non-portable struct initialization with "{}".

4 years agolog_logstash plugin: Fix non-portable struct initialization with "{}".
Florian Forster [Tue, 6 Nov 2018 14:13:01 +0000 (15:13 +0100)]
log_logstash plugin: Fix non-portable struct initialization with "{}".

4 years agoMerge branch 'collectd-5.7' into collectd-5.8
Pavel Rochnyack [Fri, 26 Oct 2018 15:06:35 +0000 (22:06 +0700)]
Merge branch 'collectd-5.7' into collectd-5.8

Conflicts:
src/utils_mount.c

4 years agoMerge pull request #2975 from octo/issue/2954
Florian Forster [Fri, 26 Oct 2018 06:21:45 +0000 (08:21 +0200)]
Merge pull request #2975 from octo/issue/2954

zfs_arc: Ignore the first two lines of the statistics file on Linux (5.7 cherry-pick)

4 years agocontrib/format.sh src/zfs_arc.c
Florian Forster [Fri, 26 Oct 2018 06:05:41 +0000 (08:05 +0200)]
contrib/format.sh src/zfs_arc.c

4 years agozfs_arc: Ignore the first two lines of the statistics file on Linux.
YmrDtnJu [Sat, 10 Dec 2016 00:30:59 +0000 (01:30 +0100)]
zfs_arc: Ignore the first two lines of the statistics file on Linux.

The first two lines of the statistics file on Linux contain information about
the rest of the file. They do not contain any usable statistics.
See module/spl/spl-kstat.c of the spl module of ZFS on Linux for more
information.

4 years agoMerge pull request #2972 from rpv-tomsk/collectd-collectd-5.8
Florian Forster [Thu, 25 Oct 2018 18:20:46 +0000 (20:20 +0200)]
Merge pull request #2972 from rpv-tomsk/collectd-collectd-5.8

virt plugin: Remove optional virDomainGetCPUStats() from main flow

4 years agovirt plugin: Move `get_pcpu_stats()' down to avoid forward declaration of `submit_der...
Pavel Rochnyack [Thu, 25 Oct 2018 08:44:38 +0000 (15:44 +0700)]
virt plugin: Move `get_pcpu_stats()' down to avoid forward declaration of `submit_derive2()'

4 years agovirt plugin: Submit `ps_cputime' only when data exists
Pavel Rochnyack [Thu, 25 Oct 2018 08:37:20 +0000 (15:37 +0700)]
virt plugin: Submit `ps_cputime' only when data exists

4 years agovirt plugin: Remove optional virDomainGetCPUStats() from main flow
Pavel Rochnyack [Thu, 25 Oct 2018 07:53:33 +0000 (14:53 +0700)]
virt plugin: Remove optional virDomainGetCPUStats() from main flow

virDomainGetCPUStats() call is only required when `pcpu' extra statistics is requested.
While not supported in all configurations, this call may fail which causes failure in
reporting of other domain metrics.

4 years agoMerge pull request #2971 from rubenk/gpsd-fix-build
Pavel Rochnyak [Thu, 25 Oct 2018 05:05:12 +0000 (12:05 +0700)]
Merge pull request #2971 from rubenk/gpsd-fix-build

gps plugin: fix build with newer gpsd

4 years agogps plugin: fix build with newer gpsd
Baruch Siach [Tue, 9 Oct 2018 16:57:21 +0000 (19:57 +0300)]
gps plugin: fix build with newer gpsd

gpsd version 3.18 changed the prototype of gps_read(). Make the
gps_read() call depend on GPSD_API_MAJOR_VERSION to fix that.

This fixes build failures like:

gps.c: In function 'cgps_thread':
gps.c:144:11: error: too few arguments to function 'gps_read'
       if (gps_read(&gpsd_conn) == -1) {
   ^~~~~~~~

(cherry picked from commit 991a6d3fd38c2435d94de3853fda36b3330cf6ab)

4 years agoChangeLog: Correct date for 5.8.1 release.
Florian Forster [Tue, 23 Oct 2018 18:07:19 +0000 (20:07 +0200)]
ChangeLog: Correct date for 5.8.1 release.

4 years agochange HAVE_UDEV_H to HAVE_LIBUDEV_H for bug 2651
Dylan Stephano-Shachter [Thu, 15 Feb 2018 21:37:33 +0000 (16:37 -0500)]
change HAVE_UDEV_H to HAVE_LIBUDEV_H for bug 2651

(cherry picked from commit ed696c1b3adcb42d55759efe6f8034337f0fd243)

4 years agoBump version to 5.8.1; Update ChangeLog.
Florian Forster [Mon, 22 Oct 2018 09:13:43 +0000 (11:13 +0200)]
Bump version to 5.8.1; Update ChangeLog.

4 years agoMerge pull request #2962 from octo/utils_mount
Ruben Kerkhof [Sun, 21 Oct 2018 16:24:36 +0000 (18:24 +0200)]
Merge pull request #2962 from octo/utils_mount

src/utils_mount.c: Add code path for HAVE_GETMNTENT_R.

4 years agosrc/utils_mount.c: Add code path for HAVE_GETMNTENT_R.
Florian Forster [Thu, 18 Oct 2018 16:23:54 +0000 (18:23 +0200)]
src/utils_mount.c: Add code path for HAVE_GETMNTENT_R.

I don't know when this got lost or why it is triggering now, but the
build fails on my machine without this now.

4 years agoMerge branch 'collectd-5.7' into collectd-5.8
Florian Forster [Thu, 18 Oct 2018 06:18:25 +0000 (08:18 +0200)]
Merge branch 'collectd-5.7' into collectd-5.8

4 years agoAuto-Merge pull request #2957 from niuxu18/collectd-5.8
collectd bot [Wed, 17 Oct 2018 06:17:17 +0000 (08:17 +0200)]
Auto-Merge pull request #2957 from niuxu18/collectd-5.8

Automatically merged due to "Automerge" label

4 years agoUpdate virt.c
sarah [Wed, 17 Oct 2018 01:59:21 +0000 (09:59 +0800)]
Update virt.c

4 years agoAuto-Merge pull request #2953 from rpv-tomsk/collectd-collectd-5.8
collectd bot [Sun, 14 Oct 2018 09:13:10 +0000 (11:13 +0200)]
Auto-Merge pull request #2953 from rpv-tomsk/collectd-collectd-5.8

Automatically merged due to "Automerge" label

4 years agontpd: plug potential leak on error
Pavel Rochnyack [Sun, 14 Oct 2018 08:45:56 +0000 (15:45 +0700)]
ntpd: plug potential leak on error

Issue: #2942

4 years agoAuto-Merge pull request #2952 from octo/issue/2951
collectd bot [Fri, 12 Oct 2018 12:18:14 +0000 (14:18 +0200)]
Auto-Merge pull request #2952 from octo/issue/2951

Automatically merged due to "Automerge" label

4 years agodisk plugin: Support Linux kernels with additional fields.
Florian Forster [Fri, 12 Oct 2018 11:18:42 +0000 (13:18 +0200)]
disk plugin: Support Linux kernels with additional fields.

Linux 4.19 will add additional counters, which caused this plugin to
bail out because it checked the number of fields exactly instead of
ensuring that there are *at least* the number of fields expected.

Fixes: #2951

4 years agoAuto-Merge pull request #2949 from rubenk/fix-detection-of-xmms
collectd bot [Thu, 11 Oct 2018 12:14:19 +0000 (14:14 +0200)]
Auto-Merge pull request #2949 from rubenk/fix-detection-of-xmms

Automatically merged due to "Automerge" label

4 years agoFix detection of xmmsctrl.h
Ruben Kerkhof [Thu, 11 Oct 2018 11:00:35 +0000 (13:00 +0200)]
Fix detection of xmmsctrl.h

checking xmmsctrl.h usability... yes
checking xmmsctrl.h presence... no
configure: WARNING: xmmsctrl.h: accepted by the compiler, rejected by the preprocessor!
configure: WARNING: xmmsctrl.h: proceeding with the compiler's result
checking for xmmsctrl.h... yes
checking for xmms_remote_get_info in -lxmms... yes

AC_CHECK_HEADER uses the preprocessor, which doesn't look at CFLAGS.
Use CPPFLAGS so it uses the right include path to look for xmmsctrl.h

4 years agoAuto-Merge pull request #2948 from rubenk/turbostat-free-the-right-vars
collectd bot [Thu, 11 Oct 2018 06:02:46 +0000 (08:02 +0200)]
Auto-Merge pull request #2948 from rubenk/turbostat-free-the-right-vars

Automatically merged due to "Automerge" label

4 years agoturbostat plugin: free the right variable
Ruben Kerkhof [Tue, 29 May 2018 08:37:18 +0000 (10:37 +0200)]
turbostat plugin: free the right variable

scan-build: Using '/usr/bin/clang-6.0' for static analysis
make  all-am
make[1]: Entering directory '/home/ruben/src/collectd'
  CC       src/turbostat.lo
src/turbostat.c:1292:5: warning: Argument to free() is the address of the global variable 'thread_delta', which is not memory allocated by malloc()
    sfree(threads);
    ^~~~~~~~~~~~~~
./src/daemon/common.h:41:5: note: expanded from macro 'sfree'
    free(ptr);                                                                 \
    ^~~~~~~~~
src/turbostat.c:1299:5: warning: Argument to free() is the address of the global variable 'core_delta', which is not memory allocated by malloc()
    sfree(cores);
    ^~~~~~~~~~~~
./src/daemon/common.h:41:5: note: expanded from macro 'sfree'
    free(ptr);                                                                 \
    ^~~~~~~~~
2 warnings generated.
  CCLD     turbostat.la

(cherry picked from commit 74eda959ddf653b7d20779d84f0a140e85376726)

4 years agoexec: fix potential deadlock after fork()
Daniel Vrátil [Wed, 12 Sep 2018 15:05:31 +0000 (17:05 +0200)]
exec: fix potential deadlock after fork()

POSIX forbids calling functions which are not thread-safe like
setenv() after fork() in multi-threaded programs. It happens to
work just fine with some libc implementations, but it causes a
deadlock in the child process with uClibc for example.

The proper way to pass new environment variables to the child
process is to update parent's environment before the fork(), so
that the child inherits the updated environment and then undo the
changes in the parent process again.

Signed-off-by: Florian Forster <octo@collectd.org>
4 years agoexec: Call putenv() with a global buffer
Daniel Vrátil [Wed, 12 Sep 2018 15:20:00 +0000 (17:20 +0200)]
exec: Call putenv() with a global buffer

putenv() adds the string pointer to the environment so it should
not be called with an automatic variable.

Signed-off-by: Florian Forster <octo@collectd.org>
4 years agoAuto-Merge pull request #2942 from rubenk/ntpd-plug-leak
collectd bot [Tue, 9 Oct 2018 11:38:05 +0000 (13:38 +0200)]
Auto-Merge pull request #2942 from rubenk/ntpd-plug-leak

Automatically merged due to "Automerge" label

4 years agontpd: plug potential leak on error
Ruben Kerkhof [Tue, 9 Oct 2018 08:36:48 +0000 (10:36 +0200)]
ntpd: plug potential leak on error

Found by scan-build:

src/ntpd.c:833:5: warning: Potential memory leak
    ERROR("ntpd plugin: ntpd_do_query (REQ_GET_KERNEL) failed with status %i",
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./src/daemon/plugin.h:391:20: note: expanded from macro 'ERROR'
                   ^~~~~~~~~~
1 warning generated.

4 years agopowerdns plugin: no-packet-error counts number of erroneous packets; it should be...
Mariusz Gronczewski [Fri, 17 Aug 2018 14:35:11 +0000 (16:35 +0200)]
powerdns plugin: no-packet-error counts number of erroneous packets; it should be returned as counter (like other query/hit/miss counters), not gauge

Signed-off-by: Florian Forster <octo@collectd.org>
4 years agoAuto-Merge pull request #2941 from octo/backport/01cf776
collectd bot [Tue, 9 Oct 2018 06:08:03 +0000 (08:08 +0200)]
Auto-Merge pull request #2941 from octo/backport/01cf776

Automatically merged due to "Automerge" label

4 years agoceph plugin: fix scan-build warnings
Ruben Kerkhof [Wed, 30 May 2018 13:08:15 +0000 (15:08 +0200)]
ceph plugin: fix scan-build warnings

src/ceph.c:284:8: warning: Null pointer argument in call to string comparison function
  (strcmp("filestore", state->stack[state->depth - 2]) == 0) &&
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/x86_64-linux-gnu/bits/string2.h:817:8: note: expanded from macro 'strcmp'
: __builtin_strcmp (s1, s2)))); })
  ^~~~~~~~~~~~~~~~~~~~~~~~~
src/ceph.c:285:8: warning: Null pointer argument in call to string comparison function
  (strcmp("journal_wr_bytes", state->stack[state->depth - 1]) == 0) &&
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/x86_64-linux-gnu/bits/string2.h:817:8: note: expanded from macro 'strcmp'
: __builtin_strcmp (s1, s2)))); })
  ^~~~~~~~~~~~~~~~~~~~~~~~~
2 warnings generated.

Cherry-pick for collectd-5.8.

4 years agoMerge branch 'collectd-5.7' into collectd-5.8
Florian Forster [Mon, 8 Oct 2018 09:48:54 +0000 (11:48 +0200)]
Merge branch 'collectd-5.7' into collectd-5.8

4 years agoAuto-Merge pull request #2939 from octo/pr2937-backport
collectd bot [Mon, 8 Oct 2018 09:33:29 +0000 (11:33 +0200)]
Auto-Merge pull request #2939 from octo/pr2937-backport

Automatically merged due to "Automerge" label

4 years agoexec plugin: dynamically allocate grname buffer.
smallem [Thu, 4 Oct 2018 17:54:44 +0000 (13:54 -0400)]
exec plugin: dynamically allocate grname buffer.

Backport of a fix in master.

Fixes: #2696

4 years agoMerge pull request #2919 from rubenk/virt-fix-segfault
Ruben Kerkhof [Wed, 5 Sep 2018 06:38:09 +0000 (08:38 +0200)]
Merge pull request #2919 from rubenk/virt-fix-segfault

Fix segfault in libvirt plugin

4 years agovirt plugin: fix segfault on error path
Ruben Kerkhof [Tue, 4 Sep 2018 10:48:12 +0000 (12:48 +0200)]
virt plugin: fix segfault on error path

The libvirt plugin refreshes its list of domains every RefreshInterval
seconds. If a domain crashes after getting the list, getting the stats
for its block devices returns an error. We then try to call
virDomainGetName on an invalid pointer. Fix this.

4 years agoAuto-Merge pull request #2916 from rpv-tomsk/collectd-collectd-5.8
collectd bot [Thu, 30 Aug 2018 06:48:03 +0000 (08:48 +0200)]
Auto-Merge pull request #2916 from rpv-tomsk/collectd-collectd-5.8

Automatically merged due to "Automerge" label

4 years agonfs: Fix number of fields for NFSv4
Jan-Philipp Litza [Wed, 29 Aug 2018 20:46:49 +0000 (22:46 +0200)]
nfs: Fix number of fields for NFSv4

The previous buffer of 64 fields was too short for the current number of
72+2 fields in NFS 4.2, causing the message

  nfs plugin: Unexpected number of fields for NFSv4 server statistics: 62.

This change, originally proposed in [1], fixes that issue in a
forward-compatible manner by reusing the already known number of fields
from the static arrays.

[1]: https://github.com/collectd/collectd/issues/2076#issuecomment-350466628

4 years agoFix parsing option for avoiding making BaseDir
Mariusz Bialonczyk [Tue, 10 Jul 2018 09:47:53 +0000 (11:47 +0200)]
Fix parsing option for avoiding making BaseDir

Parsing is broken since:
386ecab4 Reading configuration file is now done outside main().
So after mentioned commit we've got:

collectd: invalid option -- 'B'

This commit fixes this.

4 years agoAuto-Merge pull request #2850 from rpv-tomsk/collectd-collectd-5.8
collectd bot [Sat, 7 Jul 2018 15:31:54 +0000 (17:31 +0200)]
Auto-Merge pull request #2850 from rpv-tomsk/collectd-collectd-5.8

Automatically merged due to "Automerge" label

4 years agowrite_prometheus: Added MHD_USE_INTERNAL_POLLING_THREAD flag
Pavel Rochnyack [Sat, 7 Jul 2018 14:38:07 +0000 (21:38 +0700)]
write_prometheus: Added MHD_USE_INTERNAL_POLLING_THREAD flag

Since 0.9.53, libmicrohttpd requires explicit setting of this flag.

Closes: #2849

4 years agoAuto-Merge pull request #2793 from rpv-tomsk/fix-5.8
collectd bot [Wed, 23 May 2018 11:10:03 +0000 (13:10 +0200)]
Auto-Merge pull request #2793 from rpv-tomsk/fix-5.8

Automatically merged due to "Automerge" label

4 years agoInclude kstat.h when available
Dagobert Michelsen [Wed, 21 Mar 2018 20:22:45 +0000 (21:22 +0100)]
Include kstat.h when available

4 years agoFix make distcheck on Mac OS
Ruben Kerkhof [Wed, 16 May 2018 11:24:55 +0000 (13:24 +0200)]
Fix make distcheck on Mac OS

  CC       src/libcollectdclient/libcollectdclient_la-network_parse.lo
../../src/libcollectdclient/network_parse.c:49:10: fatal error: 'stdendian.h' file not found
         ^~~~~~~~~~~~~
1 error generated.

Fixes #2608

4 years agoAuto-Merge pull request #2792 from rpv-tomsk/fix-5.8
collectd bot [Wed, 23 May 2018 09:15:47 +0000 (11:15 +0200)]
Auto-Merge pull request #2792 from rpv-tomsk/fix-5.8

Automatically merged due to "Automerge" label

4 years agoAdded missing include of "collectd.h"
Pavel Rochnyack [Sun, 20 May 2018 16:24:25 +0000 (23:24 +0700)]
Added missing include of "collectd.h"

This adressed to solve compilation issue on Solaris platform:

./src/config.h:1526:0: error: "_FILE_OFFSET_BITS" redefined [-Werror]

4 years agoAdd endianness checks for AIX
Dagobert Michelsen [Thu, 3 May 2018 10:42:28 +0000 (12:42 +0200)]
Add endianness checks for AIX

4 years agoAuto-Merge pull request #2788 from rpv-tomsk/fix-5.8
collectd bot [Mon, 21 May 2018 06:32:58 +0000 (08:32 +0200)]
Auto-Merge pull request #2788 from rpv-tomsk/fix-5.8

Automatically merged due to "Automerge" label

4 years agoFix gcc issue on Mac byteorder
Dagobert Michelsen [Thu, 5 Apr 2018 08:49:30 +0000 (10:49 +0200)]
Fix gcc issue on Mac byteorder

4 years agoFix conditional on byteorder to work on Solaris
Dagobert Michelsen [Wed, 4 Apr 2018 12:34:15 +0000 (14:34 +0200)]
Fix conditional on byteorder to work on Solaris

4 years agoKeep clang-format happy
Dagobert Michelsen [Wed, 21 Mar 2018 21:23:07 +0000 (22:23 +0100)]
Keep clang-format happy

4 years agoAdd fallback for endianess conversion
Dagobert Michelsen [Wed, 21 Mar 2018 21:09:15 +0000 (22:09 +0100)]
Add fallback for endianess conversion

4 years agoAuto-Merge pull request #2787 from rpv-tomsk/fix-5.8
collectd bot [Mon, 21 May 2018 04:18:17 +0000 (06:18 +0200)]
Auto-Merge pull request #2787 from rpv-tomsk/fix-5.8

Automatically merged due to "Automerge" label

4 years agoAdded missing include of 'config.h'
Pavel Rochnyack [Mon, 21 May 2018 03:38:51 +0000 (10:38 +0700)]
Added missing include of 'config.h'

This adressed to solve compilation issue on Solaris platform:

In file included from src/libcollectdclient/network_parse.c:26:0,
                 from src/libcollectdclient/network_parse_test.c:32:
                 ./src/config.h:1517:0: error: "_FILE_OFFSET_BITS" redefined

4 years agoAuto-Merge pull request #2786 from rpv-tomsk/fix-5.8
collectd bot [Sun, 20 May 2018 20:22:12 +0000 (22:22 +0200)]
Auto-Merge pull request #2786 from rpv-tomsk/fix-5.8

Automatically merged due to "Automerge" label

4 years agoAdded missing include of 'kstat.h' and variable declaration
Pavel Rochnyack [Sun, 20 May 2018 19:35:44 +0000 (02:35 +0700)]
Added missing include of 'kstat.h' and variable declaration

This adressed to solve compilation issue on Solaris platform:

src/daemon/collectd.c:212: error: 'kc' undeclared (first use in this function)
src/daemon/collectd.c:213: error: implicit declaration of function 'kstat_open'

4 years agoAuto-Merge pull request #2785 from rpv-tomsk/fix-5.8
collectd bot [Sun, 20 May 2018 19:21:30 +0000 (21:21 +0200)]
Auto-Merge pull request #2785 from rpv-tomsk/fix-5.8

Automatically merged due to "Automerge" label

4 years agoTry to make clang-format happy
Pavel Rochnyack [Sun, 20 May 2018 17:57:27 +0000 (00:57 +0700)]
Try to make clang-format happy

4 years agoAdded missing include of 'kstat.h'
Pavel Rochnyack [Sun, 20 May 2018 17:52:33 +0000 (00:52 +0700)]
Added missing include of 'kstat.h'

This adressed to solve compilation issue on Solaris platform:

src/utils_vl_lookup.c:37:1: error: unknown type name 'kstat_ctl_t'
 kstat_ctl_t *kc;

4 years agoAuto-Merge pull request #2784 from rpv-tomsk/fix-5.8
collectd bot [Sun, 20 May 2018 17:21:04 +0000 (19:21 +0200)]
Auto-Merge pull request #2784 from rpv-tomsk/fix-5.8

Automatically merged due to "Automerge" label

4 years agoAdded missing include of 'kstat.h'
Pavel Rochnyack [Sun, 20 May 2018 16:48:00 +0000 (23:48 +0700)]
Added missing include of 'kstat.h'

This adressed to solve compilation issue on Solaris platform:

src/daemon/common.c:64:8: error: unknown type name 'kstat_ctl_t'
  extern kstat_ctl_t *kc;

4 years agoMerge pull request #2681 from elfiesmelfie/feat_pmu_cores
Ruben Kerkhof [Fri, 18 May 2018 16:43:47 +0000 (18:43 +0200)]
Merge pull request #2681 from elfiesmelfie/feat_pmu_cores

intel_pmu: core groups feature

4 years agointel_pmu plugin: fix for PR comments
Kamil Wiatrowski [Thu, 17 May 2018 14:15:24 +0000 (15:15 +0100)]
intel_pmu plugin: fix for PR comments

Check for failure from snprintf.
Make cgroup and event const in pmu_submit_counter.

Change-Id: I5547375da26c3a63b76588b733e844e3199e9bb8
Signed-off-by: Kamil Wiatrowski <kamilx.wiatrowski@intel.com>
4 years agoMerge pull request #2742 from elfiesmelfie/ipmi_bugfix_sensor_option
Pavel Rochnyak [Wed, 16 May 2018 12:25:13 +0000 (19:25 +0700)]
Merge pull request #2742 from elfiesmelfie/ipmi_bugfix_sensor_option

ipmi plugin: Fix for segmentation fault for wrong data type in Sensor section.

4 years agoipmi plugin: Fix for segmentation fault for wrong data type in Sensor section.
Mariusz Szafranski [Thu, 29 Mar 2018 08:45:46 +0000 (09:45 +0100)]
ipmi plugin: Fix for segmentation fault for wrong data type in Sensor section.

Incorrect, malicious data in the Sensor section can cause a segmentation fault.
Error message is generated instead of crash after applying this patch.

Change-Id: Ibc387b5594f9453f1fc957ed37ceb09cfa34ded5
Signed-off-by: Mariusz Szafranski <mariuszx.szafranski@intel.com>
4 years agoMerge pull request #2776 from mfournier/unblock_pr_2737
Marc Fournier [Tue, 15 May 2018 13:37:45 +0000 (14:37 +0100)]
Merge pull request #2776 from mfournier/unblock_pr_2737

Unblock #2737

4 years agoTrigger Jenkins
Marc Fournier [Tue, 15 May 2018 12:06:02 +0000 (14:06 +0200)]
Trigger Jenkins

4 years agoAuto-Merge pull request #2760 from rpv-tomsk/tmpfix
collectd bot [Tue, 1 May 2018 09:12:01 +0000 (11:12 +0200)]
Auto-Merge pull request #2760 from rpv-tomsk/tmpfix

Automatically merged due to "Automerge" label

4 years agodocs: Fix typo in collectd.conf.pod
Pavel Rochnyack [Tue, 1 May 2018 08:30:43 +0000 (15:30 +0700)]
docs: Fix typo in collectd.conf.pod

4 years agoAuto-Merge pull request #2736 from rpv-tomsk/collectd-collectd-5.8
collectd bot [Thu, 29 Mar 2018 19:17:13 +0000 (21:17 +0200)]
Auto-Merge pull request #2736 from rpv-tomsk/collectd-collectd-5.8

Automatically merged due to "Automerge" label

4 years agouuid plugin: Fixed hostname setting
Pavel Rochnyack [Thu, 29 Mar 2018 18:27:14 +0000 (01:27 +0700)]
uuid plugin: Fixed hostname setting

Closes: #2723
References: #2467

4 years agoMerge pull request #2703 from elfiesmelfie/fix_ipmi_bugfix_0.2
Pavel Rochnyak [Wed, 28 Mar 2018 15:26:21 +0000 (22:26 +0700)]
Merge pull request #2703 from elfiesmelfie/fix_ipmi_bugfix_0.2

Fixes for ipmi plugin

4 years agoAuto-Merge pull request #2734 from rpv-tomsk/fix-2732
collectd bot [Wed, 28 Mar 2018 14:12:50 +0000 (16:12 +0200)]
Auto-Merge pull request #2734 from rpv-tomsk/fix-2732

Automatically merged due to "Automerge" label

4 years agoperl plugin: Fix compile fail with message "void function cannot return value"
Pavel Rochnyack [Wed, 28 Mar 2018 13:23:32 +0000 (20:23 +0700)]
perl plugin: Fix compile fail with message "void function cannot return value"

Closes: #2732

4 years agoRevert "ipmi plugin: Ignore events from ignored sensors"
Mariusz Szafranski [Wed, 7 Mar 2018 09:58:43 +0000 (09:58 +0000)]
Revert "ipmi plugin: Ignore events from ignored sensors"

This reverts commit cd660c5b07b6f09d165435f240ca17d118a1e452.

4 years agoRevert "ipmi plugin: Remove duplicate/unused code and unneeded brackets."
Mariusz Szafranski [Wed, 7 Mar 2018 09:57:50 +0000 (09:57 +0000)]
Revert "ipmi plugin: Remove duplicate/unused code and unneeded brackets."

This reverts commit 8c9d64bf7615875b5030127b4df68a620e084f0d.

4 years agoipmi plugin: Remove duplicate/unused code and unneeded brackets.
Mariusz Szafranski [Mon, 5 Mar 2018 15:04:10 +0000 (15:04 +0000)]
ipmi plugin: Remove duplicate/unused code and unneeded brackets.

Change-Id: Ia4298f75f59e697df25d05091adbb556b64869e1
Signed-off-by: Mariusz Szafranski <mariuszx.szafranski@intel.com>
4 years agoipmi plugin: Threshold event handler registration fix
Mariusz Szafranski [Thu, 1 Mar 2018 12:09:19 +0000 (12:09 +0000)]
ipmi plugin: Threshold event handler registration fix

This patch fixes registration of threshold event handler for
specific sensor types (e.g. 'System Airflow')

Change-Id: I437f3fe68fecf264adb32a4e2ef4ac214a7e87a4
Signed-off-by: Mariusz Szafranski <mariuszx.szafranski@intel.com>
4 years agoipmi plugin: Ignore events from ignored sensors
Mariusz Szafranski [Thu, 1 Mar 2018 12:08:47 +0000 (12:08 +0000)]
ipmi plugin: Ignore events from ignored sensors

Reading is disabled for ignored sensors. This fix it to also
ignore events from s4ensors on ignore list.

Change-Id: I705593c79274a00456a786698452cd3c1bae9872
Signed-off-by: Mariusz Szafranski <mariuszx.szafranski@intel.com>