collectd.git
7 years agoMerge pull request #2212 from maryamtahhan/ovs_events_scan_build
Ruben Kerkhof [Fri, 10 Mar 2017 13:17:58 +0000 (14:17 +0100)]
Merge pull request #2212 from maryamtahhan/ovs_events_scan_build

ovs_events: fixes issue #2205

7 years agoovs_events: fix scan-build warnings #2205
Mytnyk, VolodymyrX [Mon, 6 Mar 2017 16:52:10 +0000 (16:52 +0000)]
ovs_events: fix scan-build warnings #2205

src/utils_ovs.c:366:20: warning: Access to field 'type' results in a dereference of a null pointer (loaded from variable 'jval')
              (int)(jval)->type);
                   ^~~~~~~~~~~~
...

Change-Id: Ic856d21f2121f920bdd2043c69620555bb3d1cb8
Signed-off-by: Mytnyk, VolodymyrX <volodymyrx.mytnyk@intel.com>
7 years agoMerge pull request #2207 from maryamtahhan/fix_for_2201
Ruben Kerkhof [Tue, 7 Mar 2017 11:25:17 +0000 (12:25 +0100)]
Merge pull request #2207 from maryamtahhan/fix_for_2201

ovs_stats: Increase devname buffer

7 years agoIncrease devname buffer buffer to ensure that snprintf output
Taras Chornyi [Mon, 6 Mar 2017 16:52:49 +0000 (16:52 +0000)]
Increase devname buffer buffer to ensure that snprintf output
would not be truncated before the last format character

Signed-off-by: Taras Chornyi <tarasx.chornyi@intel.com>
7 years agocollectd.spec: move new plugins to subpackages
Ruben Kerkhof [Sun, 5 Mar 2017 19:52:26 +0000 (20:52 +0100)]
collectd.spec: move new plugins to subpackages

7 years agocollectd.spec: add ovs_stats plugin
Ruben Kerkhof [Sun, 5 Mar 2017 18:54:40 +0000 (19:54 +0100)]
collectd.spec: add ovs_stats plugin

7 years agovirt plugin: fix build warning
Ruben Kerkhof [Sun, 5 Mar 2017 17:43:15 +0000 (18:43 +0100)]
virt plugin: fix build warning

CC       src/virt_la-virt.lo
src/virt.c:417:37: warning: comparison of integers of different signs: 'int' and 'unsigned long' [-Wsign-compare]
  if ((tag_index < 0) || (tag_index >= STATIC_ARRAY_SIZE(tags))) {
                          ~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.

7 years agoMerge branch 'collectd-5.7'
Ruben Kerkhof [Sun, 5 Mar 2017 17:36:02 +0000 (18:36 +0100)]
Merge branch 'collectd-5.7'

Conflicts:
contrib/redhat/collectd.spec

7 years agoMerge branch 'collectd-5.6' into collectd-5.7
Ruben Kerkhof [Sun, 5 Mar 2017 17:34:37 +0000 (18:34 +0100)]
Merge branch 'collectd-5.6' into collectd-5.7

Conflicts:
contrib/redhat/collectd.spec

7 years agocollectd.spec: Don't enable XFS support on RHEL6
Ruben Kerkhof [Sun, 5 Mar 2017 17:30:23 +0000 (18:30 +0100)]
collectd.spec: Don't enable XFS support on RHEL6

It is missing for i386.
If there's strong interest in having support for xfs in the df plugin in
RHEL6 we can do some macro magic to only BuildRequire xfsprogs-devel if
were not on rhel6 i386, but this was the easiest fix and unblocks our
package builds.

7 years agospec: Don't enable XFS support on RHEL6
Ruben Kerkhof [Sun, 5 Mar 2017 17:25:24 +0000 (18:25 +0100)]
spec: Don't enable XFS support on RHEL6

It is missing for i386.

7 years agoAdd dpkdevents plugin to spec file
Ruben Kerkhof [Sun, 5 Mar 2017 17:18:43 +0000 (18:18 +0100)]
Add dpkdevents plugin to spec file

7 years agoutils_cmd_flush.c: fix another build warning
Ruben Kerkhof [Sun, 5 Mar 2017 17:02:30 +0000 (18:02 +0100)]
utils_cmd_flush.c: fix another build warning

src/utils_cmd_flush.c:140:11: warning: declaration shadows a local variable [-Wshadow]
      int status;
          ^
src/utils_cmd_flush.c:114:7: note: previous declaration is here
  int status;
      ^

7 years agoutils_cmd_flush.c: fix build warning
Ruben Kerkhof [Sun, 5 Mar 2017 16:51:09 +0000 (17:51 +0100)]
utils_cmd_flush.c: fix build warning

CC       src/utils_cmd_flush.lo
src/utils_cmd_flush.c:139:12: warning: declaration shadows a local variable [-Wshadow]
      char buffer[1024];
           ^
src/utils_cmd_flush.c:108:47: note: previous declaration is here
cmd_status_t cmd_handle_flush(FILE *fh, char *buffer) {
                                              ^

7 years agoovs_stats plugin: fix some more build warnings
Ruben Kerkhof [Sun, 5 Mar 2017 16:45:54 +0000 (17:45 +0100)]
ovs_stats plugin: fix some more build warnings

CC       src/ovs_stats_la-ovs_stats.lo
src/ovs_stats.c:158:8: warning: 'const' type qualifier on return type has no effect [-Wignored-qualifiers]
static const iface_counter ovs_stats_counter_name_to_type(const char *counter) {
       ^~~~~~
src/ovs_stats.c:356:29: warning: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long') [-Wsign-compare]
          for (int i = 0; i < ports_num; i++)
                          ~ ^ ~~~~~~~~~
src/ovs_stats.c:401:23: warning: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long') [-Wsign-compare]
    for (int i = 0; i < YAJL_GET_OBJECT(bridges)->len; i++) {
                    ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/ovs_stats.c:415:23: warning: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long') [-Wsign-compare]
    for (int i = 0; i < YAJL_GET_OBJECT(bridges)->len; i++) {
                    ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/ovs_stats.c:501:23: warning: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long') [-Wsign-compare]
    for (int i = 0; i < YAJL_GET_OBJECT(ports)->len; i++) {
                    ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/ovs_stats.c:524:23: warning: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long') [-Wsign-compare]
    for (int i = 0; i < YAJL_GET_OBJECT(ports)->len; i++) {
                    ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/ovs_stats.c:538:23: warning: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long') [-Wsign-compare]
    for (int i = 0; i < YAJL_GET_ARRAY(stats)->len; i++) {
                    ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~
src/ovs_stats.c:558:23: warning: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long') [-Wsign-compare]
    for (int i = 0; i < YAJL_GET_ARRAY(ext_ids)->len; i++) {
                    ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/ovs_stats.c:684:23: warning: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long') [-Wsign-compare]
    for (int i = 0; i < YAJL_GET_OBJECT(ports)->len; i++)
                    ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
9 warnings generated.

7 years agoovs_stats plugin: fix build warning
Ruben Kerkhof [Sun, 5 Mar 2017 16:42:28 +0000 (17:42 +0100)]
ovs_stats plugin: fix build warning

src/ovs_stats.c:158:8: warning: 'const' type qualifier on return type has no effect [-Wignored-qualifiers]
static const iface_counter ovs_stats_counter_name_to_type(const char *counter) {
       ^~~~~~

7 years agoMerge branch 'collectd-5.7'
Ruben Kerkhof [Sun, 5 Mar 2017 16:21:11 +0000 (17:21 +0100)]
Merge branch 'collectd-5.7'

Conflicts:
configure.ac

7 years agoMerge branch 'collectd-5.6' into collectd-5.7
Ruben Kerkhof [Sun, 5 Mar 2017 16:14:53 +0000 (17:14 +0100)]
Merge branch 'collectd-5.6' into collectd-5.7

7 years agoMerge pull request #2204 from collectd/check-for-cap-is-supported
Ruben Kerkhof [Sun, 5 Mar 2017 16:14:18 +0000 (17:14 +0100)]
Merge pull request #2204 from collectd/check-for-cap-is-supported

Check for the CAP_IS_SUPPORTED macro

7 years agoCheck for the CAP_IS_SUPPORTED macro
Ruben Kerkhof [Sun, 5 Mar 2017 15:46:47 +0000 (16:46 +0100)]
Check for the CAP_IS_SUPPORTED macro

On EPEL6:
src/daemon/common.c: In function 'check_capability':
src/daemon/common.c:1571: error: implicit declaration of function 'CAP_IS_SUPPORTED'
make[1]: *** [src/daemon/common.lo] Error 1

7 years agoMerge pull request #2137 from maryamtahhan/feat_ovs_stats
Ruben Kerkhof [Tue, 28 Feb 2017 18:18:05 +0000 (19:18 +0100)]
Merge pull request #2137 from maryamtahhan/feat_ovs_stats

ovs_stats: Implement OVS statistics plugin.

7 years agoMerge branch 'collectd-5.7'
Ruben Kerkhof [Fri, 24 Feb 2017 16:55:12 +0000 (17:55 +0100)]
Merge branch 'collectd-5.7'

Conflicts:
configure.ac

7 years agoMerge branch 'collectd-5.6' into collectd-5.7
Ruben Kerkhof [Fri, 24 Feb 2017 16:44:55 +0000 (17:44 +0100)]
Merge branch 'collectd-5.6' into collectd-5.7

7 years agolook for cap_get_proc instead of cap_get_bound
Ruben Kerkhof [Fri, 24 Feb 2017 16:42:59 +0000 (17:42 +0100)]
look for cap_get_proc instead of cap_get_bound

a2ddc38 switched the capability check from cap_get_bound() to
cap_get_proc()

7 years agoMerge pull request #2151 from mfournier/check_capability-rewrite-fix
Ruben Kerkhof [Fri, 24 Feb 2017 16:40:41 +0000 (17:40 +0100)]
Merge pull request #2151 from mfournier/check_capability-rewrite-fix

daemon/common.c: Fix check_capability() by using cap_get_proc()

7 years agoMerge branch 'collectd-5.7'
Ruben Kerkhof [Fri, 24 Feb 2017 16:28:56 +0000 (17:28 +0100)]
Merge branch 'collectd-5.7'

7 years agoMerge branch 'collectd-5.6' into collectd-5.7
Ruben Kerkhof [Fri, 24 Feb 2017 16:28:28 +0000 (17:28 +0100)]
Merge branch 'collectd-5.6' into collectd-5.7

Conflicts:
src/utils_match.c

7 years agosmart: log warning if CAP_SYS_RAWIO is missing
Marc Fournier [Wed, 25 Jan 2017 07:10:48 +0000 (08:10 +0100)]
smart: log warning if CAP_SYS_RAWIO is missing

Related to #2143

7 years agoMerge pull request #2157 from maryamtahhan/dpdkevents_upstream
Ruben Kerkhof [Fri, 24 Feb 2017 16:19:21 +0000 (17:19 +0100)]
Merge pull request #2157 from maryamtahhan/dpdkevents_upstream

Plugin for getting DPDK ports link status and keep alive events.

7 years agoMerge pull request #2192 from maryamtahhan/bugfix_regex_memleak
Ruben Kerkhof [Fri, 24 Feb 2017 15:52:17 +0000 (16:52 +0100)]
Merge pull request #2192 from maryamtahhan/bugfix_regex_memleak

fix for memory leak in utils_match.c

7 years agoMerge pull request #2194 from maryamtahhan/feat_dpdkstat_fix
Ruben Kerkhof [Fri, 24 Feb 2017 15:51:52 +0000 (16:51 +0100)]
Merge pull request #2194 from maryamtahhan/feat_dpdkstat_fix

dpdkstat: fix retrieval of statistics

7 years agodpdkstat: fix retrieval of statistics
Przemyslaw Szczerbik [Tue, 14 Feb 2017 13:02:43 +0000 (13:02 +0000)]
dpdkstat: fix retrieval of statistics

This change forces dpdkstat plugin to check if memory needs to be resized on
every DPDK_CMD_GET_STATS command, rather than resizing it only once at
initialization. Additionally it fixes incorrect metric retrieval logic, which
allows plugin to dispatch metrics only if number of retrieved extended statistics
is equal to allocated stats array size for port. Based on DPDK API documentation
rte_eth_xstats_get (and rte_eth_xstats_get_names) function can return positive
value lower than array size, which isn't considered a failure.

If primary DPDK process is restarted with a greater number of ports bound to
DPDK driver while collectd dpdkstat plugin is running, then memory isn't resized.
Due to insufficient memory allocation dpdkstat plugin is unable to gather metrics
from new ports.

Change-Id: I25c8995105a322474653bf7065c2228047f886b1
Signed-off-by: Przemyslaw Szczerbik <przemyslawx.szczerbik@intel.com>
7 years agofix for memory leak in utils_match.c
Krzysztof Matczak [Fri, 24 Feb 2017 09:38:14 +0000 (09:38 +0000)]
fix for memory leak in utils_match.c

Change-Id: I058afae8c0a99115bda70e125840fc6bd224b358
Signed-off-by: Krzysztof Matczak <krzysztofx.matczak@intel.com>
7 years agodpdkevents: PR comments addressed
Krzysztof Matczak [Fri, 24 Feb 2017 09:15:07 +0000 (09:15 +0000)]
dpdkevents: PR comments addressed

RTE version check changed to compile time. Adressing PR
review comments. Minor format changes

Change-Id: Ie345a6009a291490323f614183362dfce8e6a5e6

7 years agoMerge pull request #2169 from ipavlikevich/master
Ruben Kerkhof [Thu, 23 Feb 2017 19:48:14 +0000 (20:48 +0100)]
Merge pull request #2169 from ipavlikevich/master

virt plugin: fix skipping inactive domains

7 years agoMerge branch 'collectd-5.7'
Ruben Kerkhof [Wed, 22 Feb 2017 20:16:38 +0000 (21:16 +0100)]
Merge branch 'collectd-5.7'

7 years agoMerge branch 'collectd-5.6' into collectd-5.7
Ruben Kerkhof [Wed, 22 Feb 2017 20:09:46 +0000 (21:09 +0100)]
Merge branch 'collectd-5.6' into collectd-5.7

7 years agolog_logstash: send log messages to STDERR by default
Marc Fournier [Wed, 11 Jan 2017 12:39:27 +0000 (13:39 +0100)]
log_logstash: send log messages to STDERR by default

See also dec394e08

7 years agosrc/daemon/collectd.c: do not refer to syslog in error message
Marc Fournier [Tue, 10 Jan 2017 21:58:21 +0000 (22:58 +0100)]
src/daemon/collectd.c: do not refer to syslog in error message

... as the message the user would be looking for can be found on
stderr/stdout or in any configured logfile.

7 years agologfile: send log messages to STDERR by default
Marc Fournier [Tue, 10 Jan 2017 21:23:55 +0000 (22:23 +0100)]
logfile: send log messages to STDERR by default

This prevents early startup log messages from going unnoticed if the
default logfile isn't writeable.

Fixes: #2057

7 years agovirt plugin: fix skipping inactive domains
Igor Pavlikevich [Thu, 9 Feb 2017 13:07:13 +0000 (16:07 +0300)]
virt plugin: fix skipping inactive domains

Remove inactive domains from domains list, not only in CPU/Memory/VCPU usage accounting

Signed-off-by: Igor Pavlikevich <ipavlikevich@gmail.com>
7 years agoMerge pull request #2181 from maryamtahhan/feat_ovs_events_dispatch_option
Ruben Kerkhof [Wed, 22 Feb 2017 13:08:27 +0000 (14:08 +0100)]
Merge pull request #2181 from maryamtahhan/feat_ovs_events_dispatch_option

ovs_events: Make dispatch link status configurable

7 years agoovs_events: Make dispatch link status configurable
Mytnyk, VolodymyrX [Tue, 14 Feb 2017 12:15:28 +0000 (12:15 +0000)]
ovs_events: Make dispatch link status configurable

Change-Id: Ib1853ff8caf57c6e33171e9d419af84c2ce69cae
Signed-off-by: Mytnyk, VolodymyrX <volodymyrx.mytnyk@intel.com>
ovs_events: Revert changing SendNotification default

Change-Id: I5e318e132937301aac355dcedaf3474a623f3853
Signed-off-by: Mytnyk, VolodymyrX <volodymyrx.mytnyk@intel.com>
7 years agoMerge branch 'collectd-5.7'
Ruben Kerkhof [Wed, 22 Feb 2017 10:19:57 +0000 (11:19 +0100)]
Merge branch 'collectd-5.7'

Conflicts:
contrib/redhat/collectd.spec

7 years agoMerge branch 'collectd-5.6' into collectd-5.7
Ruben Kerkhof [Wed, 22 Feb 2017 10:17:58 +0000 (11:17 +0100)]
Merge branch 'collectd-5.6' into collectd-5.7

Conflicts:
contrib/redhat/collectd.spec

7 years agocollectd.spec: enable XFS support in df plugin
Ruben Kerkhof [Wed, 22 Feb 2017 08:59:02 +0000 (09:59 +0100)]
collectd.spec: enable XFS support in df plugin

Fixes #2178

7 years agoRemoved unused function
Taras Chornyi [Tue, 21 Feb 2017 17:54:21 +0000 (19:54 +0200)]
Removed unused function

Signed-off-by: Taras Chornyi <tarasx.chornyi@intel.com>
7 years agoAddressed PR comments
Taras Chornyi [Tue, 21 Feb 2017 16:39:28 +0000 (16:39 +0000)]
Addressed PR comments

Fixed issue with missing counter

Signed-off-by: Taras Chornyi <tarasx.chornyi@intel.com>
7 years agoMerge pull request #2158 from pmauduit/java_atomic_types
Ruben Kerkhof [Sun, 19 Feb 2017 16:13:42 +0000 (17:13 +0100)]
Merge pull request #2158 from pmauduit/java_atomic_types

Java bindings - Adding Atomic* support

7 years agowrite_riemann_threshold: remove unused header
Ruben Kerkhof [Sun, 19 Feb 2017 13:07:11 +0000 (14:07 +0100)]
write_riemann_threshold: remove unused header

This fixes the build on EPEL7, which doesn't have ltdl-devel installed
(and it shouldn't have to since commit 98153711).

7 years agoMerge branch 'collectd-5.7'
Ruben Kerkhof [Sun, 19 Feb 2017 12:07:39 +0000 (13:07 +0100)]
Merge branch 'collectd-5.7'

Conflicts:
contrib/redhat/collectd.spec
src/Makefile.am
src/dpdkstat.c

7 years agoMerge branch 'collectd-5.6' into collectd-5.7
Ruben Kerkhof [Sun, 19 Feb 2017 11:59:13 +0000 (12:59 +0100)]
Merge branch 'collectd-5.6' into collectd-5.7

7 years agoMerge pull request #2145 from Geraden07/master
Ruben Kerkhof [Sun, 19 Feb 2017 11:55:15 +0000 (12:55 +0100)]
Merge pull request #2145 from Geraden07/master

SSL Certificate Verification For collectd-nut Plugin

7 years agoImplemented certificate checking conditionally if compiler finds upsclient library...
Steven Bell [Sun, 19 Feb 2017 05:56:27 +0000 (00:56 -0500)]
Implemented certificate checking conditionally if compiler finds upsclient library version >= 2.7. Otherwise will show warnings if this feature is used.

7 years agoAdded ForceSSL feature. Updated documentation and added my contributor information.
Steven Bell [Sun, 19 Feb 2017 05:45:21 +0000 (00:45 -0500)]
Added ForceSSL feature. Updated documentation and added my contributor information.

7 years agoMerge pull request #2175 from mojaves-redhat/pr-add-cputime
Ruben Kerkhof [Wed, 15 Feb 2017 17:22:13 +0000 (18:22 +0100)]
Merge pull request #2175 from mojaves-redhat/pr-add-cputime

virt plugin: Add physical cpu reporting

7 years agovirt plugin: don't shadow global variable
Francesco Romani [Wed, 15 Feb 2017 14:27:34 +0000 (15:27 +0100)]
virt plugin: don't shadow global variable

and use a matching type for local one.

7 years agovirt plugin: fix prototype
Francesco Romani [Wed, 15 Feb 2017 13:21:20 +0000 (14:21 +0100)]
virt plugin: fix prototype

Previously it failed to compile, even though somehow gcc 6.3.1 liked it.

7 years agoMerge pull request #2176 from maryamtahhan/feat_dpdkstat_shm_bugfix
Ruben Kerkhof [Wed, 15 Feb 2017 09:26:33 +0000 (10:26 +0100)]
Merge pull request #2176 from maryamtahhan/feat_dpdkstat_shm_bugfix

dpdkstat: fix fixed shared mem object name

7 years agodpdkstat: fix fixed shared mem object name
Maryam Tahhan [Tue, 14 Feb 2017 18:34:15 +0000 (18:34 +0000)]
dpdkstat: fix fixed shared mem object name

Fix the shared memory object name so that it's configurable. This way multiple
DPDK applications running in containers can be monitored at the same time
(assuming collectd is also running in that container).

Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
7 years agovirt plugin: Add physical cpu reporting
Francesco Romani [Mon, 9 Jan 2017 11:31:17 +0000 (12:31 +0100)]
virt plugin: Add physical cpu reporting

Add a metric to report physical cpu consumed by the hypervisor,
split per user/system time. This is provided by libvirt since version
0.9.11, and used by oVirt.

We also extend the newly-added 'ExtraStats' option to allow
users to toggle on/off the new metric. Default is off.

Signed-off-by: Francesco Romani <fromani@redhat.com>
7 years agoMerge pull request #2156 from maryamtahhan/feat_dpdkstat_bugfix
Ruben Kerkhof [Tue, 14 Feb 2017 10:18:02 +0000 (11:18 +0100)]
Merge pull request #2156 from maryamtahhan/feat_dpdkstat_bugfix

dpdkstat: Fix metrics' types

7 years agoMerge pull request #2167 from maryamtahhan/feat_dpdkstat_bugfix_5_7
Ruben Kerkhof [Tue, 14 Feb 2017 10:12:28 +0000 (11:12 +0100)]
Merge pull request #2167 from maryamtahhan/feat_dpdkstat_bugfix_5_7

dpdkstat: Fix metrics' types

7 years agoMerge pull request #2103 from mojaves-redhat/pr-block-stats-flags
Ruben Kerkhof [Tue, 14 Feb 2017 10:11:29 +0000 (11:11 +0100)]
Merge pull request #2103 from mojaves-redhat/pr-block-stats-flags

virt plugin: support virDomainBlockStatsFlags

7 years agovirt plugin: Address PR comments
Francesco Romani [Tue, 14 Feb 2017 09:34:52 +0000 (10:34 +0100)]
virt plugin: Address PR comments

Signed-off-by: Francesco Romani <fromani@redhat.com>
7 years agoMerge pull request #2170 from javicacheiro/fix_redhat_spec_file
Marc Fournier [Mon, 13 Feb 2017 14:39:00 +0000 (15:39 +0100)]
Merge pull request #2170 from javicacheiro/fix_redhat_spec_file

Fix rpm spec file for 5.7.1

7 years agovirt plugin: Add option to disable extra stats
Francesco Romani [Mon, 13 Feb 2017 08:08:02 +0000 (09:08 +0100)]
virt plugin: Add option to disable extra stats

We are adding more metrics to the virt plugin, but not everyone
may be interested in those.
This patch add one more option to the virt plugin to enable
or disable the new stats.
For backward compatibility, the default is disabled.

Signed-off-by: Francesco Romani <fromani@redhat.com>
7 years agovirt plugin: Report disk flush information
Francesco Romani [Mon, 9 Jan 2017 10:28:10 +0000 (11:28 +0100)]
virt plugin: Report disk flush information

Now that we switched to virDomainBLockStatsFlags, we can
report the `flush` stats.

Signed-off-by: Francesco Romani <fromani@redhat.com>
7 years agovirt plugin: Add disk_time reporting
Francesco Romani [Fri, 9 Dec 2016 15:54:32 +0000 (16:54 +0100)]
virt plugin: Add disk_time reporting

Signed-off-by: Francesco Romani <fromani@redhat.com>
7 years agovirt plugin: support virDomainBlockStatsFlags
Francesco Romani [Tue, 6 Dec 2016 12:15:11 +0000 (13:15 +0100)]
virt plugin: support virDomainBlockStatsFlags

We want to export more disk stats, like disk_time.
To do so, we must use the virDomainBlockStatsFlags API, but it
could not be available on all the platforms collectd supports.
To cope with that, we add a minimal layer around the API, and
we use virDomainBlockStatsFlags only if available.

This patch adds the code to use the new API and the fallback code
in the case the platform' libvirt is too old.

Signed-off-by: Francesco Romani <fromani@redhat.com>
7 years agoFix release
Javier Cacheiro [Fri, 10 Feb 2017 10:58:07 +0000 (11:58 +0100)]
Fix release

7 years agoFix rpm spec file for 5.7.1
Javier Cacheiro [Thu, 9 Feb 2017 21:50:01 +0000 (22:50 +0100)]
Fix rpm spec file for 5.7.1

7 years agoMerge pull request #2165 from maryamtahhan/feat_rdt_bugfix
Ruben Kerkhof [Wed, 8 Feb 2017 16:36:46 +0000 (17:36 +0100)]
Merge pull request #2165 from maryamtahhan/feat_rdt_bugfix

intel_rdt: bugfix configuration

7 years agodpdkstat: Fix metrics' types
Przemyslaw Szczerbik [Wed, 8 Feb 2017 14:28:09 +0000 (14:28 +0000)]
dpdkstat: Fix metrics' types

This patch fixes parsing of metrics' types. Some statistics, such as
rx_q0errors, rx_q0bytes or rx_q0packet, don't contain suffix _errors, _bytes or
_packets. This has caused them to use generic type 'derive', rather than
more specific one, for instance 'if_rx_errors'. Additionally, some
statistics contain string 'error', rather than 'errors'.

Change-Id: I51dfa9c4d98346a654adbc4041b64ebd3897278c
Signed-off-by: Przemyslaw Szczerbik <przemyslawx.szczerbik@intel.com>
7 years agointel_rdt: bugfix configuration
Maryam Tahhan [Wed, 8 Feb 2017 13:48:12 +0000 (13:48 +0000)]
intel_rdt: bugfix configuration

Fix the configuration to stop collectd bombing out and deal with configuration
errors gracefully. Otherwise collectd will fail at the configuration phase
with: "Error: Reading the config file failed!".

Signed-off-by: Tahhan, Maryam <maryam.tahhan@intel.com>
7 years agoMerge pull request #2162 from maryamtahhan/feat_intel_rdt
Ruben Kerkhof [Tue, 7 Feb 2017 11:40:42 +0000 (12:40 +0100)]
Merge pull request #2162 from maryamtahhan/feat_intel_rdt

collectd.service: add intel_rdt plugin capability requirement

7 years agonotify_email: don't explicitly link against libssl and libcrypto
Marc Fournier [Sat, 28 Jan 2017 10:47:38 +0000 (11:47 +0100)]
notify_email: don't explicitly link against libssl and libcrypto

libesmtp takes care of this.

Pointed out by https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=852924

7 years agocollectd.service: add intel_rdt plugin capability requirement
Przemyslaw Szczerbik [Fri, 3 Feb 2017 13:22:18 +0000 (13:22 +0000)]
collectd.service: add intel_rdt plugin capability requirement

Change-Id: I08849f5947b052d8ffae263396f4e7deba8966f3
Signed-off-by: Przemyslaw Szczerbik <przemyslawx.szczerbik@intel.com>
7 years agoJava bindings - Adding Atomic* support
Pierre Mauduit [Mon, 30 Jan 2017 16:56:35 +0000 (17:56 +0100)]
Java bindings - Adding Atomic* support

AtomicIntegers are used to address some concurrency problems in Java, and this
is advised by some metrics libraries like Netflix's servo:

https://github.com/Netflix/servo/wiki#jmx

Unfortunately, the GenericJMXConfValue.java class is not able to get the values
from such types, hence this PR.

I scanned the Java doc for the Java package:
https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/atomic/package-summary.html
I think I have not forgotten any types.

Tests: tested at runtime

7 years agoPlugin for getting DPDK ports link status and keep alive events.
Krzysztof Matczak [Wed, 25 Jan 2017 14:01:39 +0000 (14:01 +0000)]
Plugin for getting DPDK ports link status and keep alive events.

Dpdkevents plugin collects and reports following events from DPDK based
applications:
- link status of network ports bound with DPDK
- keep alive events related to DPDK logical cores

In order to get link status plugin forks child process that attaches itself to
DPDK application as secondary DPDK process and fetches link status data using
DPDK API. This is the same approach like for dpdkstat plugin, also the same
utils_dpdk.c helper is utilized.

For getting keep alive events plugin communicates with DPDK application
via shared memory area. This is possible only if keep alive feature
is implemented in monitored application.
More details can be found under link
http://dpdk.org/doc/guides/sample_app_ug/keep_alive.html

Minimal required version of DPDK is 16.07.

Change-Id: Id820407ea933b1ecc31a72b6e344a6ec186ec780
Signed-off-by: Krzysztof Matczak <krzysztofx.matczak@intel.com>
7 years agodaemon/common.c: Fix check_capability() by using cap_get_proc()
Marc Fournier [Wed, 25 Jan 2017 06:37:41 +0000 (07:37 +0100)]
daemon/common.c: Fix check_capability() by using cap_get_proc()

Rewrite this function, as 58acba67f made it a no-op.

7 years agodpdkstat: Fix metrics' types
Przemyslaw Szczerbik [Tue, 24 Jan 2017 14:23:10 +0000 (14:23 +0000)]
dpdkstat: Fix metrics' types

This patch fixes parsing of metrics' types. Some statistics, such as
rx_q0errors, rx_q0bytes or rx_q0packet, don't contain suffix _errors, _bytes or
_packets. This has caused them to use generic type 'derive', rather than
more specific one, for instance 'if_rx_errors'. Additionally, some
statistics contain string 'error', rather than 'errors'.

Change-Id: Ifd4ed6c0d2c21723900f36fb1a376d4673e59850
Signed-off-by: Przemyslaw Szczerbik <przemyslawx.szczerbik@intel.com>
7 years agoMerge branch 'collectd-5.6' into collectd-5.7
Marc Fournier [Mon, 23 Jan 2017 19:05:30 +0000 (20:05 +0100)]
Merge branch 'collectd-5.6' into collectd-5.7

7 years agodpdkstat plugin: jump to the right label
Ruben Kerkhof [Fri, 23 Dec 2016 17:47:59 +0000 (18:47 +0100)]
dpdkstat plugin: jump to the right label

7 years agoBump version to 5.7.1; Update ChangeLog. collectd-5.7.1
Florian Forster [Mon, 23 Jan 2017 07:42:35 +0000 (08:42 +0100)]
Bump version to 5.7.1; Update ChangeLog.

7 years agoMerge pull request #2140 from maryamtahhan/feat_ras_bugfix
Ruben Kerkhof [Thu, 19 Jan 2017 16:55:11 +0000 (17:55 +0100)]
Merge pull request #2140 from maryamtahhan/feat_ras_bugfix

mcelog: Bug fixes and code style changes

7 years agomcelog: Address PR comments.
Przemyslaw Szczerbik [Thu, 19 Jan 2017 14:41:27 +0000 (14:41 +0000)]
mcelog: Address PR comments.

Change-Id: Ifde0311b54535b8cd5b3e0ccb05ce908dc499f62
Signed-off-by: Przemyslaw Szczerbik <przemyslawx.szczerbik@intel.com>
7 years agomcelog: Minor changes
Przemyslaw Szczerbik [Thu, 19 Jan 2017 13:01:51 +0000 (13:01 +0000)]
mcelog: Minor changes

Change-Id: I99f8ed0b30c9f8bc6d7b22deb291e30ca0301507
Signed-off-by: Przemyslaw Szczerbik <przemyslawx.szczerbik@intel.com>
7 years agomcelog: Free notification metadata
Przemyslaw Szczerbik [Thu, 19 Jan 2017 12:31:52 +0000 (12:31 +0000)]
mcelog: Free notification metadata

Change-Id: I68f883415a1c5d75cecb748b6c5788b536903333
Signed-off-by: Przemyslaw Szczerbik <przemyslawx.szczerbik@intel.com>
7 years agomcelog: Dispatch notification on successful connection to mcelog server
Przemyslaw Szczerbik [Thu, 19 Jan 2017 11:30:54 +0000 (11:30 +0000)]
mcelog: Dispatch notification on successful connection to mcelog server

Change-Id: Ia5503972c665a2e951a2c5f14847be4c7580a9f3
Signed-off-by: Przemyslaw Szczerbik <przemyslawx.szczerbik@intel.com>
7 years agomcelog: Check if location was correctly parsed
Przemyslaw Szczerbik [Thu, 19 Jan 2017 10:59:29 +0000 (10:59 +0000)]
mcelog: Check if location was correctly parsed

Avoid dispatching metrics if location (used as plugin instance) wasn't parsed
correctly. Such thing can occur when there are no machine check exceptions
reported by mcelog server. With csv plugin enabled, it was causing a creation of
unexpected mcelog directory with all files (metrics) filled out with 0's.

Change-Id: Ib01f355a986ee5c6191cd126e1b32ef956ffce1f
Signed-off-by: Przemyslaw Szczerbik <przemyslawx.szczerbik@intel.com>
7 years agomcelog: Increase delay between socket reinitialization
Przemyslaw Szczerbik [Tue, 3 Jan 2017 13:46:04 +0000 (13:46 +0000)]
mcelog: Increase delay between socket reinitialization

Change delay between subsequent socket reinitialization attempts from 1000 usec
to 1000 ms. Such frequent attempts were affecting collectd functionality and
flooded the syslog. Issue can be eaisly reproduced by stopping mcelog service
while collectd with mcelog plugin enabled is running.

Signed-off-by: Przemyslaw Szczerbik <przemyslawx.szczerbik@intel.com>
7 years agomqtt plugin: Fix invalid symbols in topic name.
Denys Fedoryshchenko [Fri, 6 Jan 2017 01:36:16 +0000 (03:36 +0200)]
mqtt plugin: Fix invalid symbols in topic name.

7 years agomqtt plugin: Fix resource leak.
Denys Fedoryshchenko [Fri, 6 Jan 2017 01:36:16 +0000 (03:36 +0200)]
mqtt plugin: Fix resource leak.

Fixes: #2123

7 years agoMerge pull request #2141 from piotr1212/link_unixsock_with_cmds
Ruben Kerkhof [Sat, 14 Jan 2017 16:14:42 +0000 (17:14 +0100)]
Merge pull request #2141 from piotr1212/link_unixsock_with_cmds

unixsock.so: undefined symbol: handle_getthreshold -> link unixsock against libcmds

7 years agolink unixsock against libcmds
Piotr Popieluch [Sat, 14 Jan 2017 00:22:46 +0000 (01:22 +0100)]
link unixsock against libcmds

unixsock_la_LIBS is not being processed by automake and thus being
incorrectly linked. This results in an symbol error when loading
the module. Changing to unixsock_la_LIBADD fixes this.

7 years agoMerge pull request #2122 from octo/issue/2108
Marc Fournier [Tue, 10 Jan 2017 22:40:43 +0000 (23:40 +0100)]
Merge pull request #2122 from octo/issue/2108

src/daemon/plugin.c: Register plugin_update_internal_statistics() as …

7 years agoMerge branch 'collectd-5.7'
Marc Fournier [Tue, 10 Jan 2017 22:03:15 +0000 (23:03 +0100)]
Merge branch 'collectd-5.7'

7 years agoMerge branch 'collectd-5.6' into collectd-5.7
Marc Fournier [Tue, 10 Jan 2017 22:01:43 +0000 (23:01 +0100)]
Merge branch 'collectd-5.6' into collectd-5.7

7 years agochrony: add missing build flag
Marc Fournier [Tue, 10 Jan 2017 20:39:22 +0000 (21:39 +0100)]
chrony: add missing build flag

This is a backport of 211bd4843.