From 5f676ef72a300ae4e8e979b4011cf7e3be505a6a Mon Sep 17 00:00:00 2001 From: Florian Forster Date: Fri, 1 Dec 2017 12:05:21 +0100 Subject: [PATCH] powerdns plugin: Ensure powerdns_get_data() returns a non-NULL buffer. Coverity is concerned that if buffer is NULL, strtok_r() is called with two NULL arguments, causing a NULL pointer dereference. CID: 37968 --- src/powerdns.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/powerdns.c b/src/powerdns.c index f2149ef2..fa3eef33 100644 --- a/src/powerdns.c +++ b/src/powerdns.c @@ -598,6 +598,9 @@ static int powerdns_read_server(list_item_t *item) /* {{{ */ status = powerdns_get_data(item, &buffer, &buffer_size); if (status != 0) return (-1); + if ((buffer == NULL) || (buffer_size == 0)) { + return EINVAL; + } if (item->fields_num != 0) { fields = (const char *const *)item->fields; -- 2.11.0