From c555ce62ac248983ddc607b4c9ebc7f48e6aa08e Mon Sep 17 00:00:00 2001 From: Pavel Rochnyack Date: Wed, 27 Jun 2018 18:55:47 +0700 Subject: [PATCH] cleanup: Remove excessive error reporting These messages already reported in parse_value() --- src/bind.c | 2 -- src/curl_json.c | 1 - src/powerdns.c | 3 --- src/protocols.c | 1 - 4 files changed, 7 deletions(-) diff --git a/src/bind.c b/src/bind.c index b0126392..fe3480d0 100644 --- a/src/bind.c +++ b/src/bind.c @@ -343,8 +343,6 @@ static int bind_xml_read_derive(xmlDoc *doc, xmlNode *node, /* {{{ */ int status = parse_value(str_ptr, &value, DS_TYPE_DERIVE); if (status != 0) { - ERROR("bind plugin: Parsing string \"%s\" to derive value failed.", - str_ptr); xmlFree(str_ptr); return -1; } diff --git a/src/curl_json.c b/src/curl_json.c index f0badc99..5d96cbd5 100644 --- a/src/curl_json.c +++ b/src/curl_json.c @@ -256,7 +256,6 @@ static int cj_cb_number(void *ctx, const char *number, yajl_len_t number_len) { value_t vt; int status = parse_value(buffer, &vt, type); if (status != 0) { - NOTICE("curl_json plugin: Unable to parse number: \"%s\"", buffer); cj_advance_array(ctx); return CJ_CB_CONTINUE; } diff --git a/src/powerdns.c b/src/powerdns.c index eb3ec537..7a2fbfd6 100644 --- a/src/powerdns.c +++ b/src/powerdns.c @@ -359,9 +359,6 @@ static void submit(const char *plugin_instance, /* {{{ */ } if (0 != parse_value(value_str, &value, ds->ds[0].type)) { - ERROR("powerdns plugin: Cannot convert `%s' " - "to a number.", - value_str); return; } diff --git a/src/protocols.c b/src/protocols.c index 59eb49a7..36b1d83b 100644 --- a/src/protocols.c +++ b/src/protocols.c @@ -58,7 +58,6 @@ static void submit(const char *protocol_name, const char *str_key, status = parse_value(str_value, &value, DS_TYPE_DERIVE); if (status != 0) { - ERROR("protocols plugin: Parsing string as integer failed: %s", str_value); return; } -- 2.11.0