Remove "tree->entries" tree-entry list from tree parser

[git.git] / tree.c

diff --git a/tree.c b/tree.c
index 88c2219..db6e59f 100644 (file)
--- a/tree.c
+++ b/tree.c
@@ -78,19 +78,26 @@ int read_tree_recursive(struct tree *tree,
                        int stage, const char **match,
                        read_tree_fn_t fn)
 {
-       struct tree_entry_list *list;
+       struct tree_desc desc;
+
        if (parse_tree(tree))
                return -1;
-       list = tree->entries;
-       while (list) {
-               struct tree_entry_list *current = list;
-               list = list->next;
-               if (!match_tree_entry(base, baselen, current->name,
-                                     current->mode, match))
+
+       desc.buf = tree->buffer;
+       desc.size = tree->size;
+
+       while (desc.size) {
+               unsigned mode;
+               const char *name;
+               const unsigned char *sha1;
+
+               sha1 = tree_entry_extract(&desc, &name, &mode);
+               update_tree_entry(&desc);
+
+               if (!match_tree_entry(base, baselen, name, mode, match))
                        continue;
 
-               switch (fn(current->sha1, base, baselen,
-                          current->name, current->mode, stage)) {
+               switch (fn(sha1, base, baselen, name, mode, stage)) {
                case 0:
                        continue;
                case READ_TREE_RECURSIVE:
@@ -98,16 +105,16 @@ int read_tree_recursive(struct tree *tree,
                default:
                        return -1;
                }
-               if (current->directory) {
+               if (S_ISDIR(mode)) {
                        int retval;
-                       int pathlen = strlen(current->name);
+                       int pathlen = strlen(name);
                        char *newbase;
 
                        newbase = xmalloc(baselen + 1 + pathlen);
                        memcpy(newbase, base, baselen);
-                       memcpy(newbase + baselen, current->name, pathlen);
+                       memcpy(newbase + baselen, name, pathlen);
                        newbase[baselen + pathlen] = '/';
-                       retval = read_tree_recursive(lookup_tree(current->sha1),
+                       retval = read_tree_recursive(lookup_tree(sha1),
                                                     newbase,
                                                     baselen + pathlen + 1,
                                                     stage, match, fn);
@@ -144,22 +151,65 @@ struct tree *lookup_tree(const unsigned char *sha1)
        return (struct tree *) obj;
 }
 
-int parse_tree_buffer(struct tree *item, void *buffer, unsigned long size)
+static int track_tree_refs(struct tree *item)
 {
+       int n_refs = 0, i;
+       struct object_refs *refs;
        struct tree_desc desc;
-       struct tree_entry_list **list_p;
-       int n_refs = 0;
 
+       /* Count how many entries there are.. */
+       desc.buf = item->buffer;
+       desc.size = item->size;
+       while (desc.size) {
+               n_refs++;
+               update_tree_entry(&desc);
+       }
+
+       /* Allocate object refs and walk it again.. */
+       i = 0;
+       refs = alloc_object_refs(n_refs);
+       desc.buf = item->buffer;
+       desc.size = item->size;
+       while (desc.size) {
+               unsigned mode;
+               const char *name;
+               const unsigned char *sha1;
+               struct object *obj;
+
+               sha1 = tree_entry_extract(&desc, &name, &mode);
+               update_tree_entry(&desc);
+               if (S_ISDIR(mode))
+                       obj = &lookup_tree(sha1)->object;
+               else
+                       obj = &lookup_blob(sha1)->object;
+               refs->ref[i++] = obj;
+       }
+       set_object_refs(&item->object, refs);
+       return 0;
+}
+
+int parse_tree_buffer(struct tree *item, void *buffer, unsigned long size)
+{
        if (item->object.parsed)
                return 0;
        item->object.parsed = 1;
        item->buffer = buffer;
        item->size = size;
 
-       desc.buf = buffer;
-       desc.size = size;
+       if (track_object_refs)
+               track_tree_refs(item);
+       return 0;
+}
+
+struct tree_entry_list *create_tree_entry_list(struct tree *tree)
+{
+       struct tree_desc desc;
+       struct tree_entry_list *ret = NULL;
+       struct tree_entry_list **list_p = &ret;
+
+       desc.buf = tree->buffer;
+       desc.size = tree->size;
 
-       list_p = &item->entries;
        while (desc.size) {
                unsigned mode;
                const char *path;
@@ -179,29 +229,19 @@ int parse_tree_buffer(struct tree *item, void *buffer, unsigned long size)
                entry->next = NULL;
 
                update_tree_entry(&desc);
-               n_refs++;
                *list_p = entry;
                list_p = &entry->next;
        }
+       return ret;
+}
 
-       if (track_object_refs) {
-               struct tree_entry_list *entry;
-               unsigned i = 0;
-               struct object_refs *refs = alloc_object_refs(n_refs);
-               for (entry = item->entries; entry; entry = entry->next) {
-                       struct object *obj;
-
-                       if (entry->directory)
-                               obj = &lookup_tree(entry->sha1)->object;
-                       else
-                               obj = &lookup_blob(entry->sha1)->object;
-                       refs->ref[i++] = obj;
-               }
-
-               set_object_refs(&item->object, refs);
+void free_tree_entry_list(struct tree_entry_list *list)
+{
+       while (list) {
+               struct tree_entry_list *next = list->next;
+               free(list);
+               list = next;
        }
-
-       return 0;
 }
 
 int parse_tree(struct tree *item)