X-Git-Url: https://git.octo.it/?p=git.git;a=blobdiff_plain;f=ident.c;h=7b44cbd2cc54c049518b9fb1cb681a88c7aaa6c4;hp=7a9f5672ebfa0d3fc4ba72b7b90273b11aeebee4;hb=HEAD;hpb=d06b689a933f6d2130f8afdf1ac0ddb83eeb59ab

diff --git a/ident.c b/ident.c
index 7a9f5672..7b44cbd2 100644
--- a/ident.c
+++ b/ident.c
@@ -8,8 +8,7 @@
 #include "cache.h"
 
 #include <pwd.h>
-#include <time.h>
-#include <ctype.h>
+#include <netdb.h>
 
 static char git_default_date[50];
 
@@ -66,9 +65,15 @@ int setup_ident(void)
 	git_default_email[len++] = '@';
 	gethostname(git_default_email + len, sizeof(git_default_email) - len);
 	if (!strchr(git_default_email+len, '.')) {
+		struct hostent *he = gethostbyname(git_default_email + len);
+		char *domainname;
+
 		len = strlen(git_default_email);
 		git_default_email[len++] = '.';
-		getdomainname(git_default_email+len, sizeof(git_default_email)-len);
+		if (he && (domainname = strchr(he->h_name, '.')))
+			safe_strncpy(git_default_email + len, domainname + 1, sizeof(git_default_email) - len);
+		else
+			safe_strncpy(git_default_email + len, "(none)", sizeof(git_default_email) - len);
 	}
 	/* And set the default date */
 	datestamp(git_default_date, sizeof(git_default_date));
@@ -134,7 +139,7 @@ static int copy(char *buf, int size, int offset, const char *src)
 
 	/*
 	 * Copy the rest to the buffer, but avoid the special
-	 * characters '\n' '<' and '>' that act as delimeters on
+	 * characters '\n' '<' and '>' that act as delimiters on
 	 * a identification line
 	 */
 	for (i = 0; i < len; i++) {
@@ -150,7 +155,18 @@ static int copy(char *buf, int size, int offset, const char *src)
 	return offset;
 }
 
-char *get_ident(const char *name, const char *email, const char *date_str)
+static const char au_env[] = "GIT_AUTHOR_NAME";
+static const char co_env[] = "GIT_COMMITTER_NAME";
+static const char *env_hint =
+"\n*** Environment problem:\n"
+"*** Your name cannot be determined from your system services (gecos).\n"
+"*** You would need to set %s and %s\n"
+"*** environment variables; otherwise you won't be able to perform\n"
+"*** certain operations because of \"empty ident\" errors.\n"
+"*** Alternatively, you can use user.name configuration variable.\n\n";
+
+static const char *get_ident(const char *name, const char *email,
+			     const char *date_str, int error_on_no_name)
 {
 	static char buffer[1000];
 	char date[50];
@@ -160,6 +176,16 @@ char *get_ident(const char *name, const char *email, const char *date_str)
 		name = git_default_name;
 	if (!email)
 		email = git_default_email;
+
+	if (!*name) {
+		if (name == git_default_name && env_hint) {
+			fprintf(stderr, env_hint, au_env, co_env);
+			env_hint = NULL; /* warn only once, for "git-var -l" */
+		}
+		if (error_on_no_name)
+			die("empty ident %s <%s> not allowed", name, email);
+	}
+
 	strcpy(date, git_default_date);
 	if (date_str)
 		parse_date(date_str, date, sizeof(date));
@@ -175,12 +201,18 @@ char *get_ident(const char *name, const char *email, const char *date_str)
 	return buffer;
 }
 
-char *git_author_info(void)
+const char *git_author_info(int error_on_no_name)
 {
-	return get_ident(getenv("GIT_AUTHOR_NAME"), getenv("GIT_AUTHOR_EMAIL"), getenv("GIT_AUTHOR_DATE"));
+	return get_ident(getenv("GIT_AUTHOR_NAME"),
+			 getenv("GIT_AUTHOR_EMAIL"),
+			 getenv("GIT_AUTHOR_DATE"),
+			 error_on_no_name);
 }
 
-char *git_committer_info(void)
+const char *git_committer_info(int error_on_no_name)
 {
-	return get_ident(getenv("GIT_COMMITTER_NAME"), getenv("GIT_COMMITTER_EMAIL"), getenv("GIT_COMMITTER_DATE"));
+	return get_ident(getenv("GIT_COMMITTER_NAME"),
+			 getenv("GIT_COMMITTER_EMAIL"),
+			 getenv("GIT_COMMITTER_DATE"),
+			 error_on_no_name);
 }