From: Junio C Hamano Date: Fri, 24 Mar 2006 07:43:52 +0000 (-0800) Subject: send-email: Identify author at the top when sending e-mail X-Git-Tag: v1.3.0-rc1~1^2~10 X-Git-Url: https://git.octo.it/?p=git.git;a=commitdiff_plain;h=8a8e623514d79f006d9b83c47248435f20d4be2a send-email: Identify author at the top when sending e-mail git-send-email did not check if the sender is the same as the patch author. Follow the "From: at the beginning" convention to propagate the patch author correctly. Signed-off-by: Junio C Hamano --- diff --git a/git-send-email.perl b/git-send-email.perl index 7c8d5122..b220d11c 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -307,6 +307,7 @@ $subject = $initial_subject; foreach my $t (@files) { open(F,"<",$t) or die "can't open file $t"; + my $author_not_sender = undef; @cc = @initial_cc; my $found_mbox = 0; my $header_done = 0; @@ -321,7 +322,12 @@ foreach my $t (@files) { $subject = $1; } elsif (/^(Cc|From):\s+(.*)$/) { - next if ($2 eq $from && $suppress_from); + if ($2 eq $from) { + next if ($suppress_from); + } + else { + $author_not_sender = $2; + } printf("(mbox) Adding cc: %s from line '%s'\n", $2, $_) unless $quiet; push @cc, $2; @@ -360,6 +366,9 @@ foreach my $t (@files) { } } close F; + if (defined $author_not_sender) { + $message = "From: $author_not_sender\n\n$message"; + } $cc = join(", ", unique_email_list(@cc));