From c80fecc1379437f3b3c7420f57ce18ae5febf2b3 Mon Sep 17 00:00:00 2001 From: Florian Forster Date: Fri, 2 Feb 2018 08:49:46 +0100 Subject: [PATCH 1/1] Package fitbit: Return errors instead of logging them. We ensure that errors are not printed to the user, see 79cc9f9d92197e7286c166978401f99c679932c2 --- fitbit/fitbit.go | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/fitbit/fitbit.go b/fitbit/fitbit.go index 9466b12..ef6282e 100644 --- a/fitbit/fitbit.go +++ b/fitbit/fitbit.go @@ -228,8 +228,7 @@ func (c *Client) Subscribe(ctx context.Context, collection string) error { if res.StatusCode >= 400 && res.StatusCode != http.StatusConflict { data, _ := ioutil.ReadAll(res.Body) - log.Errorf(ctx, "creating %q subscription failed: status %d %q", collection, res.StatusCode, data) - return fmt.Errorf("creating %q subscription failed", collection) + return fmt.Errorf("creating %q subscription failed: status %d %q", collection, res.StatusCode, data) } if res.StatusCode == http.StatusConflict { log.Infof(ctx, "creating %q subscription: already exists", collection) @@ -258,8 +257,7 @@ func (c *Client) unsubscribe(ctx context.Context, userID, collection, subscripti if res.StatusCode >= 400 && res.StatusCode != http.StatusNotFound { data, _ := ioutil.ReadAll(res.Body) - log.Errorf(ctx, "deleting %q subscription failed: status %d %q", collection, res.StatusCode, data) - return fmt.Errorf("deleting %q subscription failed", collection) + return fmt.Errorf("deleting %q subscription failed: status %d %q", collection, res.StatusCode, data) } if res.StatusCode == http.StatusNotFound { log.Infof(ctx, "deleting %q subscription: not found", collection) @@ -377,8 +375,7 @@ func (c *Client) Profile(ctx context.Context) (*Profile, error) { if res.StatusCode >= 400 { data, _ := ioutil.ReadAll(res.Body) - log.Errorf(ctx, "reading profile failed: %s", data) - return nil, fmt.Errorf("HTTP %d error", res.StatusCode) + return nil, fmt.Errorf("reading profile failed: %s", data) } var data struct { -- 2.11.0