X-Git-Url: https://git.octo.it/?p=rrdtool.git;a=blobdiff_plain;f=src%2Frrd_daemon.c;h=22093205ba099b49bb1d98172c2fb84baffc2355;hp=25675a1c9725ac3f61c1227d43a343e7c878da46;hb=0fdd2b797ac6e498415c1910110806f37ab9bf1c;hpb=0cf61ecda624ab695eeb8f73c189d6f72479d351 diff --git a/src/rrd_daemon.c b/src/rrd_daemon.c index 25675a1..2209320 100644 --- a/src/rrd_daemon.c +++ b/src/rrd_daemon.c @@ -114,8 +114,9 @@ #define RRDD_LOG(severity, ...) \ do { \ - if (stay_foreground) \ + if (stay_foreground) { \ fprintf(stderr, __VA_ARGS__); \ + fprintf(stderr, "\n"); } \ syslog ((severity), __VA_ARGS__); \ } while (0) @@ -227,6 +228,8 @@ static uid_t daemon_uid; static listen_socket_t *listen_fds = NULL; static size_t listen_fds_num = 0; +static listen_socket_t default_socket; + enum { RUNNING, /* normal operation */ FLUSHING, /* flushing remaining values */ @@ -1476,7 +1479,7 @@ static int handle_request_update (HANDLER_PROTO) /* {{{ */ static int handle_request_fetch (HANDLER_PROTO) /* {{{ */ { - char *file; + char *file, file_tmp[PATH_MAX]; char *cf; char *start_str; @@ -1530,6 +1533,9 @@ static int handle_request_fetch (HANDLER_PROTO) /* {{{ */ if (status != 0) return (syntax_error(sock,cmd)); + get_abs_path(&file, file_tmp); + if (!check_file_access(file, sock)) return 0; + status = flush_file (file); if ((status != 0) && (status != ENOENT)) return (send_response (sock, RESP_ERR, @@ -1572,7 +1578,7 @@ static int handle_request_fetch (HANDLER_PROTO) /* {{{ */ value = strtol (end_str, &endptr, /* base = */ 0); if ((endptr == end_str) || (errno != 0)) return (send_response(sock, RESP_ERR, - "Cannot parse start time `%s': Only simple integers are allowed.\n", + "Cannot parse end time `%s': Only simple integers are allowed.\n", end_str)); if (value > 0) @@ -1628,7 +1634,9 @@ static int handle_request_fetch (HANDLER_PROTO) /* {{{ */ if (i > 0) SSTRCAT (linebuf, " ", linebuf_fill); SSTRCAT (linebuf, ds_namv[i], linebuf_fill); + rrd_freemem(ds_namv[i]); } + rrd_freemem(ds_namv); add_response_info (sock, "DSName: %s\n", linebuf); } @@ -1654,6 +1662,7 @@ static int handle_request_fetch (HANDLER_PROTO) /* {{{ */ add_response_info (sock, "%10lu:%s\n", (unsigned long) t, linebuf); } /* for (t) */ + rrd_freemem(data); return (send_response (sock, RESP_OK, "Success\n")); #undef SSTRCAT @@ -1915,6 +1924,17 @@ static int socket_permission_add (listen_socket_t *sock, /* {{{ */ return (0); } /* }}} int socket_permission_add */ +static void socket_permission_clear (listen_socket_t *sock) /* {{{ */ +{ + sock->permissions = 0; +} /* }}} socket_permission_clear */ + +static void socket_permission_copy (listen_socket_t *dest, /* {{{ */ + listen_socket_t *src) +{ + dest->permissions = src->permissions; +} /* }}} socket_permission_copy */ + /* check whether commands are received in the expected context */ static int command_check_context(listen_socket_t *sock, command_t *cmd) { @@ -2860,10 +2880,10 @@ static int daemonize (void) /* {{{ */ } else { - listen_socket_t sock; - memset(&sock, 0, sizeof(sock)); - strncpy(sock.addr, RRDCACHED_DEFAULT_ADDRESS, sizeof(sock.addr)-1); - open_listen_socket (&sock); + strncpy(default_socket.addr, RRDCACHED_DEFAULT_ADDRESS, + sizeof(default_socket.addr) - 1); + default_socket.addr[sizeof(default_socket.addr) - 1] = '\0'; + open_listen_socket (&default_socket); } if (listen_fds_num < 1) @@ -2968,11 +2988,10 @@ static int read_options (int argc, char **argv) /* {{{ */ int option; int status = 0; - char **permissions = NULL; - size_t permissions_len = 0; + socket_permission_clear (&default_socket); - gid_t socket_group = (gid_t)-1; - mode_t socket_permissions = (mode_t)-1; + default_socket.socket_group = (gid_t)-1; + default_socket.socket_permissions = (mode_t)-1; while ((option = getopt(argc, argv, "gl:s:m:P:f:w:z:t:Bb:p:Fj:a:h?")) != -1) { @@ -2997,22 +3016,11 @@ static int read_options (int argc, char **argv) /* {{{ */ strncpy(new->addr, optarg, sizeof(new->addr)-1); /* Add permissions to the socket {{{ */ - if (permissions_len != 0) + if (default_socket.permissions != 0) { - size_t i; - for (i = 0; i < permissions_len; i++) - { - status = socket_permission_add (new, permissions[i]); - if (status != 0) - { - fprintf (stderr, "read_options: Adding permission \"%s\" to " - "socket failed. Most likely, this permission doesn't " - "exist. Check your command line.\n", permissions[i]); - status = 4; - } - } + socket_permission_copy (new, &default_socket); } - else /* if (permissions_len == 0) */ + else /* if (default_socket.permissions == 0) */ { /* Add permission for ALL commands to the socket. */ size_t i; @@ -3023,15 +3031,15 @@ static int read_options (int argc, char **argv) /* {{{ */ { fprintf (stderr, "read_options: Adding permission \"%s\" to " "socket failed. This should never happen, ever! Sorry.\n", - permissions[i]); + list_of_commands[i].cmd); status = 4; } } } /* }}} Done adding permissions. */ - new->socket_group = socket_group; - new->socket_permissions = socket_permissions; + new->socket_group = default_socket.socket_group; + new->socket_permissions = default_socket.socket_permissions; if (!rrd_add_ptr((void ***)&config_listen_address_list, &config_listen_address_list_len, new)) @@ -3061,7 +3069,7 @@ static int read_options (int argc, char **argv) /* {{{ */ if (grp) { - socket_group = grp->gr_gid; + default_socket.socket_group = grp->gr_gid; } else { @@ -3086,7 +3094,7 @@ static int read_options (int argc, char **argv) /* {{{ */ return (5); } - socket_permissions = (mode_t)tmp; + default_socket.socket_permissions = (mode_t)tmp; } break; @@ -3097,7 +3105,7 @@ static int read_options (int argc, char **argv) /* {{{ */ char *dummy; char *ptr; - rrd_free_ptrs ((void *) &permissions, &permissions_len); + socket_permission_clear (&default_socket); optcopy = strdup (optarg); dummy = optcopy; @@ -3105,7 +3113,14 @@ static int read_options (int argc, char **argv) /* {{{ */ while ((ptr = strtok_r (dummy, ", ", &saveptr)) != NULL) { dummy = NULL; - rrd_add_strdup ((void *) &permissions, &permissions_len, ptr); + status = socket_permission_add (&default_socket, ptr); + if (status != 0) + { + fprintf (stderr, "read_options: Adding permission \"%s\" to " + "socket failed. Most likely, this permission doesn't " + "exist. Check your command line.\n", ptr); + status = 4; + } } free (optcopy); @@ -3352,8 +3367,6 @@ static int read_options (int argc, char **argv) /* {{{ */ if (journal_dir == NULL) config_flush_at_shutdown = 1; - rrd_free_ptrs ((void *) &permissions, &permissions_len); - return (status); } /* }}} int read_options */