From: oetiker <oetiker@a5681a0c-68f1-0310-ab6d-d61299d08faa>
Date: Wed, 29 Jun 2011 15:18:22 +0000 (+0000)
Subject: proper fix for the header size problem and its effects on rrd_resize
X-Git-Url: https://git.octo.it/?p=rrdtool.git;a=commitdiff_plain;h=87699aa7a0d9770907d972e00ebbe7e888b3bc8a

proper fix for the header size problem and its effects on rrd_resize


git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2192 a5681a0c-68f1-0310-ab6d-d61299d08faa
---

diff --git a/src/rrd_format.c b/src/rrd_format.c
index 501b267..5200b33 100644
--- a/src/rrd_format.c
+++ b/src/rrd_format.c
@@ -125,8 +125,7 @@ off_t rrd_get_header_size(
     return sizeof(stat_head_t) + \
         sizeof(ds_def_t) * rrd->stat_head->ds_cnt + \
         sizeof(rra_def_t) * rrd->stat_head->rra_cnt + \
-        sizeof(time_t) + \
-        sizeof(live_head_t) + \
+        ( atoi(rrd->stat_head->version) < 3 ? sizeof(time_t) : sizeof(live_head_t) ) + \
         sizeof(pdp_prep_t) * rrd->stat_head->ds_cnt + \
         sizeof(cdp_prep_t) * rrd->stat_head->ds_cnt * rrd->stat_head->rra_cnt + \
         sizeof(rra_ptr_t) * rrd->stat_head->rra_cnt;
diff --git a/src/rrd_resize.c b/src/rrd_resize.c
index 8141025..3613d3f 100644
--- a/src/rrd_resize.c
+++ b/src/rrd_resize.c
@@ -267,9 +267,14 @@ int rrd_resize(
     /* Move the rest of the CDPs
      */
     while (1) {
-        if (rrd_read(rrd_file, &buffer, sizeof(rrd_value_t) * 1) <= 0)
+        ssize_t b_read;
+        if ((b_read=rrd_read(rrd_file, &buffer, sizeof(rrd_value_t) * 1)) <= 0)
             break;
-        rrd_write(rrd_out_file, &buffer, sizeof(rrd_value_t) * 1);
+        if(rrd_out_file->pos+b_read > rrd_out_file->file_len) {
+            fprintf(stderr,"WARNING: ignoring last %zu bytes\nWARNING: if you see this message multiple times for a single file you're in trouble\n", b_read);
+            continue;
+        }
+        rrd_write(rrd_out_file, &buffer, b_read);
     }
     rrdnew.rra_def[target_rra].row_cnt += modify;
     rrd_seek(rrd_out_file,