rrdtool.git
12 years agoadd documentation for graph-render-mode
oetiker [Fri, 17 Apr 2009 09:53:57 +0000 (09:53 +0000)]
add documentation for graph-render-mode

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1794 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agofix comments and error messages in rrd_restore patch
oetiker [Wed, 15 Apr 2009 07:05:58 +0000 (07:05 +0000)]
fix comments and error messages in rrd_restore patch

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1793 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoFix casting issues in rrd_restore. The bug manifested when compiled on sparc v9 as...
oetiker [Wed, 15 Apr 2009 07:02:04 +0000 (07:02 +0000)]
Fix casting issues in rrd_restore. The bug manifested when compiled on sparc v9 as explained in #218.
Patch based in input provided by poster of #218.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1792 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agomake ruby bindings compile with newer ruby versions ... fix for #217
oetiker [Tue, 14 Apr 2009 13:55:29 +0000 (13:55 +0000)]
make ruby bindings compile with newer ruby versions ... fix for #217
patch provided by rrd trac user.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1791 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoGenerate an error message when using RRDp with graph - this can not work reliably...
oetiker [Tue, 14 Apr 2009 07:51:20 +0000 (07:51 +0000)]
Generate an error message when using RRDp with graph - this can not work reliably. (Debian Bug#251701) -- Sebastian Harl

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1790 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agorrd_random() is a wrapper around random() that ensures the PRNG is seeded
oetiker [Tue, 14 Apr 2009 06:10:21 +0000 (06:10 +0000)]
rrd_random() is a wrapper around random() that ensures the PRNG is seeded
exactly ONCE per process.

rrd_utils.c is introduced for functions that do not have a better home. --kevin

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1789 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoThis patch consolidates several aspects of the command handling in
oetiker [Fri, 10 Apr 2009 08:52:34 +0000 (08:52 +0000)]
This patch consolidates several aspects of the command handling in
rrdcached:

 * all commands, help, and context information is reduced to a single data
   structure.

 * all checks for command validity (context and permission) are handled in
   the main dispatch routine

This removes duplicate help/syntax text, and long if..elseif..else chains.
It facilitates the addition of new commands. -- kevin

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1788 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoThe bookkeeping of all threads is not necessary, since we cannot pthread_join() them...
oetiker [Thu, 9 Apr 2009 15:07:05 +0000 (15:07 +0000)]
The bookkeeping of all threads is not necessary, since we cannot pthread_join() them anyway. We only need to know when the last one has exited. -- kevin

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1787 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoadded missing docs -- kevin
oetiker [Thu, 9 Apr 2009 15:05:41 +0000 (15:05 +0000)]
added missing docs -- kevin

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1786 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoadded missing newline -- by sebastian harl
oetiker [Thu, 9 Apr 2009 15:04:27 +0000 (15:04 +0000)]
added missing newline -- by sebastian harl

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1785 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agomake sure an empty m4 is in the checkout
oetiker [Tue, 7 Apr 2009 07:23:20 +0000 (07:23 +0000)]
make sure an empty m4 is in the checkout

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1778 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agofix for #213 restore old behaviour of --lazy. Even in lazy mode all the data
oetiker [Tue, 7 Apr 2009 06:37:17 +0000 (06:37 +0000)]
fix for #213 restore old behaviour of --lazy. Even in lazy mode all the data
calculation elements are run. The main time saving comes from the fact that
the graph is not being drawn and the image does not have to be compressed.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1773 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agomake sure rrd_dump outputs numbers with C locale so that . does not suddenly become...
oetiker [Tue, 7 Apr 2009 06:03:49 +0000 (06:03 +0000)]
make sure rrd_dump outputs numbers with C locale so that . does not suddenly become , this fixes #212

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1772 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoI thought that it would be nice to be able to pass
oetiker [Mon, 6 Apr 2009 14:49:03 +0000 (14:49 +0000)]
I thought that it would be nice to be able to pass
parameters to python bindings as a list (array) of strings. -- Vytautas Zdanavicius vytaszd at yahoo.com

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1771 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agouse %lld with (long long) conversion when printing time.
oetiker [Mon, 6 Apr 2009 14:14:31 +0000 (14:14 +0000)]
use %lld with (long long) conversion when printing time.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1770 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoprintf for time_t with %lli can easily cause a segfault since on many platforms
oetiker [Mon, 6 Apr 2009 14:12:21 +0000 (14:12 +0000)]
printf for time_t with %lli can easily cause a segfault since on many platforms
time_t is only 32bit ... by adding (long long) to the time value this gets fixed.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1769 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agolets have an error message when creating the graph fails
oetiker [Mon, 6 Apr 2009 14:08:16 +0000 (14:08 +0000)]
lets have an error message when creating the graph fails

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1768 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoremove excess flush calls ...
oetiker [Sat, 21 Mar 2009 10:45:40 +0000 (10:45 +0000)]
remove excess flush calls ...

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1764 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoremove flush symbol
oetiker [Sat, 21 Mar 2009 09:56:43 +0000 (09:56 +0000)]
remove flush symbol

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1762 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agothe call to rrd_flush has appeared when rrd_open was fleshed out. It used to be an...
oetiker [Sat, 21 Mar 2009 09:53:30 +0000 (09:53 +0000)]
the call to rrd_flush has appeared when rrd_open was fleshed out. It used to be an fflush call
which is something entirely different than the current rrd_flush implementation with fdatasync was ...

we can safely drop this and gain performance for holt winters in the process ... -- tobi

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1760 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoNew rrd_graph functions for legend placement control added -- Patch by Melchior...
oetiker [Wed, 18 Mar 2009 17:12:09 +0000 (17:12 +0000)]
New rrd_graph functions for legend  placement control added -- Patch by Melchior Rabe rrdtool mrab.de

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1759 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agorrd_flush.c: Provide a more useful error message.
oetiker [Sun, 8 Mar 2009 11:12:41 +0000 (11:12 +0000)]
rrd_flush.c: Provide a more useful error message.
by Sebastian Harl

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1758 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoRenaming ntmake.pl to ntmake.PL (r1742) had unforseen side effects. At least
oetiker [Sun, 8 Mar 2009 08:02:38 +0000 (08:02 +0000)]
Renaming ntmake.pl to ntmake.PL (r1742) had unforseen side effects. At least
on freebsd ntmake.PL gets called automatically during build. This is not
desired. I renamed the file to ntmake-build sinc it gets called
explicilty on windows anyway. Reported by Kevin modified by Tobi

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1757 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoThis 2-patch series exposes 'flush' methods to the various language
oetiker [Sat, 7 Mar 2009 10:31:51 +0000 (10:31 +0000)]
This 2-patch series exposes 'flush' methods to the various language
bindings.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1756 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agothere were two lines of debug info printed by rrd_xport, messing up the xml code...
oetiker [Fri, 6 Mar 2009 05:51:34 +0000 (05:51 +0000)]
there were two lines of debug info printed by rrd_xport, messing up the xml code. Fix by Alejandro Galue.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1754 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoEven though POSIX/XSI requires "strerror_r" to return an "int", some systems
oetiker [Fri, 6 Mar 2009 05:39:37 +0000 (05:39 +0000)]
Even though POSIX/XSI requires "strerror_r" to return an "int", some systems
(e.g. the GNU libc) return a "char *" _and_ ignore the second argument (user
provided buffer). The configure script now checks for that behavior using
AC_FUNC_STRERROR_R. rrd_strerror() in rrd_thread_safe.c has been updated to
(hopefully) handle all possible cases.

Previously, rrd_strerror() would have returned "strerror_r failed. sorry!" in
mostly any cases when using glibc, since "if (strerror_r())" had been used to
check for errors which evaluates to true if a (non-NULL) pointer was returned.

Now, we, at least, return the error number in case anything else fails.

Thanks to Alessandro Iurlano for reporting this issue after spotting it in
collectd <http://collectd.org>.

patch by Sebastian Harl

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1752 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoMake sure we use correct sizes for vsnprintf (sizeof) and strncpy (sizeof-1). --...
oetiker [Fri, 6 Mar 2009 05:30:08 +0000 (05:30 +0000)]
Make sure we use correct sizes for vsnprintf (sizeof) and strncpy (sizeof-1). -- kevin

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1751 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoMisc documentation fixes by Alex van den Bogaerdt
oetiker [Sat, 21 Feb 2009 09:43:58 +0000 (09:43 +0000)]
Misc documentation fixes by Alex van den Bogaerdt

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1749 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoDocumentation fixes by Bernhard Reutner-Fischer
oetiker [Sat, 21 Feb 2009 09:23:04 +0000 (09:23 +0000)]
Documentation fixes by  Bernhard Reutner-Fischer

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1748 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoadded doc on new graphv graph_start und graph_end info variables
oetiker [Sun, 25 Jan 2009 22:39:34 +0000 (22:39 +0000)]
added doc on new graphv graph_start und graph_end info variables

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1745 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agofix type conversion error (on windows) unsigned/signed affecting timestamps on rrd_dump.
oetiker [Sun, 25 Jan 2009 22:02:57 +0000 (22:02 +0000)]
fix type conversion error (on windows) unsigned/signed affecting timestamps on rrd_dump.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1744 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agorename ntmake.pl to ntmake.PL so that it does not get installed
oetiker [Sun, 25 Jan 2009 21:52:25 +0000 (21:52 +0000)]
rename ntmake.pl to ntmake.PL so that it does not get installed

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1742 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agodefine cwd where we need it and not outside
oetiker [Sun, 25 Jan 2009 18:38:34 +0000 (18:38 +0000)]
define cwd where we need it and not outside

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1741 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoIn rrd_graph: the width/height values are written into rrd_infoval_t's u_cnt
oetiker [Wed, 14 Jan 2009 08:14:31 +0000 (08:14 +0000)]
In rrd_graph: the width/height values are written into rrd_infoval_t's u_cnt
but read out of u_int (u_long vs. int). This breaks on LP64BE. Patch by
Rafal Boni rafal pobox.com

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1733 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoadded percentnan (VDEF PERCENT variant that ignores NAN) -- patch by Martin Sperl
oetiker [Wed, 14 Jan 2009 07:22:09 +0000 (07:22 +0000)]
added percentnan (VDEF PERCENT variant that ignores NAN) -- patch by Martin Sperl

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1732 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agowith MMAP enabled rrd resize GROW was broken ... this fixes it ...
oetiker [Tue, 6 Jan 2009 16:32:16 +0000 (16:32 +0000)]
with MMAP enabled rrd resize GROW was broken ... this fixes it ...

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1726 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoTICK with negative numbers should 'start from the top of the graph' looking down...
oetiker [Tue, 6 Jan 2009 15:45:53 +0000 (15:45 +0000)]
TICK with negative numbers should 'start from the top of the graph' looking down ... now it does.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1725 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agofix for segfault in rrd_cgi: caused by freeing a invalid address when printing an...
oetiker [Tue, 6 Jan 2009 14:54:41 +0000 (14:54 +0000)]
fix for segfault in rrd_cgi: caused by freeing a invalid address when printing an error message.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1724 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoInclude libgen.h to get prototype for basename in a POSIX conformant way. Fix for...
oetiker [Fri, 26 Dec 2008 08:05:03 +0000 (08:05 +0000)]
Include libgen.h to get prototype for basename in a POSIX conformant way. Fix for #202.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1723 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoimprovements for build docs by Zorzoli, Pablo
oetiker [Fri, 26 Dec 2008 08:03:06 +0000 (08:03 +0000)]
improvements for build docs by Zorzoli, Pablo

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1722 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoshould free memory after a successful fetch too ...
oetiker [Mon, 22 Dec 2008 21:23:49 +0000 (21:23 +0000)]
should free memory after a successful fetch too ...

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1721 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agodocumentation fixes
oetiker [Mon, 22 Dec 2008 21:23:04 +0000 (21:23 +0000)]
documentation fixes

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1720 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoFix for POD error by Sebasian Harl
oetiker [Mon, 22 Dec 2008 07:21:46 +0000 (07:21 +0000)]
Fix for POD error by Sebasian Harl

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1718 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoFixes some typos by Sebastian Harl.
oetiker [Mon, 22 Dec 2008 07:20:17 +0000 (07:20 +0000)]
Fixes some typos by Sebastian Harl.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1717 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agowin32 fixes by Stefan . Ludewig . exitgames . com
oetiker [Fri, 19 Dec 2008 14:26:47 +0000 (14:26 +0000)]
win32 fixes by Stefan . Ludewig . exitgames . com

* added portable plbasename since basename is not available on stock win32
* rrd_update was using %d to show a timestamp ... %lli is better
  since it also will show 64bit time_t correctly.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1716 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agofix extra dist to include missing win32 files
oetiker [Thu, 18 Dec 2008 23:56:52 +0000 (23:56 +0000)]
fix extra dist to include missing win32 files

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1715 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agofixed another seek issue ...
oetiker [Thu, 11 Dec 2008 14:31:16 +0000 (14:31 +0000)]
fixed another seek issue ...

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1708 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoThe spec file for building the rrdtool as an RPM that comes with the
oetiker [Thu, 11 Dec 2008 10:01:33 +0000 (10:01 +0000)]
The spec file for building the rrdtool as an RPM that comes with the
release is not "friendly" to older versions of RHEL and derivatives.
-- Martin Sperl <rrdtool@martin.sperl.org>

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1707 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoinclude luapod into distro
oetiker [Thu, 11 Dec 2008 09:59:10 +0000 (09:59 +0000)]
include luapod into distro

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1706 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoOn some architectures, strtod does not turn "NaN" into 'Not A Number (NAN)'
oetiker [Wed, 10 Dec 2008 13:18:10 +0000 (13:18 +0000)]
On some architectures, strtod does not turn "NaN" into 'Not A Number (NAN)'
se we better provide our own code here.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1705 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agorrdtool dump is now backward compatible with rrdtool 1.3 dump again. Default is ...
oetiker [Wed, 10 Dec 2008 12:42:46 +0000 (12:42 +0000)]
rrdtool dump is now backward compatible with rrdtool 1.3 dump again. Default is --header=dtd and
--no-header is an alias for --header=none

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1703 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agominichange
oetiker [Wed, 10 Dec 2008 08:29:38 +0000 (08:29 +0000)]
minichange

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1702 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years ago* forward ported right axis patch from 1.2 branche
oetiker [Tue, 9 Dec 2008 18:30:43 +0000 (18:30 +0000)]
* forward ported right axis patch from 1.2 branche
* fixed --full-size-mode sizing issue when used in combination with --title
the work in the axis patch has been sponsored by VoltWerk.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1701 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoFix for last method in ruby bindings -- Hiroyuki Ikezoe
oetiker [Mon, 8 Dec 2008 16:07:27 +0000 (16:07 +0000)]
Fix for last method in ruby bindings -- Hiroyuki Ikezoe

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1700 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agointegrate osx build hints as indicated in #192
oetiker [Fri, 5 Dec 2008 15:39:55 +0000 (15:39 +0000)]
integrate osx build hints as indicated in #192

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1699 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agodeleted a bit much from rrd_open ... merged back in
oetiker [Fri, 5 Dec 2008 15:23:45 +0000 (15:23 +0000)]
deleted a bit much from rrd_open ... merged back in

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1697 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agocheck for broken implementations of msync / MS_ASYNC where
oetiker [Fri, 5 Dec 2008 15:18:11 +0000 (15:18 +0000)]
check for broken implementations of msync / MS_ASYNC where
the mtime does not get updated. warn and explicitly call utime
in rrd_open when a file is opened rw.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1696 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoadded rrdcached examples to extra_dist to make sure they get distributed
oetiker [Fri, 5 Dec 2008 10:23:46 +0000 (10:23 +0000)]
added rrdcached examples to extra_dist to make sure they get distributed

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1695 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoLegends should NOT be placed in reverse order when using --full-size-mode ... this...
oetiker [Thu, 4 Dec 2008 16:01:37 +0000 (16:01 +0000)]
Legends should NOT be placed in reverse order when using --full-size-mode ... this fixed #198.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1694 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoadd de-referencing to step in fetch check
oetiker [Thu, 4 Dec 2008 15:49:11 +0000 (15:49 +0000)]
add de-referencing to step in fetch check

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1693 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agofix merg error with win32 port
oetiker [Thu, 4 Dec 2008 15:48:39 +0000 (15:48 +0000)]
fix merg error with win32 port

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1692 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoCatch CDEF:tot= and raise and error to fix #199. Thanks to Jeron Massar for reporting...
oetiker [Thu, 4 Dec 2008 09:03:48 +0000 (09:03 +0000)]
Catch CDEF:tot= and raise and error to fix #199. Thanks to Jeron Massar for reporting this.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1691 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoUpdate to WIN32-BUILD-TIPS.txt and VC project files so that the rrdtool.exe can be...
oetiker [Thu, 4 Dec 2008 07:02:56 +0000 (07:02 +0000)]
Update to WIN32-BUILD-TIPS.txt and VC project files so that the rrdtool.exe can be built too.
-- Stefan Ludewig Stefan.Ludewig exitgames.com

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1690 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoWhen fetching data from 'past' an rra, rrd_fetch was seeking past the rrd
oetiker [Wed, 3 Dec 2008 11:08:48 +0000 (11:08 +0000)]
When fetching data from 'past' an rra, rrd_fetch was seeking past the rrd
file. This did cause seek errors in some setups. Fixed. Thanks to Daniel Pocock for finding the problem.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1689 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agointegrated rrdcached examples into build process
oetiker [Wed, 3 Dec 2008 09:54:09 +0000 (09:54 +0000)]
integrated rrdcached examples into build process

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1686 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoadd rrdcached examples -- kevin
oetiker [Wed, 3 Dec 2008 08:47:56 +0000 (08:47 +0000)]
add rrdcached examples -- kevin

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1685 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agofixed solaris build instructions
oetiker [Tue, 2 Dec 2008 12:35:02 +0000 (12:35 +0000)]
fixed solaris build instructions

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1683 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoadded libdbi doc to extradist
oetiker [Mon, 1 Dec 2008 11:05:52 +0000 (11:05 +0000)]
added libdbi doc to extradist

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1682 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoAttached a patch for the rrd-tool LIBDBI integration with the following improvements:
oetiker [Thu, 20 Nov 2008 13:04:38 +0000 (13:04 +0000)]
Attached a patch for the rrd-tool LIBDBI integration with the following improvements:

a) correct error handling in case of libdbi being unable to load the driver
   was producing segmentation faults.

b) better parsing of datasources

   * until now timestamp fields had to be integer and had to contain a unix
     timestamp - now you can now also use DateTime fields (you still need to
     specify it, as the time-range needs to be defined correctly)

   * data fields are now no longer limited to (var)char or DOUBLE fields -
     FLOAT, INTEGER,... are now also supported.

c) there is a bug with at least LIBDBI 0.8.1 in conjunction with mysql that
   can result in segmentation faults when BINARY/BLOB fields are accessed -
   rrdtool will now tell you about this fact before dying ;)

d) also the value of rrdderivemaxstep only gets applied if derive has been
   selected correctly.

e) "GROUP BY timestamp" has been removed from SQL statement.

f) "ORDER BY timestamp" will be added only in the case of fetching "derived" data.

-- Martin Sperl

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1678 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agowin32 portability patch and win32/rrdlib.vcproj file for the source
oetiker [Tue, 18 Nov 2008 17:19:17 +0000 (17:19 +0000)]
win32 portability patch and win32/rrdlib.vcproj file for the source
-- christof wegmann Christof.Wegmann with exitgames.com
some fixes to make the result work on unix again ...

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1677 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agomissing , added to help string
oetiker [Tue, 18 Nov 2008 07:14:10 +0000 (07:14 +0000)]
missing , added to  help string

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1674 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoadded build instruction for libdbi docu
oetiker [Mon, 17 Nov 2008 16:21:41 +0000 (16:21 +0000)]
added build instruction for libdbi docu

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1672 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agomissing pod files
oetiker [Sun, 16 Nov 2008 22:24:44 +0000 (22:24 +0000)]
missing pod files

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1670 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoswitch tu using AS_HELP_STRING for formatting ...
oetiker [Sat, 15 Nov 2008 14:35:51 +0000 (14:35 +0000)]
switch tu using AS_HELP_STRING for formatting ...

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1669 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agofix typo in handle_request_help
oetiker [Sat, 15 Nov 2008 14:15:38 +0000 (14:15 +0000)]
fix typo in handle_request_help
--kevin

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1668 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agodoc fixups for rrdcacehd
oetiker [Sat, 15 Nov 2008 14:14:19 +0000 (14:14 +0000)]
doc fixups for rrdcacehd

 * documented the -p option
 * added nbsp between option and argument
 * layout one option per line

--kevin

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1667 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agomake basename work
oetiker [Tue, 11 Nov 2008 16:36:45 +0000 (16:36 +0000)]
make basename work

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1666 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoThis patch allows for multiple RRD writer threads to service the queue.
oetiker [Tue, 11 Nov 2008 16:36:13 +0000 (16:36 +0000)]
This patch allows for multiple RRD writer threads to service the queue.

Now, rrdcached can have more simultaneous I/O requests into the kernel.
This may allow the kernel to re-order disk writes, resulting in better
disk throughput.  In practice, throughput is increased by 2-3x.

The flush (-f) timer maintenance has been moved from queue_thread_main
into its own thread.

Be more careful about when to use pthread_cond_signal vs _broadcast, since
multiple threads may be waiting on &queue_cond.

--kevin

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1665 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agobe even more liberal with NOT using isfinite on solaris2.8
oetiker [Sun, 9 Nov 2008 19:19:48 +0000 (19:19 +0000)]
be even more liberal with NOT using isfinite on solaris2.8

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1663 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agouse basename to determine filename for imginfo as suggested by sebastian
oetiker [Sun, 9 Nov 2008 00:00:33 +0000 (00:00 +0000)]
use basename to determine filename for imginfo as suggested by sebastian

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1662 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years ago rrdcached: move queue length decrement into remove_from_queue
oetiker [Sat, 8 Nov 2008 22:57:38 +0000 (22:57 +0000)]
 rrdcached: move queue length decrement into remove_from_queue
-- kevin

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1661 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agorrdcached: examine the current queue with the "QUEUE" command
oetiker [Sat, 8 Nov 2008 22:57:18 +0000 (22:57 +0000)]
rrdcached: examine the current queue with the "QUEUE" command
-- kevin

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1660 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoThis helps with portability on platforms where realloc doesn't handle NULL.
oetiker [Sat, 8 Nov 2008 22:50:51 +0000 (22:50 +0000)]
This helps with portability on platforms where realloc doesn't handle NULL.
-- kevin

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1659 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agodocument the "QUIT" command -- kevin
oetiker [Sat, 8 Nov 2008 18:01:33 +0000 (18:01 +0000)]
document the "QUIT" command -- kevin

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1658 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agorrdcached: journal_replay default failure reason, just in case
oetiker [Sat, 8 Nov 2008 18:01:01 +0000 (18:01 +0000)]
rrdcached: journal_replay default failure reason, just in case
avoids a "may be used uninitialized" warning -- kevin

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1657 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoadded "quit" command -- kevin
oetiker [Sat, 8 Nov 2008 18:00:21 +0000 (18:00 +0000)]
added "quit" command -- kevin

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1656 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agorrdcached now frees all of its resources correctly. This facilitates
oetiker [Sat, 8 Nov 2008 17:57:32 +0000 (17:57 +0000)]
rrdcached now frees all of its resources correctly.  This facilitates
memory debugging.  g_tree now knows how to free the nodes when it removes
them.

Also, use g_tree_replace instead of g_tree_insert.  This fixes a bug
triggered when the same file was simultaneously inserted by two clients.

--kevin

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1655 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agodo not quit when libdbi is missing
oetiker [Sat, 8 Nov 2008 17:56:48 +0000 (17:56 +0000)]
do not quit when libdbi is missing

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1654 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agofixed --font TITLE:12: problem -- tobi
oetiker [Fri, 7 Nov 2008 22:46:40 +0000 (22:46 +0000)]
fixed --font TITLE:12: problem -- tobi

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1653 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agofix scaling issue -- Martin
oetiker [Fri, 7 Nov 2008 22:23:16 +0000 (22:23 +0000)]
fix scaling issue -- Martin

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1652 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoextra file to make libdbi patch work
oetiker [Fri, 7 Nov 2008 14:09:29 +0000 (14:09 +0000)]
extra file to make libdbi patch work

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1651 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoAs some of you may know that I have created a patch for rrdtool 1.2 a few years...
oetiker [Fri, 7 Nov 2008 14:07:53 +0000 (14:07 +0000)]
As some of you may know that I have created  a patch for rrdtool 1.2 a few years ago, so that a database could be queried  for
values for graphing.

The patch has been mostly rewritten and the following changes have been made:

   * high dependency on mysql has been reduced by avoiding the
     temporary tables (which was bad for mysql replication)
   * The number of executed SQL-Statements for one CDEF has been
     reduced to 1 compared to 11 SQLs (including CREATE TEMPORARY
     TABLE) - for patch against version 1.2
   * All consolidation is done in rrdtool itself (MIN,MAX,AVERAGE)
   * Additional consolidation functions are COUNT and SIGMA, which give
     information on statistics on a per "time-bin" basis.
   * All these consolidation values are always returned as separate
     columns, that are returned by RRD and the consolidation function
     given as Argument is ignored.
     Main reason is that this way there is only one call to rrd_fetcht
     and thus the database even if we need to fetch for example min,
     avg and max. Compare this to 3 calls in case of different
     consolidation functions - and if you want to get SIGMA and COUNT
     as well it is still only one call to the backend and the database.
   * Some previous existing features have been taken out at the moment
     to allow for this reduced set of SQL queries.
         o prediction using the values from the last X days at the same
           time
         o the corresponding sigma calculation
   * The idea is to create generic CDEF's that will do the same thing,
     but that is also available when using RRD-files (similar to TREND,
     but with another scope)
     This will get posted as a separate patch.
   * Overall performance should be much better and the patch as a whole
     simpler.
   * The patch also includes modifications to the configuration
     infrastructure, to make libdbi support optional.

-- Martin Sperl

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1650 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agonew CDEF functions for predictions PREDICT and PREDICTSIGMA
oetiker [Fri, 7 Nov 2008 14:02:09 +0000 (14:02 +0000)]
new CDEF functions for predictions PREDICT and PREDICTSIGMA
-- Martin Sperl

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1649 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoMuch simpler handling of timestamp errors. Return an error to the user
oetiker [Fri, 7 Nov 2008 13:51:24 +0000 (13:51 +0000)]
Much simpler handling of timestamp errors.  Return an error to the user
when any of the time stamp values are invalid.  This is similar to
RRDTool's normal behavior.  Removed the complex logic previously used to
return error codes to the user.

This solves a bug where non-advancing timestamps could have produced
incorrect error output during "BATCH" mode.  The bug was cause by using
the sock->wbuf pointer for the error output. -- kevin brintnall

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1648 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agorrdcached: pull in rrd_config.h so we can use its defines
oetiker [Fri, 7 Nov 2008 13:45:34 +0000 (13:45 +0000)]
rrdcached: pull in rrd_config.h so we can use its defines
... particularly HAVE_VSNPRINTF --  kevin brintnall

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1647 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoI realize now that the problem is the line
oetiker [Tue, 4 Nov 2008 07:12:46 +0000 (07:12 +0000)]
I realize now that the problem is the line

    test -f lua/Makefile && cd lua && $(MAKE) install || true

in the target "install-data-local", in bindings/Makefile.am. It forces
execution of bindings/lua/Makefile independently of lua being found or
not. I added that line in my first patch, following perl, python and
ruby build style, but it's not needed after I switched to automake. The
make recursion is controlled by SUBDIRS, which will only contain "lua"
if BUILD_LUA is true.

-- Fidelis Assis

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1645 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agofix build process for systems without lua
oetiker [Sun, 2 Nov 2008 17:25:36 +0000 (17:25 +0000)]
fix build process for systems without lua

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1644 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoPTHREAD_COND_INITIALIZER may only be used to initialize static cond variables.
oetiker [Sun, 2 Nov 2008 17:09:36 +0000 (17:09 +0000)]
PTHREAD_COND_INITIALIZER may only be used to initialize static cond variables.
-- Sebastian Harl

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1643 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agoreverting non build makefile patch ... we need to lua makefile for building the ditri...
oetiker [Sun, 2 Nov 2008 15:25:48 +0000 (15:25 +0000)]
reverting non build makefile patch ... we need to lua makefile for building the ditribution

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1642 a5681a0c-68f1-0310-ab6d-d61299d08faa

12 years agodo not create the lua makefile if lua is not to be compiled.
oetiker [Sat, 1 Nov 2008 09:09:07 +0000 (09:09 +0000)]
do not create the lua makefile if lua is not to be compiled.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1641 a5681a0c-68f1-0310-ab6d-d61299d08faa