13 years agoThis patch introduces "fast shutdown" mode and two new signals.
oetiker [Sun, 28 Sep 2008 19:26:39 +0000 (19:26 +0000)]
This patch introduces "fast shutdown" mode and two new signals.
-- kevin brintnall

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1540 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoMoved signal handler setup out of daemonize(). Coalesced common code
oetiker [Sun, 28 Sep 2008 19:25:40 +0000 (19:25 +0000)]
Moved signal handler setup out of daemonize().  Coalesced common code
in preparation for new signals.  Documented behavior of existing signals.
-- kevin brintnall

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1539 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoAttached is a patch to lower the version requirements of libtool and
oetiker [Sun, 28 Sep 2008 19:23:23 +0000 (19:23 +0000)]
Attached is a patch to lower the version requirements of libtool and
automake.  I have tested this on CentOS 4.x with the specified
versions of libtool and automake and was able to build RRDTool fine.
I did *not* test building with PHP, tcl, ruby or Python though.

I also abstracted the version numbers of all the dependencies such
that editing them in the future will be easier.
-- Bernard Li

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1537 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoadded support for FLUSHALL command -- kevin brintnall
oetiker [Sun, 28 Sep 2008 19:12:22 +0000 (19:12 +0000)]
added support for FLUSHALL command -- kevin brintnall

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1535 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agomove cache broadcast into enqueue_cache_item -- kevin brintnall
oetiker [Sun, 28 Sep 2008 19:10:57 +0000 (19:10 +0000)]
move cache broadcast into enqueue_cache_item -- kevin brintnall

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1534 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoWhen -z <jitter> is specified, some updates may be timestamped up to
oetiker [Sun, 28 Sep 2008 19:10:15 +0000 (19:10 +0000)]
When -z <jitter> is specified, some updates may be timestamped up to
<jitter> seconcds in the future.  Therefore, a timeout of now+1 may not be
sufficient.  Set abs_timeout past the point where any updates are
currently specified. -- kevin brintnall

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1533 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoThe PID file is created with open() in the parent process, while we still
oetiker [Sun, 28 Sep 2008 19:09:34 +0000 (19:09 +0000)]
The PID file is created with open() in the parent process, while we still
have STDERR open.  If it cannot be created, it complains verbosely to

The PID file is written in the child process.  The only way the fdopen()
will fail on a fd that is already open is if you're completely out of
memory.  As in other places in the code, I didn't consider this a case
that required a very verbose message.  (Search for "strdup failed").  If
you still think a more verbose message is called for, please suggest one.

The attached patch corrects the error message to complain about fdopen()
vs fopen().  I hadn't noticed that until you brought it up.

--  kevin brintnall

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1532 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years ago rrd.h, librrd.sym: Define and export rrd_info_r() -- Sebastian Harl
oetiker [Sun, 28 Sep 2008 19:08:41 +0000 (19:08 +0000)]
 rrd.h, librrd.sym: Define and export rrd_info_r() --  Sebastian Harl

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1531 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agovdef calc was using end_orig to determine for which range it should do its
oetiker [Sun, 28 Sep 2008 15:01:43 +0000 (15:01 +0000)]
vdef calc was using end_orig to determine for which range it should do its
calculations which is odd, since orig is only the requested range as
invocation time and not the data range deliverd by fetch. It does fall
completely flat when shifting since shifting does not affect the original
data. Bug #177 reported by hokiel

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1530 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agorrdxport was completely broken for exporting datasources that did not have a uniform...
oetiker [Sat, 27 Sep 2008 11:44:58 +0000 (11:44 +0000)]
rrdxport was completely broken for exporting datasources that did not have a uniform step size. Thanks to Peter Valdemar Mørch for finding this.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1529 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agocreate the pid file before forking, so we can complain to stderr -- kevin brintnall
oetiker [Fri, 26 Sep 2008 05:11:32 +0000 (05:11 +0000)]
create the pid file before forking, so we can complain to stderr  --  kevin brintnall

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1528 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoThis patch ensures that the "FLUSH" command will write the updates out to
oetiker [Fri, 26 Sep 2008 05:10:25 +0000 (05:10 +0000)]
This patch ensures that the "FLUSH" command will write the updates out to
RRD before returning to the user.  Before, it returned when the update was
"dequeued"; updates were not necessarily on disk.

Also, for new nodes, the cache_lock is not held while we are setting up
the new node.  We don't want to be holding the lock if the stat() blocks.
--  kevin brintnal

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1527 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoUse the same IPv6/IPv4 as for the client as Florian did for the server -- kevin brintnall
oetiker [Thu, 25 Sep 2008 21:07:35 +0000 (21:07 +0000)]
Use the same IPv6/IPv4 as for the client as Florian did for the server -- kevin brintnall

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1526 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoThis fixes a couple problems when exiting due to signal:
oetiker [Thu, 25 Sep 2008 20:31:29 +0000 (20:31 +0000)]
This fixes a couple problems when exiting due to signal:

 * connection threads exit without closing client socket
   (so client blocks waiting for response that never comes)

 * listen_queue_thread blocks on poll() until a new connection comes in
   (because no poll timeout specified)

-- kevin brintnall

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1525 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoset SO_REUSEADDR on the listen socket -- kevin brintnall
oetiker [Thu, 25 Sep 2008 20:11:43 +0000 (20:11 +0000)]
set SO_REUSEADDR on the listen socket -- kevin brintnall

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1524 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoSupport for IPv6 has been broken with revision 1522: Because IPv6-addresses
oetiker [Thu, 25 Sep 2008 20:10:17 +0000 (20:10 +0000)]
Support for IPv6 has been broken with revision 1522: Because IPv6-addresses
contain colons, simply checking for a colon and using everything after it does
destroy correctly formatted IPv6-addresses.

This patch checks for dots '.' in the address. If the address contains at least
one dot, it is considered to be a hostname or an IPv4-address and a simple
search for a colon is done.

If no dot is found, the code will check for an opening square bracket '[' at
the beginning of the address. If one if found, the format
is assumed.

If neither applies, the default port will be used.
-- Florian Forster

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1523 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoThis adds support for <address>:<port> in the rrd client library.
oetiker [Thu, 25 Sep 2008 15:25:51 +0000 (15:25 +0000)]
This adds support for <address>:<port> in the rrd client library.
Obviously this is required to take advantage of the server's ability to
bind to a non-standard port -- kevin brintnall

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1522 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoAllow ports to be specified with -l addr:port also. -- kevin brintnall
oetiker [Wed, 24 Sep 2008 22:21:21 +0000 (22:21 +0000)]
Allow ports to be specified with -l addr:port also. --  kevin brintnall

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1521 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agothe rrdlua.pod is in the doc directory
oetiker [Wed, 24 Sep 2008 22:07:33 +0000 (22:07 +0000)]
the rrdlua.pod is in the doc directory

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1520 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoadded section on error reporting -- Florian Forster
oetiker [Wed, 24 Sep 2008 06:04:26 +0000 (06:04 +0000)]
added section on error reporting -- Florian Forster

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1519 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoI finally finished the first version of the patch (attached) -- Fidelis Assis fideli...
oetiker [Mon, 22 Sep 2008 06:35:26 +0000 (06:35 +0000)]
I finally finished the first version of the patch (attached) --  Fidelis Assis fidelis pobox.com
(this does not seem to quite work yet at least not in my hardy setup)

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1517 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agouse default prefix for ruby install if no user defined prefix is available
oetiker [Mon, 22 Sep 2008 05:38:28 +0000 (05:38 +0000)]
use default prefix for ruby install if no user defined prefix is available

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1515 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoBsd lirary path switch added to perl bindings makefile -- as suggested by Kevin Brintnall
oetiker [Fri, 19 Sep 2008 20:34:42 +0000 (20:34 +0000)]
Bsd lirary path switch added to perl bindings makefile -- as suggested by Kevin Brintnall

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1513 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoFix for debian bug 498183 ... never *advise after the end of the
oetiker [Thu, 18 Sep 2008 13:30:48 +0000 (13:30 +0000)]
Fix for debian bug 498183 ... never *advise after the end of the
file. On sparc this causes a segfault. Thanks to Sebastian Harl and Jurij Smakov for finding this.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1512 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agofix RRDCacheD documentation -- Florian Forster
oetiker [Sun, 14 Sep 2008 15:30:43 +0000 (15:30 +0000)]
fix RRDCacheD documentation -- Florian Forster

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1507 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoThe previous code was broken: The response was read using `read(2)'. If
oetiker [Sun, 14 Sep 2008 15:28:34 +0000 (15:28 +0000)]
The previous code was broken: The response was read using `read(2)'. If
the server wasn't sending fast enough, the client would stop reading
before the entire message had been read.

This patch changes the communication code to use the (line based)
`fgets' function rather than the lower level `read' function. After
reading the first line (which contains the total number of line to be
expected), this precise number of lines is read - blocking if necessary.

Also, the missing four new statistic values have been added to
--Folorian Forester

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1506 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agodid not pick up all the changes for rrdcached in the first round ... so here is the...
oetiker [Sun, 14 Sep 2008 10:35:51 +0000 (10:35 +0000)]
did not pick up all the changes for rrdcached in the first round ... so here is the second batch.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1505 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoRRDcached patch. This implements an infrastructure, where rrd updates can be
oetiker [Sun, 14 Sep 2008 09:49:03 +0000 (09:49 +0000)]
RRDcached patch. This implements an infrastructure, where rrd updates can be
sent to a daemon which caches them prior to bulk-updateing rrd files. See the rrdcached manual page.
-- Created by Florian Forster with some help from Kevin Brintnall.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1504 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoregarding #183:
oetiker [Sat, 13 Sep 2008 11:42:08 +0000 (11:42 +0000)]
regarding #183:
* move part of rrd_config.h out to a separate file, so that
  autoconf is not confused by the more complex expressions.
* fix configure variable name to allow caching
* another attemt at fixing solaris 2.8 compile so that it
  works out of the box.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1502 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agofix graph docs
oetiker [Sat, 13 Sep 2008 10:56:40 +0000 (10:56 +0000)]
fix graph docs

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1501 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agofixed processing of custom fonts René GARCIA <rene@margar.fr>
oetiker [Thu, 11 Sep 2008 20:27:47 +0000 (20:27 +0000)]
fixed processing of custom fonts René GARCIA <rene@margar.fr>

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1500 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agono , on the last member in C
oetiker [Thu, 11 Sep 2008 07:01:30 +0000 (07:01 +0000)]
no , on the last member in C

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1499 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoThe attached patch eliminates the many places where the rra_current pointer was maint...
oetiker [Sun, 7 Sep 2008 07:19:03 +0000 (07:19 +0000)]
The attached patch eliminates the many places where the rra_current pointer was maintained; the existing write/seek mechanisms update rrd_file->pos correctly.
Also, the seek at the front of process_arg is not necessary; write_to_rras will now take care to correct the file position at every update cycle.
This eliminates unnecessary rrd_seek() calls when MMAP is not enabled. -- kevin brintnall  kbrint rufus.net

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1488 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoprepare for the release of rrdtool-1.3.2
oetiker [Sat, 6 Sep 2008 14:24:43 +0000 (14:24 +0000)]
prepare for the release of rrdtool-1.3.2

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1484 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agowe need rrd_format.h here for things to compile properly
oetiker [Sat, 6 Sep 2008 11:46:41 +0000 (11:46 +0000)]
we need rrd_format.h here for things to compile properly

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1483 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoupdated opensolaris build instructions
oetiker [Sat, 6 Sep 2008 11:43:10 +0000 (11:43 +0000)]
updated opensolaris build instructions

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1482 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoonly link build and use rrd_getopt if there is no getopt_long provided by
oetiker [Sat, 6 Sep 2008 10:43:07 +0000 (10:43 +0000)]
only link build and use rrd_getopt if there is no getopt_long provided by
by the os ... this should also fix problems for solaris 2.8 and other
non getopt_long oses who were not taken care of anymore after the intriduction of librrd.sym

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1481 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agofix for multi update - data corruption bug as reported (and patched) in #178 by kevin...
oetiker [Sat, 6 Sep 2008 10:39:29 +0000 (10:39 +0000)]
fix for multi update - data corruption bug as reported (and patched) in #178 by kevin brintnall

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1480 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agomake pod checker happy
oetiker [Sat, 6 Sep 2008 10:32:57 +0000 (10:32 +0000)]
make pod checker happy

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1479 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoinline functions are not supported in c99 ... lets remove this.
oetiker [Sat, 6 Sep 2008 08:58:18 +0000 (08:58 +0000)]
inline functions are not supported in c99 ... lets remove this.
the compiler will foture it out if they are important.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1478 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agointroduced a persistant fontmap ... this makes our pango rendering 6 times faster...
oetiker [Thu, 4 Sep 2008 21:45:44 +0000 (21:45 +0000)]
introduced a persistant fontmap ... this makes our pango rendering 6 times faster starting from the second graph we draw.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1477 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agonow the results actually look as they did with the old code only things are FASTER
oetiker [Sun, 31 Aug 2008 23:42:02 +0000 (23:42 +0000)]
now the results actually look as they did with the old code only things are FASTER

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1476 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoImprove performance by keeping multiple pango font descriptions. For the first invoca...
oetiker [Sun, 31 Aug 2008 22:53:49 +0000 (22:53 +0000)]
Improve performance by keeping multiple pango font descriptions. For the first invocation we are about 20% times as fast
for the second one about 4-5 times faster ...

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1475 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agotrying to improve the pango performance I added facilities to cache layout,context...
oetiker [Sun, 31 Aug 2008 10:55:24 +0000 (10:55 +0000)]
trying to improve the pango performance I added facilities to cache layout,context and more in between invocations of
the text function, unfortunately it does not seem to help all that much.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1474 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agouse the standart info free function
oetiker [Sun, 31 Aug 2008 10:52:49 +0000 (10:52 +0000)]
use the standart info free function

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1473 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agofix handling of error conditions in rrd_tool.c ... errno is not for detection, only...
oetiker [Thu, 28 Aug 2008 05:49:02 +0000 (05:49 +0000)]
fix handling of error conditions in rrd_tool.c ... errno is not for detection, only for information AFTER detection.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1471 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agofree the linebuffer if you don't return it!
oetiker [Thu, 28 Aug 2008 04:13:39 +0000 (04:13 +0000)]
free the linebuffer if you don't return it!

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1470 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agosome more leak plugging
oetiker [Wed, 27 Aug 2008 22:06:43 +0000 (22:06 +0000)]
some more leak plugging

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1469 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agodrop the dummy surface prior to creating the real one
oetiker [Wed, 27 Aug 2008 21:48:50 +0000 (21:48 +0000)]
drop the dummy surface prior to creating the real one

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1468 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoadded some freeing for error conditions
oetiker [Wed, 27 Aug 2008 21:46:01 +0000 (21:46 +0000)]
added some freeing for error conditions

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1467 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agofixed indentation ... gnu indent results are not realy beautifl. I might switch...
oetiker [Wed, 27 Aug 2008 21:25:43 +0000 (21:25 +0000)]
fixed indentation  ... gnu indent results are not realy beautifl. I might switch to uncrustify.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1466 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoMany rrd_create memory leaks patched ... based on valgrind analysis by Sven Engelhard...
oetiker [Wed, 27 Aug 2008 21:25:04 +0000 (21:25 +0000)]
Many rrd_create memory leaks patched ... based on valgrind analysis by Sven Engelhardt. Thanks!

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1465 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agofix indentation
oetiker [Wed, 27 Aug 2008 21:18:46 +0000 (21:18 +0000)]
fix indentation

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1464 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoadded sparc-sun-solaris2.8 to list of broken isfinite implementations
oetiker [Wed, 27 Aug 2008 06:52:33 +0000 (06:52 +0000)]
added  sparc-sun-solaris2.8 to list of broken isfinite implementations

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1463 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoit is rb_rrd_infocall not rrd_infocall ...
oetiker [Fri, 22 Aug 2008 22:04:37 +0000 (22:04 +0000)]
it is rb_rrd_infocall not rrd_infocall ...

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1462 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agoWhen in lazy mode, and the graph does not get regenerated, then there are no
oetiker [Sat, 16 Aug 2008 07:13:01 +0000 (07:13 +0000)]
When in lazy mode, and the graph does not get regenerated, then there are no
results from PRINT either. Fix for #163.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1461 a5681a0c-68f1-0310-ab6d-d61299d08faa

13 years agodocumentation updates
oetiker [Sat, 16 Aug 2008 07:11:46 +0000 (07:11 +0000)]
documentation updates

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1460 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agomake sure imageinfo only reports the filename and not the whole path. This is a regre...
oetiker [Tue, 12 Aug 2008 06:48:37 +0000 (06:48 +0000)]
make sure imageinfo only reports the filename and not the whole path. This is a regression from 1.2.x where this was implemented properly.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1459 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agoThe attached patch converts the given string to UTF-8 using glib's
oetiker [Mon, 4 Aug 2008 20:35:45 +0000 (20:35 +0000)]
The attached patch converts the given string to UTF-8 using glib's
g_locale_to_utf8() function. This function expects the string to be
encoded as specified by the locale settings, so this will fail if e.g.
you're using some script which is encoded in some way incompatible to
the locale settings. In this case, the patch falls back to use the
original string as provided by the user as there is no way to tell how
to interpret that string. So, in this case, you will still get the old
behavior (that pango warning and messed up strings in the graph).
However, imho this is perfectly fine since it should be up to the user
to take care of a sane environment. -- Sebastian Harl

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1457 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agonewer perlapi docu suggests to use SV * instead of void for managed returns
oetiker [Tue, 29 Jul 2008 14:42:08 +0000 (14:42 +0000)]
newer perlapi docu suggests to  use SV * instead of void for managed returns

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1456 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agofixed some c++ style lines -- David Masterson
oetiker [Tue, 29 Jul 2008 05:08:46 +0000 (05:08 +0000)]
fixed some c++ style lines -- David Masterson

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1455 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agospelling fix
oetiker [Mon, 28 Jul 2008 07:23:15 +0000 (07:23 +0000)]
spelling fix

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1454 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agoforward ported patch for rra cur_row randomization in rrd_restore from 1.2.28 to...
oetiker [Wed, 23 Jul 2008 15:03:43 +0000 (15:03 +0000)]
forward ported patch for rra cur_row randomization in rrd_restore from 1.2.28 to 1.3.1

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1453 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agoprepare for the release of rrdtool-1.3.1
oetiker [Wed, 23 Jul 2008 13:02:26 +0000 (13:02 +0000)]
prepare for the release of rrdtool-1.3.1

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1447 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agoadded support for restoring rrdtool 1.0.x files ... removed support for old HW patche...
oetiker [Wed, 23 Jul 2008 12:45:52 +0000 (12:45 +0000)]
added support for restoring rrdtool 1.0.x files ... removed support for old HW patched rrd format created by an early patched version of 1.0.x

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1446 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agoFix for #167 - rrdcreate is arguably missing a check for 'step>=1' for RRAs with...
oetiker [Tue, 22 Jul 2008 15:15:44 +0000 (15:15 +0000)]
Fix for #167 - rrdcreate is arguably missing a check for 'step>=1' for RRAs with AVERAGE as a CF. I ran into this when specifying 0.6 as a step value, assuming floats were also accepted. Patch attached here. -- Bogdan

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1445 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agoheader-fix
oetiker [Tue, 1 Jul 2008 06:35:54 +0000 (06:35 +0000)]

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1444 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agoimprove layout
oetiker [Tue, 1 Jul 2008 06:34:24 +0000 (06:34 +0000)]
improve layout

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1443 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agoadded rrd filename to illegal update message -- he at uninett.no
oetiker [Sun, 29 Jun 2008 16:23:50 +0000 (16:23 +0000)]
added rrd filename to illegal update message -- he at uninett.no

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1441 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agorrdtool.spec fix by Anton Blanchard to build without php patch
oetiker [Sun, 29 Jun 2008 14:08:51 +0000 (14:08 +0000)]
rrdtool.spec fix by Anton Blanchard to build without php patch

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1440 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agomake sure image-with and image-height get returned even when rrdtool is called with...
oetiker [Sun, 29 Jun 2008 13:57:00 +0000 (13:57 +0000)]
make sure image-with and image-height get returned even when rrdtool is called with --lazy as reported in bug #163

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1439 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agorrdtool.fetch is returning an extra, bogus, data point. Attached is a
oetiker [Thu, 19 Jun 2008 13:18:04 +0000 (13:18 +0000)]
rrdtool.fetch is returning an extra, bogus, data point.  Attached is a
patch to correct this. - Gilad Raphaelli. Fix for #161

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1436 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agoadded note on %S
oetiker [Thu, 12 Jun 2008 13:54:23 +0000 (13:54 +0000)]
added note on %S

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1435 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agomade news the same as the announcement
oetiker [Wed, 11 Jun 2008 15:49:24 +0000 (15:49 +0000)]
made news the same as the announcement

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1434 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agoprepare for the release of rrdtool-1.3.0
oetiker [Tue, 10 Jun 2008 23:12:55 +0000 (23:12 +0000)]
prepare for the release of rrdtool-1.3.0

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1432 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agooops it is 1.3.0 not 1.4.0 yet
oetiker [Tue, 10 Jun 2008 16:38:10 +0000 (16:38 +0000)]
oops it is 1.3.0 not 1.4.0 yet

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1428 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agopreparing for 1.3
oetiker [Tue, 10 Jun 2008 16:37:39 +0000 (16:37 +0000)]
preparing for 1.3

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1427 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agodocument the 'internal' functions in rrd.h but mark them as deprecated, so
oetiker [Tue, 10 Jun 2008 16:32:34 +0000 (16:32 +0000)]
document the 'internal' functions in rrd.h but mark them as deprecated, so
that anyone using them will see that they should not be doing it.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1426 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agoflip check for row_count with setting for better code logic
oetiker [Tue, 10 Jun 2008 11:16:40 +0000 (11:16 +0000)]
flip check for row_count with setting for better code logic

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1425 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agocheck row count in RRAs to be > 0 ... by Sebastian Harl
oetiker [Tue, 10 Jun 2008 09:35:03 +0000 (09:35 +0000)]
check row count in RRAs to be > 0 ... by Sebastian Harl

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1424 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agofor windows we must open files in O_BINARY mode
oetiker [Tue, 10 Jun 2008 07:18:02 +0000 (07:18 +0000)]
for windows we must open files in O_BINARY mode

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1423 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agodo NOT export lowlevel functions, since I have no intention supporting these
oetiker [Mon, 9 Jun 2008 16:10:39 +0000 (16:10 +0000)]
do NOT export lowlevel functions, since I have no intention supporting these
interfaces across versions. The symbols are in the library, so if someone
WANTS to code to them, they are free todo so, but they will have to use our
internal header files.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1421 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agoadd all lowlevel file access functions from the rrd_open interface to the export...
oetiker [Mon, 9 Jun 2008 15:49:54 +0000 (15:49 +0000)]
add all lowlevel file access functions from the rrd_open interface to the export list.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1420 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agofixed indenting
oetiker [Mon, 9 Jun 2008 05:12:27 +0000 (05:12 +0000)]
fixed indenting

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1419 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agoupdate to rpm spec from Jarod Wilson
oetiker [Mon, 9 Jun 2008 05:11:39 +0000 (05:11 +0000)]
update to rpm spec from Jarod Wilson

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1418 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agoexport some more symbols from librrd
oetiker [Sun, 8 Jun 2008 21:15:32 +0000 (21:15 +0000)]
export some more symbols from librrd

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1417 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agowindows should use a windows font
oetiker [Sun, 8 Jun 2008 21:06:35 +0000 (21:06 +0000)]
windows should use a windows font

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1416 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agodrop special case windows font code ... it makes no sense with the new setup
oetiker [Sun, 8 Jun 2008 21:05:50 +0000 (21:05 +0000)]
drop special case windows font code ... it makes no sense with the new setup

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1415 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agoprepare for the release of rrdtool-1.3rc9
oetiker [Sun, 8 Jun 2008 17:08:47 +0000 (17:08 +0000)]
prepare for the release of rrdtool-1.3rc9

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1413 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agofixed pango markup switch ... we still want the text to show even if no markup is...
oetiker [Sun, 8 Jun 2008 17:08:11 +0000 (17:08 +0000)]
fixed pango markup switch ... we still want the text to show even if no markup is enabled

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1412 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agorrd_freemem has to be exported as well ...
oetiker [Sun, 8 Jun 2008 16:47:22 +0000 (16:47 +0000)]
rrd_freemem has to be exported as well ...

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1411 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agofix for ticket #121 jmpbuf on aix is a problem it seems, maybe this makes it better.
oetiker [Sun, 8 Jun 2008 16:23:39 +0000 (16:23 +0000)]
fix for ticket #121 jmpbuf on aix is a problem it seems, maybe this makes it better.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1409 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agoprepare for the release of rrdtool-1.3rc8
oetiker [Sun, 8 Jun 2008 15:59:20 +0000 (15:59 +0000)]
prepare for the release of rrdtool-1.3rc8

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1407 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agoprepare for the release of rrdtool-1.3rc8
oetiker [Sun, 8 Jun 2008 15:55:54 +0000 (15:55 +0000)]
prepare for the release of rrdtool-1.3rc8

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1406 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agoFrom: Sebastian Harl sh tokkee.org
oetiker [Sun, 8 Jun 2008 15:55:09 +0000 (15:55 +0000)]
From: Sebastian Harl sh tokkee.org
Date: Sun, 8 Jun 2008 15:01:05 +0200
Subject: [PATCH] Cleanup the symbols exported by librrd.

Up to know librrd exported a lot of symbols, most of which are to be
regarded as private symbols. This somewhat pollutes the API as the symbols
could, in theory, be used by external software and, more importantly,
makes symbol based dependencies (as recently introduced in e.g. Debian)
somewhat harder to implement.

This patch does a somewhat large-scale cleanup of the exported symbols:

 * Introduced a librrd.sym file which contains all symbols that are to be
   exported. This file is then passed to libtool using the -export-symbols
   option which tells the linker to export the given symbols only (note:
   according to the libtool manual, this has no effect on some
   architectures - however, I assume that most architectures in use today
   do support it).

   librrd.sym contains all symbols originally defined in rrd.h sans
   LockRRD() (which has been moved to rrd_tool.h). The following functions
   have been added to rrd.h and the list of exported symbols (some of them
   have been renamed, see below):
   - rrd_info()
   - rrd_info_free()
   - rrd_info_print()
   - rrd_info_push()
   - rrd_lastupdate()
   - rrd_update_v()
   - rrd_strerror()

 * Prefixed all public functions and types with "rrd_" to avoid name
   clashes with other libraries. Also, while I was at it, I introduced
   typedefs for all custom types and prefixed the time names with "_t" to
   improve consistency:
   - enum info_type -> rrd_info_type_t
   - enum timetype -> rrd_timetype_t

   - union infoval -> rrd_infoval_t

   - struct info_t -> rrd_info_t
   - struct rrd_context -> rrd_context_t
   - struct rrd_time_value -> rrd_time_value_t

   - info_free() -> rrd_info_free()
   - info_free() -> rrd_info_free()
   - info_print() -> rrd_info_print()
   - info_push() -> rrd_info_push()
   - LockRRD() -> rrd_lock() (not public though)
   - parsetime() -> rrd_parsetime()
     (and: src/parsetime.c -> src/rrd_parsetime.c)
   - proc_start_end() -> rrd_proc_start_end()
   - set_to_DINF() -> rrd_set_to_DINF()
   - set_to_DNAN() -> rrd_set_to_DNAN()

 * Moved readfile() from rrd_open.c to rrd_cgi.c and declared it static.
   This function is used in rrd_cgi.c only.

 * rrd_lock() (f.k.a. LockRRD()) now accepts a rrd_file_t pointer instead
   of an integer to increase encapsulation.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1405 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agodon't bother with don't need when there is neither madvise not fadvise calls
oetiker [Sat, 7 Jun 2008 14:35:03 +0000 (14:35 +0000)]
don't bother with don't need when there is neither madvise not fadvise calls

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1404 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agofix for --font bug (font names wer not being picked up at all). Bug reported by ...
oetiker [Fri, 6 Jun 2008 16:38:25 +0000 (16:38 +0000)]
fix for --font bug (font names wer not being picked up at all). Bug reported by  Dmitry B. Bigunayk

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1403 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agoadded pango markup name
oetiker [Thu, 5 Jun 2008 20:56:24 +0000 (20:56 +0000)]
added pango markup name

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1402 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agofixed indenting
oetiker [Thu, 5 Jun 2008 19:59:18 +0000 (19:59 +0000)]
fixed indenting

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1401 a5681a0c-68f1-0310-ab6d-d61299d08faa

14 years agodisable pango markup by default. added --pango-markup option for explicit enablement.
oetiker [Thu, 5 Jun 2008 19:59:01 +0000 (19:59 +0000)]
disable pango markup by default. added --pango-markup option for explicit enablement.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1400 a5681a0c-68f1-0310-ab6d-d61299d08faa