10 years agosrc/rrd_graph.[ch]: Implemented the ":daemon=..." option for "DEF:" commands. ff/rrdc_fetch-graph
Florian Forster [Wed, 24 Feb 2010 16:29:12 +0000 (17:29 +0100)]
src/rrd_graph.[ch]: Implemented the ":daemon=..." option for "DEF:" commands.

Rather than calling "FLUSH" for each RRD file needed for drawing a
graph and then accessing the file directly, use the "FLUSH" command to
receive the data required for drawing a graph.

The daemon can now be specified in one of three ways:

  * A new option has been added to the "DEF" option. If the "DEF" command
    includes the option "daemon=...", then the given daemon is used for
    accessing that file only. This option takes precedence over all
    other options. The value given follows the same syntax as other ways
    to specify a daemon address, thouh colons need to be escaped from


  * The "--daemon" option can be given to the overall "rrdtool graph"
    command. When given, this address is used for all file accesses
    except those which explicitely contain a "daemon=..." option.

  * If the "RRDCACHED_ADDRESS" environment variable is set, it's value
    is used as the daemon address. This is the lowest priority option
    and only used if no other option is given.

One nice detail is that with ":daemon=...", the cache address can be
specified for each "DEF:" definition. It is therefore possible to graph
values stored on several servers in one graph – even if several RRD
files have the same name.

10 years agosrc/rrd_format.c: Implemented "cf_to_string".
Florian Forster [Wed, 24 Feb 2010 15:53:06 +0000 (16:53 +0100)]
src/rrd_format.c: Implemented "cf_to_string".

A simple helper function to turn an "enum cf_en" to a string. The returned
pointer points to static memory and doesn't need to be freed.

10 years agoRRDCacheD: Add the "FETCH" command. ff/rrdc_fetch
Florian Forster [Wed, 24 Feb 2010 16:34:41 +0000 (17:34 +0100)]
RRDCacheD: Add the "FETCH" command.

Add a "FETCH" command to RRDCacheD which behaves like a (simplified
version of) rrdfetch(1).

This has advantages over calling "FLUSH" from within the "client",
especially if the daemon is accessed using a network socket. For one, it
makes it easy to separate collecting and storing of data on one side and
creating graphs on another, possibly more public server. Without this
command this is only possible using networked file systems and similar

When talking to an instance of RRDCacheD via a network socket, only
relative pathnames are allowed. If the RRD file is to be accessed
afterwards (why else would one call "FLUSH"?), the client has to be in a
specific directory so the *same* relative path can be used. If the file
is on a share mounted via the network, the required CWD may differ from
the CWD of the server, making developing and deploying solutions using
separated storing and graphing unnecessarily hard.

The data can be accessed using "rrdc_fetch" which should be a drop-in
replacement for "rrd_fetch_r". This makes it easy for programs using the
RRDtool C API to use this new functionality.

10 years agoreset rrd_state for grapv in ruby bindings -- Sven Engelhardt
oetiker [Tue, 16 Feb 2010 13:04:18 +0000 (13:04 +0000)]
reset rrd_state for grapv in ruby bindings -- Sven Engelhardt

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2022 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agomake sure we only use _NL_TIME_WEEK_1STDAY if we actually have it ... thanks kevin...
oetiker [Sat, 13 Feb 2010 11:30:17 +0000 (11:30 +0000)]
make sure we only use _NL_TIME_WEEK_1STDAY if we actually have it ... thanks kevin for the report

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2020 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agouse _NL_TIME_WEEK_1STDAY to determin the first day of the week.
oetiker [Sun, 7 Feb 2010 19:55:47 +0000 (19:55 +0000)]
use _NL_TIME_WEEK_1STDAY to determin the first day of the week.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2018 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agouse locale information from LC_TIME first_weekday to determine if the week should...
oetiker [Sun, 7 Feb 2010 19:48:01 +0000 (19:48 +0000)]
use locale information from LC_TIME first_weekday to determine if the week should start sunday or monday.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2017 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agonew rb_rrd_xport function for ruby bindings. -- Pavel Pachkovskij pavel.pachkovskij...
oetiker [Fri, 5 Feb 2010 18:28:41 +0000 (18:28 +0000)]
new rb_rrd_xport function for ruby bindings. -- Pavel Pachkovskij pavel.pachkovskij azati.com

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2016 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agomake sure that (argv-1)[0] points to something sensible ... hack to undo the damage...
oetiker [Tue, 2 Feb 2010 17:07:20 +0000 (17:07 +0000)]
make sure that (argv-1)[0] points to something sensible ... hack to undo the damage caused by a sensless optimization. see bug #251

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2013 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoadd 'u' to backup one line for special legend placement tricks
oetiker [Mon, 25 Jan 2010 22:25:14 +0000 (22:25 +0000)]
add 'u' to backup one line for special legend placement tricks

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2012 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agofix right aligned text
oetiker [Mon, 25 Jan 2010 22:09:23 +0000 (22:09 +0000)]
fix right aligned text

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2011 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoadd online documentation for --pango-markup switch
oetiker [Mon, 25 Jan 2010 20:46:14 +0000 (20:46 +0000)]
add online documentation for --pango-markup switch

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2010 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoAttached patch passes DESTDIR to setup.py as --root=<DESTDIR> iff a DESTDIR was given...
oetiker [Thu, 21 Jan 2010 13:42:48 +0000 (13:42 +0000)]
Attached patch passes DESTDIR to setup.py as --root=<DESTDIR> iff a DESTDIR was given. Bernhard Reutner-Fischer

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2006 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoonly draw the new type of marker in the graph legend when called with --dynamic-label...
oetiker [Wed, 20 Jan 2010 19:47:04 +0000 (19:47 +0000)]
only draw the new type of marker in the graph legend when called with --dynamic-labels -- tobi

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2005 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoadd a timeout to the ms_async timestamp updating issue since this test was reported...
oetiker [Fri, 15 Jan 2010 06:57:18 +0000 (06:57 +0000)]
add a timeout to the ms_async timestamp updating issue since this test was reported to hang while sync was called.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2003 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agofix cairo version
oetiker [Fri, 15 Jan 2010 06:56:40 +0000 (06:56 +0000)]
fix cairo version

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2002 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agonew (better) checker for incoming COUNTER or DERIVED data. thanks Florian!
oetiker [Thu, 14 Jan 2010 13:01:43 +0000 (13:01 +0000)]
new (better) checker for incoming COUNTER or DERIVED data. thanks Florian!

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2001 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agore-fix #243 checking for '\0' made the whole check pointless. Now it should actually...
oetiker [Thu, 14 Jan 2010 12:56:59 +0000 (12:56 +0000)]
re-fix #243 checking for '\0' made the whole check pointless. Now it should actually catch bad input.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@2000 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agosizeof(time_t) is 4 byte not 32 bit ...
oetiker [Mon, 11 Jan 2010 09:49:44 +0000 (09:49 +0000)]
sizeof(time_t) is 4 byte not 32 bit ...

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1999 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agowe are using a comparison with sizeof(long) to figure the size of time_t this is...
oetiker [Mon, 11 Jan 2010 09:06:59 +0000 (09:06 +0000)]
we are using a comparison with sizeof(long) to figure the size of time_t this is unfortunate
since on freebsd in 64bit mode time_t is 32 bit while long is 64 bit

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1997 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoThe end of the export range should not be adjusted DOWN but UP to hit the next matchi...
oetiker [Mon, 11 Jan 2010 08:11:19 +0000 (08:11 +0000)]
The end of the export range should not be adjusted DOWN but UP to hit the next matching step interval or the response will be one row short. Thanks swami for the bugreport.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1996 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agothe end time itself is not part of a time range ... this fixes the segfault reported...
oetiker [Sat, 2 Jan 2010 16:33:26 +0000 (16:33 +0000)]
the end time itself is not part of a time range ... this fixes the segfault reported in #248

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1995 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoteach rrd_restore to be able to read the #text value of <a></a> ... this fixes proble...
oetiker [Sun, 20 Dec 2009 12:15:06 +0000 (12:15 +0000)]
teach rrd_restore to be able to read the #text value of <a></a> ... this fixes problems with
blank last_ds entries ... as reported in #247.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1992 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agodo not build
oetiker [Wed, 9 Dec 2009 15:00:43 +0000 (15:00 +0000)]
do not build

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1990 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoyet another try to get the rpn example right ... #246
oetiker [Tue, 8 Dec 2009 08:56:06 +0000 (08:56 +0000)]
yet another try to get the rpn example right ... #246

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1986 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agofix spacing
oetiker [Thu, 3 Dec 2009 23:32:30 +0000 (23:32 +0000)]
fix spacing

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1985 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agothis one proofes difficult to fix ... :-) another try ...
oetiker [Mon, 30 Nov 2009 07:18:10 +0000 (07:18 +0000)]
this one proofes difficult to fix ... :-) another try ...

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1984 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoits 7000 not 700 ... fix for #246 again
oetiker [Mon, 30 Nov 2009 07:17:02 +0000 (07:17 +0000)]
its 7000 not 700 ... fix for #246 again

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1983 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoadd 0,7000 to fix #246
oetiker [Mon, 30 Nov 2009 07:13:25 +0000 (07:13 +0000)]
add 0,7000 to fix #246

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1982 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agouse puts("x") instead of fputs("x\n",stdout) -- Bernhard Reutner-Fischer
oetiker [Wed, 18 Nov 2009 22:01:46 +0000 (22:01 +0000)]
use puts("x") instead of fputs("x\n",stdout) -- Bernhard Reutner-Fischer

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1977 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoremove duplicate help text -- Bernhard Reutner-Fischer
oetiker [Wed, 18 Nov 2009 12:45:52 +0000 (12:45 +0000)]
remove duplicate help text -- Bernhard Reutner-Fischer

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1976 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agobe more diligent in checking the input arguments for rrdtool update and complain...
oetiker [Mon, 16 Nov 2009 14:59:51 +0000 (14:59 +0000)]
be more diligent in checking the input arguments for rrdtool  update and complain if they are wrong. fix for #243 (and more)
--This line, and those below, will be ignored-

M    trunk/program/src/rrd_update.c
M    branches/1.3/program/src/rrd_update.c

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1973 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoprepare for the release of rrdtool-1.4.2
oetiker [Sun, 15 Nov 2009 11:54:23 +0000 (11:54 +0000)]
prepare for the release of rrdtool-1.4.2

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1970 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agofix pod syntax
oetiker [Sun, 15 Nov 2009 11:53:56 +0000 (11:53 +0000)]
fix pod syntax

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1969 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoSwitch LC_NUMERIC to C prior to creating rrd_xport output. This makes sure that numbe...
oetiker [Sun, 15 Nov 2009 10:51:10 +0000 (10:51 +0000)]
Switch LC_NUMERIC to C prior to creating rrd_xport output. This makes sure that numbers are always output with a . and not with a ,

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1968 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoclarify rrd_daemon code with JOURNAL_REPLAY macro -- kevin
oetiker [Fri, 30 Oct 2009 22:49:50 +0000 (22:49 +0000)]
clarify rrd_daemon code with JOURNAL_REPLAY macro -- kevin

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1967 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoprepare for the release of rrdtool-1.4.1
oetiker [Wed, 28 Oct 2009 05:15:17 +0000 (05:15 +0000)]
prepare for the release of rrdtool-1.4.1

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1963 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoupdated versions to account for rrd cached fix
oetiker [Wed, 28 Oct 2009 05:15:04 +0000 (05:15 +0000)]
updated versions to account for rrd cached fix

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1962 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoAvoid unnecessary string handling for UPDATE commands in rrd_deaemon for 20x
oetiker [Wed, 28 Oct 2009 05:14:03 +0000 (05:14 +0000)]
Avoid unnecessary string handling for UPDATE commands in rrd_deaemon for 20x
speed increasse. Only copy as many bytes as necessary. During journal
replay, avoid unnecessary copy (string is discarded). Bug reported by
Thorsten von Eicken Patched by kevin brintnall

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1961 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agowe have 2009 now
oetiker [Tue, 27 Oct 2009 21:44:09 +0000 (21:44 +0000)]
we have 2009 now

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1959 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoadded links to documentation
oetiker [Tue, 27 Oct 2009 21:40:09 +0000 (21:40 +0000)]
added links to documentation

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1958 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoset version to 1.4.0 for all files
oetiker [Tue, 27 Oct 2009 17:55:25 +0000 (17:55 +0000)]
set version to 1.4.0 for all files

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1957 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agocreate build script for 1.4 release
oetiker [Tue, 27 Oct 2009 17:51:06 +0000 (17:51 +0000)]
create build script for 1.4 release

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1956 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years ago* remove intl from build process ... someone who does actually need it should fix...
oetiker [Tue, 27 Oct 2009 17:49:29 +0000 (17:49 +0000)]
* remove intl from build process ... someone who does actually need it should fix this ...
* make the code work on solaris 10 (tested on opencsw server farm. thanks!)

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1955 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agomore solaris 10 portability changes ....
oetiker [Tue, 27 Oct 2009 17:04:03 +0000 (17:04 +0000)]
more solaris 10 portability changes ....

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1954 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoremove HAVE_LOCALE_H and HAVE_TIME_H and HAVE_SETLOCALE since they have not been...
oetiker [Tue, 27 Oct 2009 16:18:43 +0000 (16:18 +0000)]
remove HAVE_LOCALE_H and HAVE_TIME_H and HAVE_SETLOCALE since they have not been used consistantly anyway

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1953 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoif we use HAVE_TIME_H we should have a check for this in configure ...
oetiker [Tue, 27 Oct 2009 16:12:32 +0000 (16:12 +0000)]
if we use HAVE_TIME_H we should have a check for this in configure ...

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1952 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoupdated for 1.4 release
oetiker [Tue, 27 Oct 2009 13:57:59 +0000 (13:57 +0000)]
updated for 1.4 release

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1951 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agosimplify rrd_graph LC_NUMERIC fix so that all call paramters are affected by it.
oetiker [Tue, 27 Oct 2009 13:54:33 +0000 (13:54 +0000)]
simplify rrd_graph LC_NUMERIC fix so that all call paramters are affected by it.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1950 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoallow the grid on:off pattern to be configured
oetiker [Tue, 27 Oct 2009 13:13:37 +0000 (13:13 +0000)]
allow the grid on:off pattern to be configured

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1949 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoneeds locale.h to compile
oetiker [Tue, 27 Oct 2009 13:07:25 +0000 (13:07 +0000)]
needs locale.h to  compile

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1948 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agooptional software is expected to live in /opt, so lets follow this custom ... /usr...
oetiker [Fri, 23 Oct 2009 15:58:10 +0000 (15:58 +0000)]
optional software is expected to live in /opt, so lets follow this custom ... /usr/local is really old school.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1945 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agofix memory handling when argument separation in pipe mode fails. fix for #230
oetiker [Thu, 22 Oct 2009 23:22:23 +0000 (23:22 +0000)]
fix memory handling when argument separation in pipe mode fails. fix for #230

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1944 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoset locale to C while restoring
oetiker [Tue, 20 Oct 2009 19:23:49 +0000 (19:23 +0000)]
set locale to C while restoring

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1939 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoanother typo fixed by Justin T Pryzby
oetiker [Thu, 15 Oct 2009 08:42:31 +0000 (08:42 +0000)]
another typo fixed by Justin T Pryzby

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1938 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoRemoved left-over occurrence of LIB_LIBINTL -- sebastian
oetiker [Thu, 15 Oct 2009 04:47:55 +0000 (04:47 +0000)]
Removed left-over occurrence of LIB_LIBINTL -- sebastian

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1937 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoFixed various typos in the manpages. Debian bug #550919. -- Justin T. Pryzby
oetiker [Wed, 14 Oct 2009 08:04:59 +0000 (08:04 +0000)]
Fixed various typos in the manpages. Debian bug #550919. -- Justin T. Pryzby

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1936 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoload rrd_config.h before rrd_client.h since its content is expected to be present...
oetiker [Sun, 11 Oct 2009 16:00:14 +0000 (16:00 +0000)]
load rrd_config.h before rrd_client.h since its content is expected to be present  -- Florian Forster

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1935 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoFix potential memory leak in rrd_flushcached during failure. -- kevin
oetiker [Sun, 4 Oct 2009 21:16:34 +0000 (21:16 +0000)]
Fix potential memory leak in rrd_flushcached during failure. -- kevin

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1934 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agosebastian was missing from the contributors list
oetiker [Sun, 4 Oct 2009 12:18:03 +0000 (12:18 +0000)]
sebastian was missing from the contributors list

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1933 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoDo not mess with the locale settings. The main program takes care of that (rrd_tool...
oetiker [Sun, 4 Oct 2009 12:00:23 +0000 (12:00 +0000)]
Do not mess with the locale settings. The main program takes care of that (rrd_tool.c calls setlocale(LC_ALL,"") already.
We do call setlocale on LC_NUMERIC a few times to get predictable number formats when parsing strings into floats, but apart from that the code is
written in a portable manner and can take whatever the local system supports.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1932 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years ago* comment on the reson for calling setlocale
oetiker [Sun, 4 Oct 2009 11:48:40 +0000 (11:48 +0000)]
* comment on the reson for calling setlocale
* to not force the message encoding ... messages
  should be encoded in the current locale

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1931 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agorrd_client, rrd_daemon: Do not require hostnames to contain a dot.
oetiker [Sun, 4 Oct 2009 11:37:25 +0000 (11:37 +0000)]
rrd_client, rrd_daemon: Do not require hostnames to contain a dot.
Non-FQDN (e.g. "localhost") are now supported as well. Anything that does not
start with '[' should be (and is now) treated as <name>[:<port>]. -- Sebastian Harl

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1930 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agorrd_client: Improved error handling / reporting.
oetiker [Sun, 4 Oct 2009 11:36:20 +0000 (11:36 +0000)]
rrd_client: Improved error handling / reporting.

 * Report getaddrinfo() errors using gai_strerror().
 * Replaced "Internal error" with a more verbose error message, if available.

-- Sebastian Harl

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1929 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agorrd_client: Do not rewrite path names when accessing remote daemons.
oetiker [Sun, 4 Oct 2009 11:35:02 +0000 (11:35 +0000)]
rrd_client: Do not rewrite path names when accessing remote daemons.

When talking to a local daemon (thru a UNIX socket), relative path names are
resolved to absolute path names to allow for transparent integration into
existing solutions (as requested by Tobi).

However, when talking to a remote daemon, absolute path names are not allowed,
since path name translation is done by the server (relative to the base
directory). -- Sebastian Harl

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1928 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agorrdflushcached: Do not free 'opt_daemon' before checking the connection. -- Sebastian...
oetiker [Sun, 4 Oct 2009 11:34:00 +0000 (11:34 +0000)]
rrdflushcached: Do not free 'opt_daemon' before checking the connection. -- Sebastian Harl

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1927 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agorrdfetch: Print a usage summary if not enough parameters have been given. -- Sebastia...
oetiker [Sun, 4 Oct 2009 11:33:15 +0000 (11:33 +0000)]
rrdfetch: Print a usage summary if not enough parameters have been given. -- Sebastian Harl

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1926 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agorrdcached: Handle journal replay in socket_permission_check(). -- Sebastian Harl
oetiker [Sun, 4 Oct 2009 11:32:18 +0000 (11:32 +0000)]
rrdcached: Handle journal replay in socket_permission_check(). --  Sebastian Harl

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1925 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agorrdcached: Create the base directory on startup. -- Sebastian Harl
oetiker [Sun, 4 Oct 2009 11:30:24 +0000 (11:30 +0000)]
rrdcached: Create the base directory on startup. -- Sebastian Harl

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1924 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agorrdcached: Improved the "base-dir symlink check".
oetiker [Sun, 4 Oct 2009 11:29:40 +0000 (11:29 +0000)]
rrdcached: Improved the "base-dir symlink check".
The daemon checks if the specified base directory contains symlinks by
comparing the canonicalized path name (by realpath()) with the path name
specified on the command line. The GNU libc's implementation of realpath()
removed trailing slashes ('/') from the pathname. Thus, specifying a base
directory with a trailing slash results in rrdcached aborting, complaining
about an invalid base directory, which is quite annoying imho. Now, trailing
slashes are removed before comparing the two path names. --  Sebastian Harl

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1923 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agorrdcached: Improved an error message. -- Sebastian Harl
oetiker [Sun, 4 Oct 2009 11:28:43 +0000 (11:28 +0000)]
rrdcached: Improved an error message. -- Sebastian Harl

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1922 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agorrdcached: Create the pidfile and (UNIX) socket directories as well.
oetiker [Sun, 4 Oct 2009 11:27:44 +0000 (11:27 +0000)]
rrdcached: Create the pidfile and (UNIX) socket directories as well.
Those files may be located in a subdirectory of, e.g., /var/run/. To avoid the
need to manually create (and recreate, e.g. in case /var/run/ is on a tmpfs)
that subdirectory, let the daemon handle the creation of those directories. -- Sebastian Harl

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1921 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agorrd_fetch_libdbi: Fixed some compiler warnings. While at it, declared some private...
oetiker [Thu, 1 Oct 2009 18:54:13 +0000 (18:54 +0000)]
rrd_fetch_libdbi: Fixed some compiler warnings. While at it, declared some private helper functions as static. -- Sebastian Harl

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1920 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoMoved rrd_dump_cb_r() to section "CORE FUNCTIONS" since this is not a utility functio...
oetiker [Mon, 28 Sep 2009 16:21:13 +0000 (16:21 +0000)]
Moved rrd_dump_cb_r() to section "CORE FUNCTIONS" since this is not a utility function but rather part of RRDtool's core. -- Sebastian Harl

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1918 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoMoved the 'librrd' manpage to section 3 -- Sebastian Harl
oetiker [Mon, 28 Sep 2009 16:16:59 +0000 (16:16 +0000)]
Moved the 'librrd' manpage to section 3 -- Sebastian Harl

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1917 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agodocumentation for rrd_mkdir_p added -- Sebastian Harl
oetiker [Mon, 28 Sep 2009 16:16:35 +0000 (16:16 +0000)]
documentation for rrd_mkdir_p added -- Sebastian Harl

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1916 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agofree config_pid_file after using it for the last time ... Else, the daemon might...
oetiker [Mon, 28 Sep 2009 16:16:09 +0000 (16:16 +0000)]
free config_pid_file after using it for the last time ... Else, the daemon might either segfault or leave the PID file around. -- Sebastian Harl

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1915 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agotry to create missing journal directories rather than abort with an error. -- Sebasti...
oetiker [Mon, 28 Sep 2009 16:15:13 +0000 (16:15 +0000)]
try to create missing journal directories rather than abort with an error. -- Sebastian Harl

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1914 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoadded rrd_mkdir_p - This function may be used to recursively create some directory...
oetiker [Mon, 28 Sep 2009 16:13:58 +0000 (16:13 +0000)]
added rrd_mkdir_p - This function may be used to recursively create some directory, similar to
"mkdir -p" on the command-line. --  Sebastian Harl

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1913 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoadjusted copyright wording according to sebastians suggestions
oetiker [Thu, 24 Sep 2009 19:21:06 +0000 (19:21 +0000)]
adjusted copyright wording according to sebastians suggestions

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1912 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoshow element type in legend
oetiker [Tue, 1 Sep 2009 08:49:11 +0000 (08:49 +0000)]
show element type in legend

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1907 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agodetect if stdint.h is available. if not, use inttypes. this should fix #239 and make...
oetiker [Tue, 25 Aug 2009 09:01:16 +0000 (09:01 +0000)]
detect if stdint.h is available. if not, use inttypes. this should fix #239 and make compilation on solaris 9 work.

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1906 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoreplae with pointer
oetiker [Mon, 24 Aug 2009 12:04:05 +0000 (12:04 +0000)]
replae with pointer

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1905 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agocall fpclass only once when replacing isnan for solaris
oetiker [Mon, 24 Aug 2009 12:02:32 +0000 (12:02 +0000)]
call fpclass only once when replacing isnan for solaris

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1904 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoremove misspellt keyword ...
oetiker [Sat, 22 Aug 2009 22:03:00 +0000 (22:03 +0000)]
remove misspellt keyword ...

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1903 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agomake sure all elements required in the definition of isinf are defined in their turn
oetiker [Fri, 21 Aug 2009 05:03:40 +0000 (05:03 +0000)]
make sure all elements required in the definition of isinf are defined in their turn

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1902 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoTrim trailing whitespace, reoder getopt_long per shortopt char; Fix -D while at it
oetiker [Thu, 20 Aug 2009 22:02:22 +0000 (22:02 +0000)]
Trim trailing whitespace, reoder getopt_long per shortopt char; Fix -D while at it
-- Bernhard Reutner-Fischer

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1899 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoThe attached patch allows to
oetiker [Wed, 19 Aug 2009 15:24:11 +0000 (15:24 +0000)]
The attached patch allows to
$ rrdtool graph --border=0

to disable the 3d border around the image. -- Bernhard Reutner-Fischer rep.dot.nop gmail.com

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1898 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoyes this should not matter, but I think it is the right thing todo ...
oetiker [Wed, 19 Aug 2009 07:44:34 +0000 (07:44 +0000)]
yes this should not matter, but I think it is the right thing todo ...

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1895 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoadded missing prototypes
oetiker [Mon, 17 Aug 2009 21:34:57 +0000 (21:34 +0000)]
added missing prototypes

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1894 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoAdded a call back interface to rrd_dump to be able to call the function from c. See...
oetiker [Mon, 17 Aug 2009 21:31:02 +0000 (21:31 +0000)]
Added a call back interface to rrd_dump to be able to call the function from c. See librrd.pod for documentation.
-- Benny Baumann BenBE geshi.org

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1893 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoFrom: Florian Forster <octo@leeloo.lan.home.verplant.org>
oetiker [Sun, 16 Aug 2009 22:22:26 +0000 (22:22 +0000)]
From: Florian Forster <octo@leeloo.lan.home.verplant.org>

This patch introduces per-socket, per-command permissions to the RRD
caching daemon, RRDCacheD. This allows administrators to limit access to
the daemon in a fine-grained manner.

The patch removes the command line option `-L' and introduces `-P'
instead. The option must appear *before* the `-l' option and the given
permissions are set for all following sockets or another `-P' option.

For example:

  rrdcached -P FLUSH,PENDING -l -P UPDATE -l unix:/some/path

Allow `FLUSH' and `PENDING' commands to clients connected via IPv4
networking and `UPDATE' to clients connected via a UNIX domain socket

There are a couple of exceptions:

  - The commands `HELP' and `QUIT' are always allowed.
  - If the command `BATCH' is allowed, the command `.' is automatically
    allowed, too.

By default, i. e. if no `-P' option is specified, all commands will be
allowed. As a shortcut to reset the behavior to the default behavior,
you can use the slightly hackish `-P ""' syntax.

Signed-off-by: Florian Forster <octo@leeloo.lan.home.verplant.org>
git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1892 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agowith my Debian Testing box I had to apply the following small changes to
oetiker [Sun, 16 Aug 2009 22:05:14 +0000 (22:05 +0000)]
with my Debian Testing box I had to apply the following small changes to
the `configure.ac' file in order to make `autoconf' happy. Don't know
what the problem precisely is ? m4 and its square parenthesis is too
high for me ;) -- Florian

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1891 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agothere is no config directory ... so lets not search for it in autogen.sh
oetiker [Sun, 16 Aug 2009 22:00:03 +0000 (22:00 +0000)]
there is no config directory ... so lets not search for it in autogen.sh

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1890 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agofix freeing order when generating error messages. found by Dmitry V. Krivenok
oetiker [Tue, 11 Aug 2009 14:00:57 +0000 (14:00 +0000)]
fix freeing order when generating error messages. found by Dmitry V. Krivenok

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1889 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoinclude math.h when testing IEEE
oetiker [Mon, 10 Aug 2009 11:47:18 +0000 (11:47 +0000)]
include math.h when testing IEEE

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1887 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoremove extra \ in perl example
oetiker [Sat, 8 Aug 2009 14:06:25 +0000 (14:06 +0000)]
remove extra \ in perl example

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1886 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoThe journal files are time-stamped and replayed in order. This allows
oetiker [Sat, 8 Aug 2009 09:38:48 +0000 (09:38 +0000)]
The journal files are time-stamped and replayed in order.  This allows
systems with 32-bit signed off_t to write more than 2GB of journal entries
per flush interval. --kevin

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1885 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoadd some shell proggramming advice ... Bernhard Reutner-Fischer
oetiker [Sat, 8 Aug 2009 09:36:23 +0000 (09:36 +0000)]
add some shell proggramming advice ... Bernhard Reutner-Fischer

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1884 a5681a0c-68f1-0310-ab6d-d61299d08faa

10 years agoRemove PID file later in the cleanup process --kevin
oetiker [Sat, 8 Aug 2009 09:34:46 +0000 (09:34 +0000)]
Remove PID file later in the cleanup process --kevin

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1883 a5681a0c-68f1-0310-ab6d-d61299d08faa