From da01610763dd87294ae64a909093b41434cf50a4 Mon Sep 17 00:00:00 2001 From: oetiker Date: Sat, 21 Mar 2009 09:53:30 +0000 Subject: [PATCH] the call to rrd_flush has appeared when rrd_open was fleshed out. It used to be an fflush call which is something entirely different than the current rrd_flush implementation with fdatasync was ... we can safely drop this and gain performance for holt winters in the process ... -- tobi git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1760 a5681a0c-68f1-0310-ab6d-d61299d08faa --- src/rrd_hw.c | 2 +- src/rrd_open.c | 18 +----------------- 2 files changed, 2 insertions(+), 18 deletions(-) diff --git a/src/rrd_hw.c b/src/rrd_hw.c index 6f2c507..e6b23db 100644 --- a/src/rrd_hw.c +++ b/src/rrd_hw.c @@ -166,7 +166,7 @@ int apply_smoother( free(rrd_values); return -1; } - rrd_flush(rrd_file); + /* could read all data in a single block, but we need to * check for NA values */ for (i = 0; i < row_count; ++i) { diff --git a/src/rrd_open.c b/src/rrd_open.c index d2ec549..1654514 100644 --- a/src/rrd_open.c +++ b/src/rrd_open.c @@ -542,7 +542,7 @@ void rrd_dontneed( #if defined DEBUG && DEBUG > 1 mincore_print(rrd_file, "after"); #endif -#endif /* without madvise and posix_fadvise ist does not make much sense todo anything */ +#endif /* without madvise and posix_fadvise it does not make much sense todo anything */ } @@ -685,22 +685,6 @@ ssize_t rrd_write( } -/* flush all data pending to be written to FD. */ - -void rrd_flush( - rrd_file_t *rrd_file) -{ -#ifndef WIN32 - rrd_simple_file_t *rrd_simple_file; - rrd_simple_file = (rrd_simple_file_t *)rrd_file->pvt; - if (fdatasync(rrd_simple_file->fd) != 0) { - rrd_set_error("flushing fd %d: %s", rrd_simple_file->fd, - rrd_strerror(errno)); - } -#endif -} - - /* Initialize RRD header. */ void rrd_init( -- 2.11.0