From 8beeeba905826ff6cea39cdaaa71c1e6ea70d825 Mon Sep 17 00:00:00 2001 From: Tobias Markus Date: Mon, 23 Feb 2015 22:16:22 +0100 Subject: [PATCH] Fix coverity #29352 --- src/scripting/serialize.cpp | 4 ++-- src/scripting/squirrel_util.cpp | 11 ++++++----- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/src/scripting/serialize.cpp b/src/scripting/serialize.cpp index ff3c859bc..ccbfd2052 100644 --- a/src/scripting/serialize.cpp +++ b/src/scripting/serialize.cpp @@ -99,8 +99,8 @@ void save_squirrel_table(HSQUIRRELVM vm, SQInteger table_idx, Writer& writer) } case OT_BOOL: { SQBool val; - sq_getbool(vm, -1, &val); - writer.write(key, val == SQTrue); + if(SQ_SUCCEEDED(sq_getbool(vm, -1, &val))) + writer.write(key, val == SQTrue); break; } case OT_STRING: { diff --git a/src/scripting/squirrel_util.cpp b/src/scripting/squirrel_util.cpp index 5fd15b42d..46cb6c7bc 100644 --- a/src/scripting/squirrel_util.cpp +++ b/src/scripting/squirrel_util.cpp @@ -37,11 +37,12 @@ std::string squirrel2string(HSQUIRRELVM v, SQInteger i) break; case OT_BOOL: { SQBool p; - sq_getbool(v, i, &p); - if (p) - os << "true"; - else - os << "false"; + if SQ_SUCCEEDED(sq_getbool(v, i, &p)) { + if (p) + os << "true"; + else + os << "false"; + } break; } case OT_INTEGER: { -- 2.11.0