projects
/
collectd.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Merge branch 'collectd-4.7'
[collectd.git]
/
src
/
dns.c
diff --git
a/src/dns.c
b/src/dns.c
index
d82cbd8
..
8a2e87e
100644
(file)
--- a/
src/dns.c
+++ b/
src/dns.c
@@
-19,6
+19,8
@@
* Florian octo Forster <octo at verplant.org>
**/
* Florian octo Forster <octo at verplant.org>
**/
+#define _BSD_SOURCE
+
#include "collectd.h"
#include "common.h"
#include "plugin.h"
#include "collectd.h"
#include "common.h"
#include "plugin.h"
@@
-47,9
+49,10
@@
static const char *config_keys[] =
{
"Interface",
"IgnoreSource",
{
"Interface",
"IgnoreSource",
- NULL
+ "SelectNumericQueryTypes"
};
};
-static int config_keys_num = 2;
+static int config_keys_num = STATIC_ARRAY_SIZE (config_keys);
+static int select_numeric_qtype = 1;
#define PCAP_SNAPLEN 1460
static char *pcap_device = NULL;
#define PCAP_SNAPLEN 1460
static char *pcap_device = NULL;
@@
-156,6
+159,13
@@
static int dns_config (const char *key, const char *value)
if (value != NULL)
ignore_list_add_name (value);
}
if (value != NULL)
ignore_list_add_name (value);
}
+ else if (strcasecmp (key, "SelectNumericQueryTypes") == 0)
+ {
+ if ((value != NULL) && IS_FALSE (value))
+ select_numeric_qtype = 0;
+ else
+ select_numeric_qtype = 1;
+ }
else
{
return (-1);
else
{
return (-1);
@@
-169,13
+179,24
@@
static void dns_child_callback (const rfc1035_header_t *dns)
if (dns->qr == 0)
{
/* This is a query */
if (dns->qr == 0)
{
/* This is a query */
+ int skip = 0;
+ if (!select_numeric_qtype)
+ {
+ const char *str = qtype_str(dns->qtype);
+ if ((str == NULL) || (str[0] == '#'))
+ skip = 1;
+ }
+
pthread_mutex_lock (&traffic_mutex);
tr_queries += dns->length;
pthread_mutex_unlock (&traffic_mutex);
pthread_mutex_lock (&traffic_mutex);
tr_queries += dns->length;
pthread_mutex_unlock (&traffic_mutex);
- pthread_mutex_lock (&qtype_mutex);
- counter_list_add (&qtype_list, dns->qtype, 1);
- pthread_mutex_unlock (&qtype_mutex);
+ if (skip == 0)
+ {
+ pthread_mutex_lock (&qtype_mutex);
+ counter_list_add (&qtype_list, dns->qtype, 1);
+ pthread_mutex_unlock (&qtype_mutex);
+ }
}
else
{
}
else
{
@@
-195,7
+216,7
@@
static void dns_child_callback (const rfc1035_header_t *dns)
pthread_mutex_unlock (&opcode_mutex);
}
pthread_mutex_unlock (&opcode_mutex);
}
-static void *dns_child_loop (void *dummy)
+static void *dns_child_loop (void
__attribute__((unused))
*dummy)
{
pcap_t *pcap_obj;
char pcap_error[PCAP_ERRBUF_SIZE];
{
pcap_t *pcap_obj;
char pcap_error[PCAP_ERRBUF_SIZE];
@@
-211,8
+232,8
@@
static void *dns_child_loop (void *dummy)
}
/* Passing `pcap_device == NULL' is okay and the same as passign "any" */
}
/* Passing `pcap_device == NULL' is okay and the same as passign "any" */
- DEBUG ("Creating PCAP object..");
- pcap_obj = pcap_open_live (
pcap_device
,
+ DEBUG ("
dns plugin:
Creating PCAP object..");
+ pcap_obj = pcap_open_live (
(pcap_device != NULL) ? pcap_device : "any"
,
PCAP_SNAPLEN,
0 /* Not promiscuous */,
interval_g,
PCAP_SNAPLEN,
0 /* Not promiscuous */,
interval_g,