projects
/
collectd.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Merge pull request #1743 from rubenk/apcups-coverity
[collectd.git]
/
src
/
ntpd.c
diff --git
a/src/ntpd.c
b/src/ntpd.c
index
ce54e02
..
1071d0b
100644
(file)
--- a/
src/ntpd.c
+++ b/
src/ntpd.c
@@
-38,9
+38,6
@@
#if HAVE_NETDB_H
# include <netdb.h>
#endif
#if HAVE_NETDB_H
# include <netdb.h>
#endif
-#if HAVE_SYS_SOCKET_H
-# include <sys/socket.h>
-#endif
#if HAVE_NETINET_IN_H
# include <netinet/in.h>
#endif
#if HAVE_NETINET_IN_H
# include <netinet/in.h>
#endif
@@
-250,7
+247,7
@@
struct info_kernel
};
/* List of reference clock names */
};
/* List of reference clock names */
-static char *refclock_names[] =
+static c
onst c
har *refclock_names[] =
{
"UNKNOWN", "LOCAL", "GPS_TRAK", "WWV_PST", /* 0- 3 */
"SPECTRACOM", "TRUETIME", "IRIG_AUDIO", "CHU_AUDIO", /* 4- 7 */
{
"UNKNOWN", "LOCAL", "GPS_TRAK", "WWV_PST", /* 0- 3 */
"SPECTRACOM", "TRUETIME", "IRIG_AUDIO", "CHU_AUDIO", /* 4- 7 */
@@
-265,7
+262,7
@@
static char *refclock_names[] =
"JJY", "TT_IRIG", "GPS_ZYFER", "GPS_RIPENCC", /* 40-43 */
"NEOCLK4X" /* 44 */
};
"JJY", "TT_IRIG", "GPS_ZYFER", "GPS_RIPENCC", /* 40-43 */
"NEOCLK4X" /* 44 */
};
-static
in
t refclock_names_num = STATIC_ARRAY_SIZE (refclock_names);
+static
size_
t refclock_names_num = STATIC_ARRAY_SIZE (refclock_names);
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *
* End of the copied stuff.. *
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *
* End of the copied stuff.. *
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
@@
-310,7
+307,7
@@
static int ntpd_config (const char *key, const char *value)
return (0);
}
return (0);
}
-static void ntpd_submit (c
har *type,
char *type_inst, gauge_t value)
+static void ntpd_submit (c
onst char *type, const
char *type_inst, gauge_t value)
{
value_t values[1];
value_list_t vl = VALUE_LIST_INIT;
{
value_t values[1];
value_list_t vl = VALUE_LIST_INIT;
@@
-331,8
+328,8
@@
static void ntpd_submit (char *type, char *type_inst, gauge_t value)
/* Each time a peer is polled, ntpd shifts the reach register to the left and
* sets the LSB based on whether the peer was reachable. If the LSB is zero,
* the values are out of date. */
/* Each time a peer is polled, ntpd shifts the reach register to the left and
* sets the LSB based on whether the peer was reachable. If the LSB is zero,
* the values are out of date. */
-static void ntpd_submit_reach (c
har *type, char *type_inst, uint8_t reach
,
- gauge_t value)
+static void ntpd_submit_reach (c
onst char *type, const char *type_inst
,
+
uint8_t reach,
gauge_t value)
{
if (!(reach & 1))
value = NAN;
{
if (!(reach & 1))
value = NAN;
@@
-342,8
+339,8
@@
static void ntpd_submit_reach (char *type, char *type_inst, uint8_t reach,
static int ntpd_connect (void)
{
static int ntpd_connect (void)
{
- char *host;
- char *port;
+ c
onst c
har *host;
+ c
onst c
har *port;
struct addrinfo ai_hints;
struct addrinfo *ai_list;
struct addrinfo ai_hints;
struct addrinfo *ai_list;
@@
-666,7
+663,7
@@
static int ntpd_receive_response (int *res_items, int *res_size,
*/
DEBUG ("realloc (%p, %zu)", (void *) *res_data,
(items_num + pkt_item_num) * res_item_size);
*/
DEBUG ("realloc (%p, %zu)", (void *) *res_data,
(items_num + pkt_item_num) * res_item_size);
- items = realloc (
(void *)
*res_data,
+ items = realloc (*res_data,
(items_num + pkt_item_num) * res_item_size);
if (items == NULL)
{
(items_num + pkt_item_num) * res_item_size);
if (items == NULL)
{
@@
-868,7
+865,7
@@
static int ntpd_get_name_refclock (char *buffer, size_t buffer_size,
uint32_t refclock_id = ntpd_get_refclock_id (peer_info);
uint32_t unit_id = ntohl (peer_info->srcadr) & 0x00FF;
uint32_t refclock_id = ntpd_get_refclock_id (peer_info);
uint32_t unit_id = ntohl (peer_info->srcadr) & 0x00FF;
- if (
refclock_id
>= refclock_names_num)
+ if (
((size_t) refclock_id)
>= refclock_names_num)
return (ntpd_get_name_from_address (buffer, buffer_size,
peer_info,
/* do_reverse_lookup = */ 0));
return (ntpd_get_name_from_address (buffer, buffer_size,
peer_info,
/* do_reverse_lookup = */ 0));