projects
/
collectd.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
daemon: Check if plugin actually loaded before reporting configuration issues
[collectd.git]
/
src
/
varnish.c
diff --git
a/src/varnish.c
b/src/varnish.c
index
0d93993
..
f4c70af
100644
(file)
--- a/
src/varnish.c
+++ b/
src/varnish.c
@@
-26,8
+26,8
@@
#include "collectd.h"
#include "collectd.h"
-#include "common.h"
#include "plugin.h"
#include "plugin.h"
+#include "utils/common/common.h"
#if HAVE_VARNISH_V4 || HAVE_VARNISH_V5
#include <vapi/vsc.h>
#if HAVE_VARNISH_V4 || HAVE_VARNISH_V5
#include <vapi/vsc.h>
@@
-107,8
+107,8
@@
static int varnish_submit(const char *plugin_instance, /* {{{ */
if (plugin_instance == NULL)
plugin_instance = "default";
if (plugin_instance == NULL)
plugin_instance = "default";
- snprintf(vl.plugin_instance, sizeof(vl.plugin_instance), "%s-%s",
- plugin_instance, category);
+ s
s
nprintf(vl.plugin_instance, sizeof(vl.plugin_instance), "%s-%s",
+
plugin_instance, category);
sstrncpy(vl.type, type, sizeof(vl.type));
sstrncpy(vl.type, type, sizeof(vl.type));
@@
-1480,45
+1480,45
@@
static int varnish_config_apply_default(user_config_t *conf) /* {{{ */
if (conf == NULL)
return EINVAL;
if (conf == NULL)
return EINVAL;
- conf->collect_backend =
1
;
- conf->collect_cache =
1
;
- conf->collect_connections =
1
;
+ conf->collect_backend =
true
;
+ conf->collect_cache =
true
;
+ conf->collect_connections =
true
;
#ifdef HAVE_VARNISH_V3
#ifdef HAVE_VARNISH_V3
- conf->collect_dirdns =
0
;
+ conf->collect_dirdns =
false
;
#endif
#endif
- conf->collect_esi =
0
;
- conf->collect_fetch =
0
;
- conf->collect_hcb =
0
;
- conf->collect_objects =
0
;
+ conf->collect_esi =
false
;
+ conf->collect_fetch =
false
;
+ conf->collect_hcb =
false
;
+ conf->collect_objects =
false
;
#if HAVE_VARNISH_V2
#if HAVE_VARNISH_V2
- conf->collect_purge =
0
;
+ conf->collect_purge =
false
;
#else
#else
- conf->collect_ban =
0
;
+ conf->collect_ban =
false
;
#endif
#endif
- conf->collect_session =
0
;
- conf->collect_shm =
1
;
+ conf->collect_session =
false
;
+ conf->collect_shm =
true
;
#if HAVE_VARNISH_V2
#if HAVE_VARNISH_V2
- conf->collect_sm =
0
;
+ conf->collect_sm =
false
;
#endif
#if HAVE_VARNISH_V2 || HAVE_VARNISH_V4 || HAVE_VARNISH_V5
#endif
#if HAVE_VARNISH_V2 || HAVE_VARNISH_V4 || HAVE_VARNISH_V5
- conf->collect_sma =
0
;
+ conf->collect_sma =
false
;
#endif
#endif
- conf->collect_sms =
0
;
- conf->collect_struct =
0
;
- conf->collect_totals =
0
;
+ conf->collect_sms =
false
;
+ conf->collect_struct =
false
;
+ conf->collect_totals =
false
;
#if HAVE_VARNISH_V3 || HAVE_VARNISH_V4 || HAVE_VARNISH_V5
#if HAVE_VARNISH_V3 || HAVE_VARNISH_V4 || HAVE_VARNISH_V5
- conf->collect_uptime =
0
;
+ conf->collect_uptime =
false
;
#endif
#endif
- conf->collect_vcl =
0
;
- conf->collect_workers =
0
;
+ conf->collect_vcl =
false
;
+ conf->collect_workers =
false
;
#if HAVE_VARNISH_V4 || HAVE_VARNISH_V5
#if HAVE_VARNISH_V4 || HAVE_VARNISH_V5
- conf->collect_vsm =
0
;
- conf->collect_lck =
0
;
- conf->collect_mempool =
0
;
- conf->collect_mgt =
0
;
- conf->collect_smf =
0
;
- conf->collect_vbe =
0
;
- conf->collect_mse =
0
;
+ conf->collect_vsm =
false
;
+ conf->collect_lck =
false
;
+ conf->collect_mempool =
false
;
+ conf->collect_mgt =
false
;
+ conf->collect_smf =
false
;
+ conf->collect_vbe =
false
;
+ conf->collect_mse =
false
;
#endif
return 0;
#endif
return 0;
@@
-1546,7
+1546,8
@@
static int varnish_init(void) /* {{{ */
/* callback = */ varnish_read,
/* interval = */ 0,
&(user_data_t){
/* callback = */ varnish_read,
/* interval = */ 0,
&(user_data_t){
- .data = conf, .free_func = varnish_config_free,
+ .data = conf,
+ .free_func = varnish_config_free,
});
return 0;
});
return 0;
@@
-1751,7
+1752,7
@@
static int varnish_config_instance(const oconfig_item_t *ci) /* {{{ */
!conf->collect_mgt && !conf->collect_lck && !conf->collect_mempool &&
!conf->collect_mse
#endif
!conf->collect_mgt && !conf->collect_lck && !conf->collect_mempool &&
!conf->collect_mse
#endif
-
) {
+ ) {
WARNING("Varnish plugin: No metric has been configured for "
"instance \"%s\". Disabling this instance.",
(conf->instance == NULL) ? "localhost" : conf->instance);
WARNING("Varnish plugin: No metric has been configured for "
"instance \"%s\". Disabling this instance.",
(conf->instance == NULL) ? "localhost" : conf->instance);
@@
-1759,8
+1760,8
@@
static int varnish_config_instance(const oconfig_item_t *ci) /* {{{ */
return EINVAL;
}
return EINVAL;
}
- snprintf(callback_name, sizeof(callback_name), "varnish/%s",
- (conf->instance == NULL) ? "localhost" : conf->instance);
+ s
s
nprintf(callback_name, sizeof(callback_name), "varnish/%s",
+
(conf->instance == NULL) ? "localhost" : conf->instance);
plugin_register_complex_read(
/* group = */ "varnish",
plugin_register_complex_read(
/* group = */ "varnish",
@@
-1768,10
+1769,11
@@
static int varnish_config_instance(const oconfig_item_t *ci) /* {{{ */
/* callback = */ varnish_read,
/* interval = */ 0,
&(user_data_t){
/* callback = */ varnish_read,
/* interval = */ 0,
&(user_data_t){
- .data = conf, .free_func = varnish_config_free,
+ .data = conf,
+ .free_func = varnish_config_free,
});
});
- have_instance =
1
;
+ have_instance =
true
;
return 0;
} /* }}} int varnish_config_instance */
return 0;
} /* }}} int varnish_config_instance */