#define CFG_SYSTEM_ALL 0x0F
typedef struct {
uint32_t flags;
+ cna_interval_t interval;
+ na_elem_t *query;
} cfg_system_t;
/*!
/*!
* \brief Configuration struct for volume usage data (free / used).
*/
-#define VOLUME_INIT 0x01
-#define VOLUME_DF 0x02
-#define VOLUME_SNAP 0x04
+#define CFG_VOLUME_USAGE_INIT 0x0001
+#define CFG_VOLUME_USAGE_DF 0x0002
+#define CFG_VOLUME_USAGE_SNAP 0x0004
+#define HAVE_VOLUME_USAGE_SNAP 0x0008
typedef struct {
uint32_t flags;
+ uint64_t snap_used;
} cfg_volume_usage_t;
typedef struct service_config_s {
cfg_service_t *services;
cfg_disk_t *cfg_disk;
cfg_wafl_t *cfg_wafl;
+ cfg_system_t *cfg_system;
volume_t *volumes;
struct host_config_s *next;
free_disk (next);
} /* }}} void free_disk */
+static void free_cfg_wafl (cfg_wafl_t *cw) /* {{{ */
+{
+ if (cw == NULL)
+ return;
+
+ if (cw->query != NULL)
+ na_elem_free (cw->query);
+
+ sfree (cw);
+} /* }}} void free_cfg_wafl */
+
static void free_cfg_disk (cfg_disk_t *cfg_disk) /* {{{ */
{
if (cfg_disk == NULL)
{
cfg_service_t *next;
+ if (service == NULL)
+ return;
+
next = service->next;
/* FIXME: Free service->data? */
+ na_elem_free(service->query);
+
sfree (service);
free_cfg_service (next);
free_cfg_service (hc->services);
free_cfg_disk (hc->cfg_disk);
+ free_cfg_wafl (hc->cfg_wafl);
free_volume (hc->volumes);
sfree (hc);
/* Make sure the default flags include the init-bit. */
if (vol_usage_flags != 0)
- vol_usage_flags |= VOLUME_INIT;
+ vol_usage_flags |= CFG_VOLUME_USAGE_INIT;
if (vol_perf_flags != 0)
vol_perf_flags |= CFG_VOLUME_PERF_INIT;
continue;
/* Check if the flags have been initialized. */
- if (((v->cfg_volume_usage.flags & VOLUME_INIT) == 0)
+ if (((v->cfg_volume_usage.flags & CFG_VOLUME_USAGE_INIT) == 0)
&& (vol_usage_flags != 0))
v->cfg_volume_usage.flags = vol_usage_flags;
if (((v->perf_data.flags & CFG_VOLUME_PERF_INIT) == 0)
if (host == NULL)
return (EINVAL);
+ /* If WAFL was not configured, return without doing anything. */
if (host->cfg_wafl == NULL)
return (0);
if (host == NULL)
return (EINVAL);
+ /* If the user did not configure disk statistics, return without doing
+ * anything. */
if (host->cfg_disk == NULL)
return (0);
if (volume == NULL)
continue;
- if (!(volume->cfg_volume_usage.flags & VOLUME_DF))
+ if (!(volume->cfg_volume_usage.flags & CFG_VOLUME_USAGE_DF))
continue;
/* 2^4 exa-bytes? This will take a while ;) */
size_free = na_child_get_uint64(inst, "size-available", UINT64_MAX);
if (size_free != UINT64_MAX)
- submit_double (host->name, volume->name, "df_complex", "used",
- (double) size_used, /* time = */ 0);
-
- size_used = na_child_get_uint64(inst, "size-used", UINT64_MAX);
- if (size_free != UINT64_MAX)
submit_double (host->name, volume->name, "df_complex", "free",
(double) size_free, /* time = */ 0);
+ size_used = na_child_get_uint64(inst, "size-used", UINT64_MAX);
+ if (size_used != UINT64_MAX) {
+ if ((volume->cfg_volume_usage.flags & HAVE_VOLUME_USAGE_SNAP)
+ && (size_used >= volume->cfg_volume_usage.snap_used))
+ size_used -= volume->cfg_volume_usage.snap_used;
+ submit_double (host->name, volume->name, "df_complex", "used",
+ (double) size_used, /* time = */ 0);
+ }
+
snap_reserved = na_child_get_uint64(inst, "snapshot-blocks-reserved", UINT64_MAX);
- if (snap_reserved != UINT64_MAX)
+ if (!(volume->cfg_volume_usage.flags & HAVE_VOLUME_USAGE_SNAP) && (snap_reserved != UINT64_MAX))
+ /* If we have snap usage data this value has already been submitted. */
/* 1 block == 1024 bytes as per API docs */
submit_double (host->name, volume->name, "df_complex", "snap_reserved",
(double) (1024 * snap_reserved), /* time = */ 0);
} /* for (volume) */
} /* }}} void query_volume_perf_data */
-/* Data corresponding to <GetSystemPerfData /> */
-static void collect_perf_system_data(host_config_t *host, na_elem_t *out, void *data) { /* {{{ */
+/* Data corresponding to <System /> */
+static int cna_handle_system_data (const char *hostname, /* {{{ */
+ cfg_system_t *cfg_system, na_elem_t *data)
+{
+ na_elem_t *instances;
+ na_elem_t *counter;
+ na_elem_iter_t counter_iter;
+
counter_t disk_read = 0, disk_written = 0;
counter_t net_recv = 0, net_sent = 0;
counter_t cpu_busy = 0, cpu_total = 0;
- unsigned int counter_flags = 0;
+ uint32_t counter_flags = 0;
- cfg_system_t *cfg_system = data;
const char *instance;
time_t timestamp;
- na_elem_t *counter;
- timestamp = (time_t) na_child_get_uint64(out, "timestamp", 0);
- out = na_elem_child(na_elem_child(out, "instances"), "instance-data");
- instance = na_child_get_string(out, "name");
+ timestamp = (time_t) na_child_get_uint64 (data, "timestamp", 0);
+
+ instances = na_elem_child(na_elem_child (data, "instances"), "instance-data");
+ if (instances == NULL)
+ {
+ ERROR ("netapp plugin: cna_handle_system_data: "
+ "na_elem_child (\"instances\") failed.");
+ return (-1);
+ }
- na_elem_iter_t iter = na_child_iterator(na_elem_child(out, "counters"));
- for (counter = na_iterator_next(&iter); counter; counter = na_iterator_next(&iter)) {
+ instance = na_child_get_string (instances, "name");
+ if (instance == NULL)
+ {
+ ERROR ("netapp plugin: cna_handle_system_data: "
+ "na_child_get_string (\"name\") failed.");
+ return (-1);
+ }
+
+ counter_iter = na_child_iterator (na_elem_child (instances, "counters"));
+ for (counter = na_iterator_next (&counter_iter);
+ counter != NULL;
+ counter = na_iterator_next (&counter_iter))
+ {
const char *name;
uint64_t value;
cpu_total = (counter_t) value;
counter_flags |= 0x20;
} else if ((cfg_system->flags & CFG_SYSTEM_OPS)
- && (strlen(name) > 4)
+ && (value > 0) && (strlen(name) > 4)
&& (!strcmp(name + strlen(name) - 4, "_ops"))) {
- submit_counter (host->name, instance, "disk_ops_complex", name,
+ submit_counter (hostname, instance, "disk_ops_complex", name,
(counter_t) value, timestamp);
}
} /* for (counter) */
if ((cfg_system->flags & CFG_SYSTEM_DISK)
- && ((counter_flags & 0x03) == 0x03))
- submit_two_counters (host->name, instance, "disk_octets", NULL,
+ && (HAS_ALL_FLAGS (counter_flags, 0x01 | 0x02)))
+ submit_two_counters (hostname, instance, "disk_octets", NULL,
disk_read, disk_written, timestamp);
if ((cfg_system->flags & CFG_SYSTEM_NET)
- && ((counter_flags & 0x0c) == 0x0c))
- submit_two_counters (host->name, instance, "if_octets", NULL,
+ && (HAS_ALL_FLAGS (counter_flags, 0x04 | 0x08)))
+ submit_two_counters (hostname, instance, "if_octets", NULL,
net_recv, net_sent, timestamp);
if ((cfg_system->flags & CFG_SYSTEM_CPU)
- && ((counter_flags & 0x30) == 0x30)) {
- submit_counter (host->name, instance, "cpu", "system",
+ && (HAS_ALL_FLAGS (counter_flags, 0x10 | 0x20)))
+ {
+ submit_counter (hostname, instance, "cpu", "system",
cpu_busy, timestamp);
- submit_counter (host->name, instance, "cpu", "idle",
+ submit_counter (hostname, instance, "cpu", "idle",
cpu_total - cpu_busy, timestamp);
}
-} /* }}} void collect_perf_system_data */
+
+ return (0);
+} /* }}} int cna_handle_system_data */
+
+static int cna_setup_system (cfg_system_t *cs) /* {{{ */
+{
+ if (cs == NULL)
+ return (EINVAL);
+
+ if (cs->query != NULL)
+ return (0);
+
+ cs->query = na_elem_new ("perf-object-get-instances");
+ if (cs->query == NULL)
+ {
+ ERROR ("netapp plugin: na_elem_new failed.");
+ return (-1);
+ }
+ na_child_add_string (cs->query, "objectname", "system");
+
+ return (0);
+} /* }}} int cna_setup_system */
+
+static int cna_query_system (host_config_t *host) /* {{{ */
+{
+ na_elem_t *data;
+ int status;
+ time_t now;
+
+ if (host == NULL)
+ return (EINVAL);
+
+ /* If system statistics were not configured, return without doing anything. */
+ if (host->cfg_system == NULL)
+ return (0);
+
+ now = time (NULL);
+ if ((host->cfg_system->interval.interval + host->cfg_system->interval.last_read) > now)
+ return (0);
+
+ status = cna_setup_system (host->cfg_system);
+ if (status != 0)
+ return (status);
+ assert (host->cfg_system->query != NULL);
+
+ data = na_server_invoke_elem(host->srv, host->cfg_system->query);
+ if (na_results_status (data) != NA_OK)
+ {
+ ERROR ("netapp plugin: cna_query_system: na_server_invoke_elem failed: %s",
+ na_results_reason (data));
+ na_elem_free (data);
+ return (-1);
+ }
+
+ status = cna_handle_system_data (host->name, host->cfg_system, data);
+
+ if (status == 0)
+ host->cfg_system->interval.last_read = now;
+
+ na_elem_free (data);
+ return (status);
+} /* }}} int cna_query_system */
/*
* Configuration handling
service->query = 0;
service->handler = collect_volume_data;
cfg_volume_data = service->data = malloc(sizeof(*cfg_volume_data));
- cfg_volume_data->flags = VOLUME_INIT;
+ cfg_volume_data->flags = CFG_VOLUME_USAGE_INIT;
service->next = host->services;
host->services = service;
for (i = 0; i < ci->children_num; ++i) {
cna_config_get_multiplier (item, service);
} else if (!strcasecmp(item->key, "GetDiskUtil")) {
had_df = 1;
- cna_config_volume_usage_option(host, cfg_volume_data, item, VOLUME_DF);
+ cna_config_volume_usage_option(host, cfg_volume_data, item, CFG_VOLUME_USAGE_DF);
+ } else if (!strcasecmp(item->key, "GetSnapUtil")) {
+ had_df = 1;
+ cna_config_volume_usage_option(host, cfg_volume_data, item, CFG_VOLUME_USAGE_SNAP);
}
}
if (!had_df) {
- cfg_volume_data->flags |= VOLUME_DF;
- host_set_all_cfg_volume_usage_flags(host, VOLUME_DF, /* set = */ true);
+ cfg_volume_data->flags |= CFG_VOLUME_USAGE_DF;
+ host_set_all_cfg_volume_usage_flags(host, CFG_VOLUME_USAGE_DF, /* set = */ true);
+ }
+ if (cfg_volume_data->flags & CFG_VOLUME_USAGE_SNAP) {
+ WARNING("netapp plugin: The \"GetSnapUtil\" option does not support the \"+\" wildcard.");
}
} /* }}} void cna_config_volume_usage */
"`WAFL' blocks.", item->key);
}
+ if ((cfg_wafl->flags & CFG_WAFL_ALL) == 0)
+ {
+ NOTICE ("netapp plugin: All WAFL related values have been disabled. "
+ "Collection of WAFL data will be disabled entirely.");
+ free_cfg_wafl (host->cfg_wafl);
+ host->cfg_wafl = NULL;
+ }
+
return (0);
} /* }}} int cna_config_wafl */
-/* Corresponds to a <GetSystemPerfData /> block */
+/* Corresponds to a <System /> block */
static int cna_config_system (host_config_t *host, /* {{{ */
oconfig_item_t *ci, const cfg_service_t *default_service)
{
- int i;
- cfg_service_t *service;
cfg_system_t *cfg_system;
+ int i;
- service = malloc(sizeof(*service));
- if (service == NULL)
- return (-1);
- memset (service, 0, sizeof (*service));
- *service = *default_service;
- service->handler = collect_perf_system_data;
+ if ((host == NULL) || (ci == NULL))
+ return (EINVAL);
- cfg_system = malloc(sizeof(*cfg_system));
- if (cfg_system == NULL) {
- sfree (service);
- return (-1);
+ if (host->cfg_system == NULL)
+ {
+ cfg_system = malloc (sizeof (*cfg_system));
+ if (cfg_system == NULL)
+ return (ENOMEM);
+ memset (cfg_system, 0, sizeof (*cfg_system));
+
+ /* Set default flags */
+ cfg_system->flags = CFG_SYSTEM_ALL;
+ cfg_system->query = NULL;
+
+ host->cfg_system = cfg_system;
}
- memset (cfg_system, 0, sizeof (*cfg_system));
- cfg_system->flags = CFG_SYSTEM_ALL;
- service->data = cfg_system;
+ cfg_system = host->cfg_system;
for (i = 0; i < ci->children_num; ++i) {
oconfig_item_t *item = ci->children + i;
- if (!strcasecmp(item->key, "Multiplier")) {
- cna_config_get_multiplier (item, service);
+ if (strcasecmp(item->key, "Interval") == 0) {
+ cna_config_get_interval (item, &cfg_system->interval);
} else if (!strcasecmp(item->key, "GetCPULoad")) {
cna_config_bool_to_flag (item, &cfg_system->flags, CFG_SYSTEM_CPU);
} else if (!strcasecmp(item->key, "GetInterfaces")) {
cna_config_bool_to_flag (item, &cfg_system->flags, CFG_SYSTEM_DISK);
} else {
WARNING ("netapp plugin: The %s config option is not allowed within "
- "`GetSystemPerfData' blocks.", item->key);
+ "`System' blocks.", item->key);
}
}
- service->next = host->services;
- host->services = service;
-
return (0);
} /* }}} int cna_config_system */
const host_config_t *default_host, const cfg_service_t *def_def_service)
{
oconfig_item_t *item;
- host_config_t *host, *hc;
+ host_config_t *host;
cfg_service_t default_service = *def_def_service;
int status;
int i;
host->interval = item->values[0].value.number;
} else if (!strcasecmp(item->key, "GetVolumePerfData")) {
cna_config_volume_performance(host, item);
- } else if (!strcasecmp(item->key, "GetSystemPerfData")) {
+ } else if (!strcasecmp(item->key, "System")) {
cna_config_system(host, item, &default_service);
} else if (!strcasecmp(item->key, "WAFL")) {
cna_config_wafl(host, item);
return (NULL);
}
- for (hc = global_host_config; hc; hc = hc->next) {
- if (!strcasecmp(hc->name, host->name)) WARNING("netapp plugin: Duplicate definition of host \"%s\". This is probably a bad idea.", hc->name);
- }
return host;
} /* }}} host_config_t *cna_config_host */
for (service = host->services; service; service = service->next) {
service->interval = host->interval * service->multiplier;
- if (service->handler == collect_perf_system_data) {
- service->query = na_elem_new("perf-object-get-instances");
- na_child_add_string(service->query, "objectname", "system");
- } else if (service->handler == query_volume_perf_data) {
+ if (service->handler == query_volume_perf_data) {
service->query = na_elem_new("perf-object-get-instances");
na_child_add_string(service->query, "objectname", "volume");
e = na_elem_new("counters");
+ /* "foo" means: This string has to be here but
+ the content doesn't matter. */
na_child_add_string(e, "foo", "read_ops");
na_child_add_string(e, "foo", "write_ops");
na_child_add_string(e, "foo", "read_data");
for (i = 0; i < ci->children_num; ++i) {
item = ci->children + i;
- /* if (!item || !item->key || !*item->key) continue; */
if (!strcasecmp(item->key, "Host")) {
host_config_t *host;
host_config_t *tmp;
cna_query_wafl (host);
cna_query_disk (host);
+ cna_query_system (host);
}
return 0;
} /* }}} int cna_read */