#include "plugin.h"
#include "common.h"
#include "configfile.h"
-#include "utils_debug.h"
#include "network.h"
static int send_buffer_fill;
static value_list_t send_buffer_vl = VALUE_LIST_INIT;
static char send_buffer_type[DATA_MAX_NAME_LEN];
+static pthread_mutex_t send_buffer_lock = PTHREAD_MUTEX_INITIALIZER;
/*
* Private functions
if (buffer_len < (15))
{
- DBG ("packet is too short: buffer_len = %i", buffer_len);
+ DEBUG ("packet is too short: buffer_len = %i", buffer_len);
return (-1);
}
if (h_num != ((h_length - 6) / 9))
{
- DBG ("`length' and `num of values' don't match");
+ DEBUG ("`length' and `num of values' don't match");
return (-1);
}
uint16_t h_length;
uint16_t h_type;
- DBG ("ret_buffer = %p; ret_buffer_len = %i; output = %p; output_len = %i;",
+ DEBUG ("network plugin: parse_part_string: ret_buffer = %p;"
+ " ret_buffer_len = %i; output = %p; output_len = %i;",
*ret_buffer, *ret_buffer_len,
(void *) output, output_len);
h_length = ntohs (ps.head->length);
h_type = ntohs (ps.head->type);
- DBG ("length = %hu; type = %hu;", h_length, h_type);
+ DEBUG ("network plugin: parse_part_string: length = %hu; type = %hu;",
+ h_length, h_type);
if (buffer_len < h_length)
{
- DBG ("packet is too short");
+ DEBUG ("packet is too short");
return (-1);
}
assert ((h_type == TYPE_HOST)
ps.value = buffer + 4;
if (ps.value[h_length - 5] != '\0')
{
- DBG ("String does not end with a nullbyte");
+ DEBUG ("String does not end with a nullbyte");
return (-1);
}
if (output_len < (h_length - 4))
{
- DBG ("output buffer is too small");
+ DEBUG ("output buffer is too small");
return (-1);
}
strcpy (output, ps.value);
- DBG ("output = %s", output);
+ DEBUG ("network plugin: parse_part_string: output = %s", output);
*ret_buffer = (void *) (buffer + h_length);
*ret_buffer_len = buffer_len - h_length;
value_list_t vl = VALUE_LIST_INIT;
char type[DATA_MAX_NAME_LEN];
- DBG ("buffer = %p; buffer_len = %i;", buffer, buffer_len);
+ DEBUG ("buffer = %p; buffer_len = %i;", buffer, buffer_len);
memset (&vl, '\0', sizeof (vl));
memset (&type, '\0', sizeof (type));
if (ntohs (header->length) > buffer_len)
break;
+ /* Assure that this loop terminates eventually */
+ if (ntohs (header->length) < 4)
+ break;
- if (header->type == htons (TYPE_VALUES))
+ if (ntohs (header->type) == TYPE_VALUES)
{
status = parse_part_values (&buffer, &buffer_len,
&vl.values, &vl.values_len);
if (status != 0)
{
- DBG ("parse_part_values failed.");
+ DEBUG ("parse_part_values failed.");
break;
}
&& (strlen (vl.plugin) > 0)
&& (strlen (type) > 0))
{
- DBG ("dispatching values");
+ DEBUG ("dispatching values");
plugin_dispatch_values (type, &vl);
}
else
{
- DBG ("NOT dispatching values");
+ DEBUG ("NOT dispatching values");
}
}
- else if (header->type == ntohs (TYPE_TIME))
+ else if (ntohs (header->type) == TYPE_TIME)
{
uint64_t tmp = 0;
status = parse_part_number (&buffer, &buffer_len, &tmp);
if (status == 0)
vl.time = (time_t) tmp;
}
- else if (header->type == ntohs (TYPE_HOST))
+ else if (ntohs (header->type) == TYPE_HOST)
{
status = parse_part_string (&buffer, &buffer_len,
vl.host, sizeof (vl.host));
+ DEBUG ("network plugin: parse_packet: vl.host = %s", vl.host);
}
- else if (header->type == ntohs (TYPE_PLUGIN))
+ else if (ntohs (header->type) == TYPE_PLUGIN)
{
status = parse_part_string (&buffer, &buffer_len,
vl.plugin, sizeof (vl.plugin));
+ DEBUG ("network plugin: parse_packet: vl.plugin = %s", vl.plugin);
}
- else if (header->type == ntohs (TYPE_PLUGIN_INSTANCE))
+ else if (ntohs (header->type) == TYPE_PLUGIN_INSTANCE)
{
status = parse_part_string (&buffer, &buffer_len,
vl.plugin_instance, sizeof (vl.plugin_instance));
+ DEBUG ("network plugin: parse_packet: vl.plugin_instance = %s", vl.plugin_instance);
}
- else if (header->type == ntohs (TYPE_TYPE))
+ else if (ntohs (header->type) == TYPE_TYPE)
{
status = parse_part_string (&buffer, &buffer_len,
type, sizeof (type));
+ DEBUG ("network plugin: parse_packet: type = %s", type);
}
- else if (header->type == ntohs (TYPE_TYPE_INSTANCE))
+ else if (ntohs (header->type) == TYPE_TYPE_INSTANCE)
{
status = parse_part_string (&buffer, &buffer_len,
vl.type_instance, sizeof (vl.type_instance));
+ DEBUG ("network type: parse_packet: vl.type_instance = %s", vl.type_instance);
}
else
{
- DBG ("Unknown part type: 0x%0hx", header->type);
- buffer = ((char *) buffer) + header->length;
+ DEBUG ("Unknown part type: 0x%0hx", ntohs (header->type));
+ buffer = ((char *) buffer) + ntohs (header->length);
}
} /* while (buffer_len > sizeof (part_header_t)) */
if ((network_config_ttl < 1) || (network_config_ttl > 255))
return (-1);
- DBG ("ttl = %i", network_config_ttl);
+ DEBUG ("ttl = %i", network_config_ttl);
if (ai->ai_family == AF_INET)
{
&network_config_ttl,
sizeof (network_config_ttl)) == -1)
{
- syslog (LOG_ERR, "setsockopt: %s", strerror (errno));
+ char errbuf[1024];
+ ERROR ("setsockopt: %s",
+ sstrerror (errno, errbuf, sizeof (errbuf)));
return (-1);
}
}
&network_config_ttl,
sizeof (network_config_ttl)) == -1)
{
- syslog (LOG_ERR, "setsockopt: %s", strerror (errno));
+ char errbuf[1024];
+ ERROR ("setsockopt: %s",
+ sstrerror (errno, errbuf,
+ sizeof (errbuf)));
return (-1);
}
}
{
int loop = 1;
- DBG ("fd = %i; calling `bind'", se->fd);
+ DEBUG ("fd = %i; calling `bind'", se->fd);
if (bind (se->fd, ai->ai_addr, ai->ai_addrlen) == -1)
{
- syslog (LOG_ERR, "bind: %s", strerror (errno));
+ char errbuf[1024];
+ ERROR ("bind: %s",
+ sstrerror (errno, errbuf, sizeof (errbuf)));
return (-1);
}
{
struct ip_mreq mreq;
- DBG ("fd = %i; IPv4 multicast address found", se->fd);
+ DEBUG ("fd = %i; IPv4 multicast address found", se->fd);
mreq.imr_multiaddr.s_addr = addr->sin_addr.s_addr;
mreq.imr_interface.s_addr = htonl (INADDR_ANY);
if (setsockopt (se->fd, IPPROTO_IP, IP_MULTICAST_LOOP,
&loop, sizeof (loop)) == -1)
{
- syslog (LOG_ERR, "setsockopt: %s", strerror (errno));
+ char errbuf[1024];
+ ERROR ("setsockopt: %s",
+ sstrerror (errno, errbuf,
+ sizeof (errbuf)));
return (-1);
}
if (setsockopt (se->fd, IPPROTO_IP, IP_ADD_MEMBERSHIP,
&mreq, sizeof (mreq)) == -1)
{
- syslog (LOG_ERR, "setsockopt: %s", strerror (errno));
+ char errbuf[1024];
+ ERROR ("setsockopt: %s",
+ sstrerror (errno, errbuf,
+ sizeof (errbuf)));
return (-1);
}
}
{
struct ipv6_mreq mreq;
- DBG ("fd = %i; IPv6 multicast address found", se->fd);
+ DEBUG ("fd = %i; IPv6 multicast address found", se->fd);
memcpy (&mreq.ipv6mr_multiaddr,
&addr->sin6_addr,
if (setsockopt (se->fd, IPPROTO_IPV6, IPV6_MULTICAST_LOOP,
&loop, sizeof (loop)) == -1)
{
- syslog (LOG_ERR, "setsockopt: %s", strerror (errno));
+ char errbuf[1024];
+ ERROR ("setsockopt: %s",
+ sstrerror (errno, errbuf,
+ sizeof (errbuf)));
return (-1);
}
if (setsockopt (se->fd, IPPROTO_IPV6, IPV6_ADD_MEMBERSHIP,
&mreq, sizeof (mreq)) == -1)
{
- syslog (LOG_ERR, "setsockopt: %s", strerror (errno));
+ char errbuf[1024];
+ ERROR ("setsockopt: %s",
+ sstrerror (errno, errbuf,
+ sizeof (errbuf)));
return (-1);
}
}
sockent_t *se_head = NULL;
sockent_t *se_tail = NULL;
- DBG ("node = %s, service = %s", node, service);
+ DEBUG ("node = %s, service = %s", node, service);
memset (&ai_hints, '\0', sizeof (ai_hints));
ai_hints.ai_flags = 0;
ai_return = getaddrinfo (node, service, &ai_hints, &ai_list);
if (ai_return != 0)
{
- syslog (LOG_ERR, "getaddrinfo (%s, %s): %s",
+ char errbuf[1024];
+ ERROR ("getaddrinfo (%s, %s): %s",
(node == NULL) ? "(null)" : node,
(service == NULL) ? "(null)" : service,
(ai_return == EAI_SYSTEM)
- ? strerror (errno)
+ ? sstrerror (errno, errbuf, sizeof (errbuf))
: gai_strerror (ai_return));
return (NULL);
}
if ((se = (sockent_t *) malloc (sizeof (sockent_t))) == NULL)
{
- syslog (LOG_EMERG, "malloc: %s", strerror (errno));
+ char errbuf[1024];
+ ERROR ("malloc: %s",
+ sstrerror (errno, errbuf,
+ sizeof (errbuf)));
continue;
}
if ((se->addr = (struct sockaddr_storage *) malloc (sizeof (struct sockaddr_storage))) == NULL)
{
- syslog (LOG_EMERG, "malloc: %s", strerror (errno));
+ char errbuf[1024];
+ ERROR ("malloc: %s",
+ sstrerror (errno, errbuf,
+ sizeof (errbuf)));
free (se);
continue;
}
if (se->fd == -1)
{
- syslog (LOG_ERR, "socket: %s", strerror (errno));
+ char errbuf[1024];
+ ERROR ("socket: %s",
+ sstrerror (errno, errbuf,
+ sizeof (errbuf)));
free (se->addr);
free (se);
continue;
if (listen_sockets_num == 0)
{
- syslog (LOG_ERR, "network: Failed to open a listening socket.");
+ ERROR ("network: Failed to open a listening socket.");
return (-1);
}
if (status <= 0)
{
+ char errbuf[1024];
if (errno == EINTR)
continue;
- syslog (LOG_ERR, "poll failed: %s",
- strerror (errno));
+ ERROR ("poll failed: %s",
+ sstrerror (errno, errbuf, sizeof (errbuf)));
return (-1);
}
0 /* no flags */);
if (buffer_len < 0)
{
- syslog (LOG_ERR, "recv failed: %s", strerror (errno));
+ char errbuf[1024];
+ ERROR ("recv failed: %s",
+ sstrerror (errno, errbuf,
+ sizeof (errbuf)));
return (-1);
}
sockent_t *se;
int status;
- DBG ("buffer_len = %i", buffer_len);
+ DEBUG ("buffer_len = %i", buffer_len);
for (se = sending_sockets; se != NULL; se = se->next)
{
(struct sockaddr *) se->addr, se->addrlen);
if (status < 0)
{
+ char errbuf[1024];
if (errno == EINTR)
continue;
- syslog (LOG_ERR, "network plugin: sendto failed: %s",
- strerror (errno));
+ ERROR ("network plugin: sendto failed: %s",
+ sstrerror (errno, errbuf,
+ sizeof (errbuf)));
break;
}
value_list_t *vl_def, char *type_def,
const data_set_t *ds, const value_list_t *vl)
{
+ char *buffer_orig = buffer;
+
if (strcmp (vl_def->host, vl->host) != 0)
{
if (write_part_string (&buffer, &buffer_size, TYPE_HOST,
vl->host, strlen (vl->host)) != 0)
return (-1);
strcpy (vl_def->host, vl->host);
- DBG ("host = %s", vl->host);
+ DEBUG ("host = %s", vl->host);
}
if (vl_def->time != vl->time)
(uint64_t) vl->time))
return (-1);
vl_def->time = vl->time;
- DBG ("time = %u", (unsigned int) vl->time);
+ DEBUG ("time = %u", (unsigned int) vl->time);
}
if (strcmp (vl_def->plugin, vl->plugin) != 0)
vl->plugin, strlen (vl->plugin)) != 0)
return (-1);
strcpy (vl_def->plugin, vl->plugin);
- DBG ("plugin = %s", vl->plugin);
+ DEBUG ("plugin = %s", vl->plugin);
}
if (strcmp (vl_def->plugin_instance, vl->plugin_instance) != 0)
strlen (vl->plugin_instance)) != 0)
return (-1);
strcpy (vl_def->plugin_instance, vl->plugin_instance);
- DBG ("plugin_instance = %s", vl->plugin_instance);
+ DEBUG ("plugin_instance = %s", vl->plugin_instance);
}
if (strcmp (type_def, ds->type) != 0)
ds->type, strlen (ds->type)) != 0)
return (-1);
strcpy (type_def, ds->type);
- DBG ("type = %s", ds->type);
+ DEBUG ("type = %s", ds->type);
}
if (strcmp (vl_def->type_instance, vl->type_instance) != 0)
{
- if (write_part_string (&buffer, &buffer_size, TYPE_PLUGIN_INSTANCE,
+ if (write_part_string (&buffer, &buffer_size, TYPE_TYPE_INSTANCE,
vl->type_instance,
strlen (vl->type_instance)) != 0)
return (-1);
strcpy (vl_def->type_instance, vl->type_instance);
- DBG ("type_instance = %s", vl->type_instance);
+ DEBUG ("type_instance = %s", vl->type_instance);
}
if (write_part_values (&buffer, &buffer_size, ds, vl) != 0)
return (-1);
- return (buffer_size);
+ return (buffer - buffer_orig);
} /* int add_to_buffer */
static void flush_buffer (void)
static int network_write (const data_set_t *ds, const value_list_t *vl)
{
int status;
- /* TODO: lock buffer */
+
+ pthread_mutex_lock (&send_buffer_lock);
+
status = add_to_buffer (send_buffer_ptr,
sizeof (send_buffer) - send_buffer_fill,
&send_buffer_vl, send_buffer_type,
ds, vl);
if (status >= 0)
{
+ /* status == bytes added to the buffer */
send_buffer_fill += status;
send_buffer_ptr += status;
}
if (status < 0)
{
- syslog (LOG_ERR, "network plugin: Unable to append to the "
+ ERROR ("network plugin: Unable to append to the "
"buffer for some weird reason");
}
else if ((sizeof (send_buffer) - send_buffer_fill) < 15)
{
flush_buffer ();
}
- /* TODO: unlock buffer */
+
+ pthread_mutex_unlock (&send_buffer_lock);
return ((status < 0) ? -1 : 0);
} /* int network_write */
static int network_shutdown (void)
{
- DBG ("Shutting down.");
+ DEBUG ("Shutting down.");
listen_loop++;
- pthread_kill (listen_thread, SIGTERM);
- pthread_join (listen_thread, NULL /* no return value */);
+ if (listen_thread != (pthread_t) 0)
+ {
+ pthread_kill (listen_thread, SIGTERM);
+ pthread_join (listen_thread, NULL /* no return value */);
+ listen_thread = (pthread_t) 0;
+ }
listen_thread = 0;
+ /* TODO: Close `sending_sockets' */
+
+ plugin_unregister_config ("network");
+ plugin_unregister_init ("network");
+ plugin_unregister_write ("network");
+ plugin_unregister_shutdown ("network");
+
return (0);
-}
+} /* int network_shutdown */
static int network_init (void)
{
receive_thread, NULL /* no argument */);
if (status != 0)
- syslog (LOG_ERR, "network: pthread_create failed: %s",
- strerror (errno));
+ {
+ char errbuf[1024];
+ ERROR ("network: pthread_create failed: %s",
+ sstrerror (errno, errbuf,
+ sizeof (errbuf)));
+ }
}
return (0);
} /* int network_init */
projects / collectd.git / blobdiff