Replace all occurrences of `strcpy' with `sstrncpy'.

[collectd.git] / src / ping.c

diff --git a/src/ping.c b/src/ping.c
index 3c70066..09de77c 100644 (file)
--- a/src/ping.c
+++ b/src/ping.c
@@ -106,15 +106,18 @@ static void add_hosts (void)
                        hl_this = hl_this->next;
                }
        }
-}
+} /* void add_hosts */
 
 static int ping_init (void)
 {
+       if (pingobj == NULL)
+               return (-1);
+
        if (hosts != NULL)
                add_hosts ();
 
        return (0);
-}
+} /* int ping_init */
 
 static int ping_config (const char *key, const char *value)
 {
@@ -159,7 +162,7 @@ static int ping_config (const char *key, const char *value)
        else if (strcasecmp (key, "ttl") == 0)
        {
                int ttl = atoi (value);
-               if (ping_setopt (pingobj, PING_DEF_TIMEOUT, (void *) &ttl))
+               if (ping_setopt (pingobj, PING_OPT_TTL, (void *) &ttl))
                {
                        WARNING ("ping: liboping did not accept the TTL value %i", ttl);
                        return (1);
@@ -183,9 +186,9 @@ static void ping_submit (char *host, double latency)
        vl.values = values;
        vl.values_len = 1;
        vl.time = time (NULL);
-       strcpy (vl.host, hostname_g);
-       strcpy (vl.plugin, "ping");
-       strcpy (vl.plugin_instance, "");
+       sstrncpy (vl.host, hostname_g, sizeof (vl.host));
+       sstrncpy (vl.plugin, "ping", sizeof (vl.plugin));
+       sstrncpy (vl.plugin_instance, "", sizeof (vl.plugin_instance));
        strncpy (vl.type_instance, host, sizeof (vl.type_instance));
 
        plugin_dispatch_values ("ping", &vl);
@@ -241,7 +244,7 @@ static int ping_read (void)
                number_of_hosts++;
        }
 
-       if ((number_of_hosts == 0) && (getuid != 0))
+       if ((number_of_hosts == 0) && (getuid () != 0))
        {
                ERROR ("ping plugin: All hosts failed. Try starting collectd as root.");
        }