#include "plugin.h"
#include "common.h"
#include "configfile.h"
+#include "utils_cache.h"
#include "riemann.pb-c.h"
#include <sys/socket.h>
#include <pthread.h>
#define RIEMANN_DELAY 1
-#define RIEMANN_PORT 5555
+#define RIEMANN_PORT "5555"
#define RIEMANN_MAX_TAGS 37
#define RIEMANN_EXTRA_TAGS 32
struct riemann_host {
#define F_CONNECT 0x01
- u_int8_t flags;
+ uint8_t flags;
pthread_mutex_t lock;
int delay;
- char name[DATA_MAX_NAME_LEN];
- int port;
+ _Bool store_rates;
+ char *node;
+ char *service;
int s;
+
+ int reference_count;
};
-static char *riemann_tags[RIEMANN_EXTRA_TAGS];
-static int riemann_tagcount;
+static char **riemann_tags;
+static size_t riemann_tags_num;
static int riemann_send(struct riemann_host *, Msg const *);
static int riemann_notification(const notification_t *, user_data_t *);
static void riemann_event_protobuf_free (Event *event) /* {{{ */
{
- size_t i;
-
if (event == NULL)
return;
sfree (event->host);
sfree (event->description);
- for (i = 0; i < event->n_tags; i++)
- sfree (event->tags[i]);
- sfree (event->tags);
+ strarray_free (event->tags, event->n_tags);
+ event->tags = NULL;
+ event->n_tags = 0;
sfree (event);
} /* }}} void riemann_event_protobuf_free */
{
u_char *buffer;
size_t buffer_len;
- ssize_t status;
+ int status;
+
+ pthread_mutex_lock (&host->lock);
+
+ status = riemann_connect (host);
+ if (status != 0)
+ {
+ pthread_mutex_unlock (&host->lock);
+ return status;
+ }
buffer_len = msg__get_packed_size(msg);
buffer = malloc (buffer_len);
if (buffer == NULL) {
+ pthread_mutex_unlock (&host->lock);
ERROR ("riemann plugin: malloc failed.");
return ENOMEM;
}
msg__pack(msg, buffer);
- status = swrite (host->s, buffer, buffer_len);
+ status = (int) swrite (host->s, buffer, buffer_len);
if (status != 0)
{
char errbuf[1024];
- ERROR ("riemann plugin: Sending to Riemann at %s:%d failed: %s",
- host->name, host->port,
- sstrerror (errno, errbuf, sizeof (errbuf)));
+
riemann_disconnect (host);
+ pthread_mutex_unlock (&host->lock);
+
+ ERROR ("riemann plugin: Sending to Riemann at %s:%s failed: %s",
+ host->node,
+ (host->service != NULL) ? host->service : RIEMANN_PORT,
+ sstrerror (errno, errbuf, sizeof (errbuf)));
sfree (buffer);
return -1;
}
+ pthread_mutex_unlock (&host->lock);
sfree (buffer);
return 0;
}
char buffer[1024];
size_t ret;
- char **tmp;
-
- tmp = realloc (event->tags, (event->n_tags + 1) * sizeof (*event->tags));
- if (tmp == NULL)
- return (ENOMEM);
- event->tags = tmp;
-
va_start (ap, format);
ret = vsnprintf (buffer, sizeof (buffer), format, ap);
if (ret >= sizeof (buffer))
buffer[ret] = 0;
va_end (ap);
- event->tags[event->n_tags] = strdup (buffer);
- if (event->tags[event->n_tags] == NULL)
- return (ENOMEM);
- event->n_tags++;
- return (0);
+ return (strarray_add (&event->tags, &event->n_tags, buffer));
} /* }}} int riemann_event_add_tag */
static Msg *riemann_notification_to_protobuf (struct riemann_host *host, /* {{{ */
riemann_event_add_tag (event, "type_instance:%s",
n->type_instance);
- for (i = 0; i < riemann_tagcount; i++)
+ for (i = 0; i < riemann_tags_num; i++)
riemann_event_add_tag (event, "%s", riemann_tags[i]);
/* TODO: Use FORMAT_VL() here. */
return (msg);
} /* }}} Msg *riemann_notification_to_protobuf */
-static Event *riemann_value_to_protobuf (struct riemann_host *host, /* {{{ */
+static Event *riemann_value_to_protobuf (struct riemann_host const *host, /* {{{ */
data_set_t const *ds,
value_list_t const *vl, size_t index,
gauge_t const *rates)
riemann_event_add_tag (event, "type_instance:%s",
vl->type_instance);
- riemann_event_add_tag (event, "ds_type:%s",
- DS_TYPE_TO_STRING(ds->ds[index].type));
+ if ((ds->ds[index].type != DS_TYPE_GAUGE) && (rates != NULL))
+ {
+ riemann_event_add_tag (event, "ds_type:%s:rate",
+ DS_TYPE_TO_STRING(ds->ds[index].type));
+ }
+ else
+ {
+ riemann_event_add_tag (event, "ds_type:%s",
+ DS_TYPE_TO_STRING(ds->ds[index].type));
+ }
riemann_event_add_tag (event, "ds_name:%s", ds->ds[index].name);
riemann_event_add_tag (event, "ds_index:%zu", index);
- for (i = 0; i < riemann_tagcount; i++)
+ for (i = 0; i < riemann_tags_num; i++)
riemann_event_add_tag (event, "%s", riemann_tags[i]);
- if (rates != NULL)
+ if (ds->ds[index].type == DS_TYPE_GAUGE)
{
event->has_metric_d = 1;
- event->metric_d = (double) rates[index];
+ event->metric_d = (double) vl->values[index].gauge;
}
- else if (ds->ds[index].type == DS_TYPE_GAUGE)
+ else if (rates != NULL)
{
event->has_metric_d = 1;
- event->metric_d = (double) vl->values[index].gauge;
+ event->metric_d = (double) rates[index];
}
else
{
/* TODO: Use FORMAT_VL() here. */
ssnprintf (service_buffer, sizeof(service_buffer),
"%s-%s-%s-%s-%s", vl->plugin, vl->plugin_instance,
- vl->type, vl->type_instance, ds->ds[i].name);
+ vl->type, vl->type_instance, ds->ds[index].name);
event->service = strdup (service_buffer);
DEBUG ("riemann plugin: Successfully created protobuf for metric: "
return (event);
} /* }}} Event *riemann_value_to_protobuf */
-static Msg *riemann_value_list_to_protobuf (struct riemann_host *host, /* {{{ */
+static Msg *riemann_value_list_to_protobuf (struct riemann_host const *host, /* {{{ */
data_set_t const *ds,
value_list_t const *vl)
{
Msg *msg;
size_t i;
+ gauge_t *rates = NULL;
/* Initialize the Msg structure. */
msg = malloc (sizeof (*msg));
return (NULL);
}
+ if (host->store_rates)
+ {
+ rates = uc_get_rate (ds, vl);
+ if (rates == NULL)
+ {
+ ERROR ("riemann plugin: uc_get_rate failed.");
+ riemann_msg_protobuf_free (msg);
+ return (NULL);
+ }
+ }
+
for (i = 0; i < msg->n_events; i++)
{
msg->events[i] = riemann_value_to_protobuf (host, ds, vl,
- (int) i, /* rates = */ NULL);
- if (msg->events[i])
+ (int) i, rates);
+ if (msg->events[i] == NULL)
{
riemann_msg_protobuf_free (msg);
+ sfree (rates);
return (NULL);
}
}
+ sfree (rates);
return (msg);
} /* }}} Msg *riemann_value_list_to_protobuf */
struct riemann_host *host = ud->data;
Msg *msg;
- if ((status = riemann_connect(host)) != 0)
- return status;
-
msg = riemann_value_list_to_protobuf (host, ds, vl);
if (msg == NULL)
return (-1);
return status;
}
+/* host->lock must be held when calling this function. */
static int
riemann_connect(struct riemann_host *host)
{
int e;
struct addrinfo *ai, *res, hints;
- char service[32];
+ char const *service;
if (host->flags & F_CONNECT)
return 0;
hints.ai_family = PF_UNSPEC;
hints.ai_socktype = SOCK_DGRAM;
- ssnprintf(service, sizeof(service), "%d", host->port);
+ assert (host->node != NULL);
+ service = (host->service != NULL) ? host->service : RIEMANN_PORT;
- if ((e = getaddrinfo(host->name, service, &hints, &res)) != 0) {
- WARNING("could not resolve host \"%s\": %s",
- host->name, gai_strerror(e));
+ if ((e = getaddrinfo(host->node, service, &hints, &res)) != 0) {
+ ERROR ("riemann plugin: Unable to resolve host \"%s\": %s",
+ host->node, gai_strerror(e));
return -1;
}
for (ai = res; ai != NULL; ai = ai->ai_next) {
- pthread_mutex_lock(&host->lock);
/*
* check if another thread did not already succesfully connect
*/
if ((host->s = socket(ai->ai_family,
ai->ai_socktype,
ai->ai_protocol)) == -1) {
- pthread_mutex_unlock(&host->lock);
WARNING("riemann_connect: could not open socket");
freeaddrinfo(res);
return -1;
if (connect(host->s, ai->ai_addr, ai->ai_addrlen) != 0) {
close(host->s);
host->flags |= ~F_CONNECT;
- pthread_mutex_unlock(&host->lock);
freeaddrinfo(res);
return -1;
}
host->flags |= F_CONNECT;
- DEBUG("got a succesful connection for: %s", host->name);
- pthread_mutex_unlock(&host->lock);
+ DEBUG("riemann plugin: got a succesful connection for: %s",
+ host->node);
break;
}
return 0;
}
+/* host->lock must be held when calling this function. */
static int
riemann_disconnect (struct riemann_host *host)
{
- if (host == NULL)
- return (EINVAL);
-
if ((host->flags & F_CONNECT) == 0)
return (0);
{
struct riemann_host *host = p;
+ if (host == NULL)
+ return;
+
+ pthread_mutex_lock (&host->lock);
+
+ host->reference_count--;
+ if (host->reference_count > 0)
+ {
+ pthread_mutex_unlock (&host->lock);
+ return;
+ }
+
riemann_disconnect (host);
+
+ sfree(host->service);
+ pthread_mutex_destroy (&host->lock);
sfree(host);
}
WARNING("riemann host allocation failed");
return ENOMEM;
}
+ pthread_mutex_init (&host->lock, NULL);
+ host->reference_count = 1;
+ host->node = NULL;
+ host->service = NULL;
+ host->delay = RIEMANN_DELAY;
- if (cf_util_get_string_buffer(ci, host->name,
- sizeof(host->name)) != 0) {
- WARNING("riemann host name too long");
- sfree(host);
+ status = cf_util_get_string (ci, &host->node);
+ if (status != 0) {
+ WARNING("riemann plugin: Required host name is missing.");
+ riemann_free (host);
return -1;
}
- host->port = RIEMANN_PORT;
- host->delay = RIEMANN_DELAY;
for (i = 0; i < ci->children_num; i++) {
/*
* The code here could be simplified but makes room
status = 0;
if (strcasecmp(child->key, "port") == 0) {
- if ((status = cf_util_get_port_number(child)) < 0) {
- WARNING("invalid port number");
+ status = cf_util_get_service (child, &host->service);
+ if (status != 0) {
+ ERROR ("riemann plugin: Invalid argument "
+ "configured for the \"Port\" "
+ "option.");
break;
}
- host->port = status;
- status = 0;
} else if (strcasecmp(child->key, "delay") == 0) {
if ((status = cf_util_get_int(ci, &host->delay)) != 0)
break;
+ } else if (strcasecmp ("StoreRates", child->key) == 0) {
+ status = cf_util_get_boolean (ci, &host->store_rates);
+ if (status != 0)
+ break;
} else {
WARNING("riemann plugin: ignoring unknown config "
"option: \"%s\"", child->key);
}
}
if (status != 0) {
- sfree(host);
+ riemann_free (host);
return status;
}
- pthread_mutex_init(&host->lock, NULL);
- ssnprintf(w_cb_name, sizeof(w_cb_name), "write-riemann/%s:%d",
- host->name, host->port);
- ssnprintf(n_cb_name, sizeof(n_cb_name), "notification-riemann/%s:%d",
- host->name, host->port);
+ ssnprintf(w_cb_name, sizeof(w_cb_name), "write-riemann/%s:%s",
+ host->node,
+ (host->service != NULL) ? host->service : RIEMANN_PORT);
+ ssnprintf(n_cb_name, sizeof(n_cb_name), "notification-riemann/%s:%s",
+ host->node,
+ (host->service != NULL) ? host->service : RIEMANN_PORT);
DEBUG("riemann w_cb_name: %s", w_cb_name);
DEBUG("riemann n_cb_name: %s", n_cb_name);
ud.data = host;
ud.free_func = riemann_free;
- if ((status = plugin_register_write(w_cb_name, riemann_write, &ud)) != 0)
- riemann_free(host);
+ pthread_mutex_lock (&host->lock);
+
+ status = plugin_register_write (w_cb_name, riemann_write, &ud);
+ if (status != 0)
+ WARNING ("riemann plugin: plugin_register_write (\"%s\") "
+ "failed with status %i.",
+ w_cb_name, status);
+ else /* success */
+ host->reference_count++;
+
+ status = plugin_register_notification (n_cb_name,
+ riemann_notification, &ud);
+ if (status != 0)
+ WARNING ("riemann plugin: plugin_register_notification (\"%s\") "
+ "failed with status %i.",
+ n_cb_name, status);
+ else /* success */
+ host->reference_count++;
- if ((status = plugin_register_notification(n_cb_name,
- riemann_notification,
- &ud)) != 0) {
- plugin_unregister_write(w_cb_name);
- riemann_free(host);
+ if (host->reference_count <= 1)
+ {
+ /* Both callbacks failed => free memory.
+ * We need to unlock here, because riemann_free() will lock.
+ * This is not a race condition, because we're the only one
+ * holding a reference. */
+ pthread_mutex_unlock (&host->lock);
+ riemann_free (host);
+ return (-1);
}
+
+ host->reference_count--;
+ pthread_mutex_unlock (&host->lock);
+
return status;
}
riemann_config(oconfig_item_t *ci)
{
int i;
- char *newtag;
oconfig_item_t *child;
+ int status;
for (i = 0; i < ci->children_num; i++) {
child = &ci->children[i];
if (strcasecmp(child->key, "host") == 0) {
riemann_config_host(child);
} else if (strcasecmp(child->key, "tag") == 0) {
- if (riemann_tagcount >= RIEMANN_EXTRA_TAGS) {
- WARNING("riemann plugin: too many tags");
- return -1;
- }
- newtag = NULL;
- cf_util_get_string(child, &newtag);
- if (newtag == NULL)
- return -1;
- riemann_tags[riemann_tagcount++] = newtag;
- DEBUG("riemann_config: got tag: %s", newtag);
-
+ char *tmp = NULL;
+ status = cf_util_get_string(child, &tmp);
+ if (status != 0)
+ continue;
+
+ strarray_add (&riemann_tags, &riemann_tags_num, tmp);
+ DEBUG("riemann plugin: Got tag: %s", tmp);
+ sfree (tmp);
} else {
WARNING ("riemann plugin: Ignoring unknown "
"configuration option \"%s\" at top level.",
plugin_register_complex_config ("riemann", riemann_config);
}
+
+/* vim: set sw=8 sts=8 ts=8 noet : */
projects / collectd.git / blobdiff