/**
- * collectd - src/load.c
+ * collectd - src/routeros.c
* Copyright (C) 2009 Florian octo Forster
*
* This program is free software; you can redistribute it and/or modify it
char *service;
char *username;
char *password;
+
+ _Bool collect_interface;
+ _Bool collect_regtable;
};
typedef struct cr_data_s cr_data_t;
-static void cr_submit_io (const char *type, const char *type_instance, /* {{{ */
- counter_t rx, counter_t tx)
+static void cr_submit_io (cr_data_t *rd, const char *type, /* {{{ */
+ const char *type_instance, counter_t rx, counter_t tx)
{
value_t values[2];
value_list_t vl = VALUE_LIST_INIT;
vl.values = values;
vl.values_len = STATIC_ARRAY_SIZE (values);
- sstrncpy (vl.host, hostname_g, sizeof (vl.host));
+ sstrncpy (vl.host, rd->node, sizeof (vl.host));
sstrncpy (vl.plugin, "routeros", sizeof (vl.plugin));
sstrncpy (vl.type, type, sizeof (vl.type));
sstrncpy (vl.type_instance, type_instance, sizeof (vl.type_instance));
plugin_dispatch_values (&vl);
} /* }}} void cr_submit_io */
-static void submit_interface (const ros_interface_t *i) /* {{{ */
+static void submit_interface (cr_data_t *rd, /* {{{ */
+ const ros_interface_t *i)
{
if (i == NULL)
return;
if (!i->running)
{
- submit_interface (i->next);
+ submit_interface (rd, i->next);
return;
}
- cr_submit_io ("if_packets", i->name,
+ cr_submit_io (rd, "if_packets", i->name,
(counter_t) i->rx_packets, (counter_t) i->tx_packets);
- cr_submit_io ("if_octets", i->name,
+ cr_submit_io (rd, "if_octets", i->name,
(counter_t) i->rx_bytes, (counter_t) i->tx_bytes);
- cr_submit_io ("if_errors", i->name,
+ cr_submit_io (rd, "if_errors", i->name,
(counter_t) i->rx_errors, (counter_t) i->tx_errors);
- cr_submit_io ("if_dropped", i->name,
+ cr_submit_io (rd, "if_dropped", i->name,
(counter_t) i->rx_drops, (counter_t) i->tx_drops);
- submit_interface (i->next);
+ submit_interface (rd, i->next);
} /* }}} void submit_interface */
static int handle_interface (__attribute__((unused)) ros_connection_t *c, /* {{{ */
- const ros_interface_t *i, __attribute__((unused)) void *user_data)
+ const ros_interface_t *i, void *user_data)
{
- submit_interface (i);
+ if ((i == NULL) || (user_data == NULL))
+ return (EINVAL);
+
+ submit_interface (user_data, i);
return (0);
} /* }}} int handle_interface */
-static void cr_submit_gauge (const char *type, /* {{{ */
+static void cr_submit_gauge (cr_data_t *rd, const char *type, /* {{{ */
const char *type_instance, gauge_t value)
{
value_t values[1];
vl.values = values;
vl.values_len = STATIC_ARRAY_SIZE (values);
- sstrncpy (vl.host, hostname_g, sizeof (vl.host));
+ sstrncpy (vl.host, rd->node, sizeof (vl.host));
sstrncpy (vl.plugin, "routeros", sizeof (vl.plugin));
sstrncpy (vl.type, type, sizeof (vl.type));
sstrncpy (vl.type_instance, type_instance, sizeof (vl.type_instance));
plugin_dispatch_values (&vl);
} /* }}} void cr_submit_gauge */
-static void submit_regtable (const ros_registration_table_t *r) /* {{{ */
+static void submit_regtable (cr_data_t *rd, /* {{{ */
+ const ros_registration_table_t *r)
{
char type_instance[DATA_MAX_NAME_LEN];
/*** RX ***/
ssnprintf (type_instance, sizeof (type_instance), "%s-%s-rx",
r->interface, r->radio_name);
- cr_submit_gauge ("bitrate", type_instance,
+ cr_submit_gauge (rd, "bitrate", type_instance,
(gauge_t) (1000000.0 * r->rx_rate));
- cr_submit_gauge ("signal_power", type_instance,
+ cr_submit_gauge (rd, "signal_power", type_instance,
(gauge_t) r->rx_signal_strength);
- cr_submit_gauge ("signal_quality", type_instance,
+ cr_submit_gauge (rd, "signal_quality", type_instance,
(gauge_t) r->rx_ccq);
/*** TX ***/
ssnprintf (type_instance, sizeof (type_instance), "%s-%s-tx",
r->interface, r->radio_name);
- cr_submit_gauge ("bitrate", type_instance,
+ cr_submit_gauge (rd, "bitrate", type_instance,
(gauge_t) (1000000.0 * r->tx_rate));
- cr_submit_gauge ("signal_power", type_instance,
+ cr_submit_gauge (rd, "signal_power", type_instance,
(gauge_t) r->tx_signal_strength);
- cr_submit_gauge ("signal_quality", type_instance,
+ cr_submit_gauge (rd, "signal_quality", type_instance,
(gauge_t) r->tx_ccq);
/*** RX / TX ***/
ssnprintf (type_instance, sizeof (type_instance), "%s-%s",
r->interface, r->radio_name);
- cr_submit_io ("if_octets", type_instance,
+ cr_submit_io (rd, "if_octets", type_instance,
(counter_t) r->rx_bytes, (counter_t) r->tx_bytes);
- cr_submit_gauge ("snr", type_instance, (gauge_t) r->signal_to_noise);
+ cr_submit_gauge (rd, "snr", type_instance, (gauge_t) r->signal_to_noise);
- submit_regtable (r->next);
+ submit_regtable (rd, r->next);
} /* }}} void submit_regtable */
static int handle_regtable (__attribute__((unused)) ros_connection_t *c, /* {{{ */
- const ros_registration_table_t *r,
- __attribute__((unused)) void *user_data)
+ const ros_registration_table_t *r, void *user_data)
{
- submit_regtable (r);
+ if ((r == NULL) || (user_data == NULL))
+ return (EINVAL);
+
+ submit_regtable (user_data, r);
return (0);
} /* }}} int handle_regtable */
}
assert (rd->connection != NULL);
- status = ros_interface (rd->connection, handle_interface,
- /* user data = */ NULL);
- if (status != 0)
+ if (rd->collect_interface)
{
- char errbuf[128];
- ERROR ("routeros plugin: ros_interface failed: %s",
- sstrerror (status, errbuf, sizeof (errbuf)));
- ros_disconnect (rd->connection);
- rd->connection = NULL;
- return (-1);
+ status = ros_interface (rd->connection, handle_interface,
+ /* user data = */ rd);
+ if (status != 0)
+ {
+ char errbuf[128];
+ ERROR ("routeros plugin: ros_interface failed: %s",
+ sstrerror (status, errbuf, sizeof (errbuf)));
+ ros_disconnect (rd->connection);
+ rd->connection = NULL;
+ return (-1);
+ }
}
- status = ros_registration_table (rd->connection, handle_regtable,
- /* user data = */ NULL);
- if (status != 0)
+ if (rd->collect_regtable)
{
- char errbuf[128];
- ERROR ("routeros plugin: ros_registration_table failed: %s",
- sstrerror (status, errbuf, sizeof (errbuf)));
- ros_disconnect (rd->connection);
- rd->connection = NULL;
- return (-1);
+ status = ros_registration_table (rd->connection, handle_regtable,
+ /* user data = */ rd);
+ if (status != 0)
+ {
+ char errbuf[128];
+ ERROR ("routeros plugin: ros_registration_table failed: %s",
+ sstrerror (status, errbuf, sizeof (errbuf)));
+ ros_disconnect (rd->connection);
+ rd->connection = NULL;
+ return (-1);
+ }
}
return (0);
router_data->service = NULL;
router_data->username = NULL;
router_data->password = NULL;
+ router_data->collect_interface = false;
+ router_data->collect_regtable = false;
status = 0;
for (i = 0; i < ci->children_num; i++)
else if (strcasecmp ("User", child->key) == 0)
status = cf_util_get_string (child, &router_data->username);
else if (strcasecmp ("Password", child->key) == 0)
- status = cf_util_get_string (child, &router_data->service);
+ status = cf_util_get_string (child, &router_data->password);
+ else if (strcasecmp ("CollectInterface", child->key) == 0)
+ cf_util_get_boolean (child, &router_data->collect_interface);
+ else if (strcasecmp ("CollectRegistrationTable", child->key) == 0)
+ cf_util_get_boolean (child, &router_data->collect_regtable);
else
{
WARNING ("routeros plugin: Unknown config option `%s'.", child->key);
"How should I authenticate?");
status = -1;
}
+
+ if (!router_data->collect_interface
+ && !router_data->collect_regtable)
+ {
+ ERROR ("routeros plugin: No `Collect*' option within a `Router' block. "
+ "What statistics should I collect?");
+ status = -1;
+ }
}
if ((status == 0) && (router_data->username == NULL))