#endif /* HAVE_PROCINFO_H */
/* put name of process from config to list_head_g tree
- list_head_g is a list of 'procstat_t' structs with
- processes names we want to watch */
+ * list_head_g is a list of 'procstat_t' structs with
+ * processes names we want to watch */
static void ps_list_register (const char *name, const char *regexp)
{
procstat_t *new;
}
DEBUG ("name = %s; num_proc = %lu; num_lwp = %lu; "
- "vmem_size = %lu; vmem_rss = %lu; vmem_data = %lu; "
+ "vmem_size = %lu; vmem_rss = %lu; vmem_data = %lu; "
"vmem_code = %lu; "
"vmem_minflt_counter = %"PRIi64"; vmem_majflt_counter = %"PRIi64"; "
"cpu_user_counter = %"PRIi64"; cpu_system_counter = %"PRIi64"; "
continue;
numfields = strsplit (buffer, fields,
- STATIC_ARRAY_SIZE (fields));
+ STATIC_ARRAY_SIZE (fields));
if (numfields < 2)
continue;
#endif /*KERNEL_LINUX */
#if KERNEL_SOLARIS
-static char *ps_get_cmdline(pid_t pid)
+static const char *ps_get_cmdline (pid_t pid, /* {{{ */
+ char *buffer, size_t buffer_size)
{
- char f_psinfo[64];
- char cmdline[80];
- char *buffer = NULL;
- psinfo_t *myInfo;
+ char path[PATH_MAX];
+ psinfo_t info;
+ int status;
- snprintf(f_psinfo, sizeof (f_psinfo), "/proc/%i/psinfo", pid);
+ snprintf(path, sizeof (path), "/proc/%i/psinfo", pid);
- buffer = (char *)malloc(sizeof (psinfo_t));
- memset(buffer, 0, sizeof(psinfo_t));
- read_file_contents(f_psinfo, buffer, sizeof (psinfo_t));
- myInfo = (psinfo_t *) buffer;
+ status = read_file_contents (path, (void *) &info, sizeof (info));
+ if (status != sizeof (info))
+ {
+ ERROR ("processes plugin: Unexpected return value "
+ "while reading \"%s\": "
+ "Returned %i but expected %zu.",
+ path, status, buffer_size);
+ return (NULL);
+ }
- sstrncpy(cmdline, myInfo->pr_psargs, sizeof (myInfo->pr_psargs));
+ info.pr_psargs[sizeof (info.pr_psargs) - 1] = 0;
+ sstrncpy (buffer, info.pr_psargs, buffer_size);
- sfree(myInfo);
- return strtok(cmdline, " ");
-}
+ return (buffer);
+} /* }}} int ps_get_cmdline */
/*
* Reads process information on the Solaris OS. The information comes mainly from
{
char filename[64];
char f_psinfo[64], f_usage[64];
- int i;
char *buffer;
-
pstatus_t *myStatus;
psinfo_t *myInfo;
prusage_t *myUsage;
int wait = 0;
kvm_t *kd;
- char errbuf[1024];
- struct kinfo_proc *procs; /* array of processes */
+ char errbuf[_POSIX2_LINE_MAX];
+ struct kinfo_proc *procs; /* array of processes */
struct kinfo_proc *proc_ptr = NULL;
- int count; /* returns number of processes */
+ int count; /* returns number of processes */
int i;
procstat_t *ps_ptr;
ps_list_reset ();
/* Open the kvm interface, get a descriptor */
- kd = kvm_open (NULL, NULL, NULL, 0, errbuf);
+ kd = kvm_openfiles (NULL, "/dev/null", NULL, 0, errbuf);
if (kd == NULL)
{
ERROR ("processes plugin: Cannot open kvm interface: %s",
if (procentry[i].pi_pid == 0)
cmdline = "swapper";
cargs = cmdline;
- }
+ }
else
{
if (getargs(&procentry[i], sizeof(struct procentry64), arglist, MAXARGLN) >= 0)
#elif KERNEL_SOLARIS
/*
- * The Solaris section adds a few more process states and removes some
- * process states compared to linux. Most notably there is no "PAGING"
- * and "BLOCKED" state for a process. The rest is similar to the linux
- * code.
+ * The Solaris section adds a few more process states and removes some
+ * process states compared to linux. Most notably there is no "PAGING"
+ * and "BLOCKED" state for a process. The rest is similar to the linux
+ * code.
*/
int running = 0;
int sleeping = 0;
int daemon = 0;
int system = 0;
int orphan = 0;
+
struct dirent *ent;
DIR *proc;
- int pid;
int status;
- struct procstat ps;
- procstat_entry_t pse;
procstat_t *ps_ptr;
char state;
- ps_list_reset();
+ char cmdline[PRARGSZ];
+ ps_list_reset ();
- proc = opendir("/proc");
- if (proc == NULL) {
+ proc = opendir ("/proc");
+ if (proc == NULL)
return (-1);
- }
- while ((ent = readdir(proc)) != NULL) {
- if (!isdigit(ent->d_name[0]))
+ while ((ent = readdir(proc)) != NULL)
+ {
+ int pid;
+ struct procstat ps;
+ procstat_entry_t pse;
+
+ if (!isdigit ((int) ent->d_name[0]))
continue;
- if ((pid = atoi(ent->d_name)) < 1)
+ if ((pid = atoi (ent->d_name)) < 1)
continue;
- status = ps_read_process(pid, &ps, &state);
- if (status != 0) {
+ status = ps_read_process (pid, &ps, &state);
+ if (status != 0)
+ {
DEBUG("ps_read_process failed: %i", status);
continue;
}
+
pse.id = pid;
pse.age = 0;
- pse.num_proc = ps.num_proc;
- pse.num_lwp = ps.num_lwp;
- pse.vmem_size = ps.vmem_size;
- pse.vmem_rss = ps.vmem_rss;
- pse.vmem_data = ps.vmem_data;
- pse.vmem_code = ps.vmem_code;
+ pse.num_proc = ps.num_proc;
+ pse.num_lwp = ps.num_lwp;
+ pse.vmem_size = ps.vmem_size;
+ pse.vmem_rss = ps.vmem_rss;
+ pse.vmem_data = ps.vmem_data;
+ pse.vmem_code = ps.vmem_code;
pse.stack_size = ps.stack_size;
pse.vmem_minflt = 0;
pse.io_syscr = ps.io_syscr;
pse.io_syscw = ps.io_syscw;
- switch (state) {
- case 'R': running++;
- break;
- case 'S': sleeping++;
- break;
- case 'E': detached++;
- break;
- case 'Z': zombies++;
- break;
- case 'T': stopped++;
- break;
- case 'A': daemon++;
- break;
- case 'Y': system++;
- break;
- case 'O': orphan++;
- break;
+ switch (state)
+ {
+ case 'R': running++; break;
+ case 'S': sleeping++; break;
+ case 'E': detached++; break;
+ case 'Z': zombies++; break;
+ case 'T': stopped++; break;
+ case 'A': daemon++; break;
+ case 'Y': system++; break;
+ case 'O': orphan++; break;
}
- ps_list_add(ps.name, ps_get_cmdline(pid), &pse);
- } // while()
+ ps_list_add (ps.name,
+ ps_get_cmdline ((pid_t) pid,
+ cmdline, sizeof (cmdline)),
+ &pse);
+ } /* while(readdir) */
closedir (proc);
ps_submit_state ("running", running);
projects / collectd.git / blobdiff