src/utils_cmd_flush.c: Fix parsing of the "timeout" option.

[collectd.git] / src / utils_cmd_flush.c

diff --git a/src/utils_cmd_flush.c b/src/utils_cmd_flush.c
index b1973be..3584f3b 100644 (file)
--- a/src/utils_cmd_flush.c
+++ b/src/utils_cmd_flush.c
@@ -24,65 +24,156 @@
 #include "collectd.h"
 #include "common.h"
 #include "plugin.h"
+#include "utils_parse_option.h"
 
-int handle_flush (FILE *fh, char **fields, int fields_num)
+#define print_to_socket(fh, ...) \
+       if (fprintf (fh, __VA_ARGS__) < 0) { \
+               char errbuf[1024]; \
+               WARNING ("handle_flush: failed to write to socket #%i: %s", \
+                               fileno (fh), sstrerror (errno, errbuf, sizeof (errbuf))); \
+               return -1; \
+       }
+
+static int add_to_array (char ***array, int *array_num, char *value)
+{
+       char **temp;
+
+       temp = (char **) realloc (*array, sizeof (char *) * (*array_num + 1));
+       if (temp == NULL)
+               return (-1);
+
+       *array = temp;
+       (*array)[*array_num] = value;
+       (*array_num)++;
+
+       return (0);
+} /* int add_to_array */
+
+int handle_flush (FILE *fh, char *buffer)
 {
        int success = 0;
        int error   = 0;
 
-       int timeout = -1;
+       double timeout = 0.0;
+       char **plugins = NULL;
+       int plugins_num = 0;
+       char **identifiers = NULL;
+       int identifiers_num = 0;
 
        int i;
 
-       for (i = 1; i < fields_num; i++)
+       if ((fh == NULL) || (buffer == NULL))
+               return (-1);
+
+       DEBUG ("utils_cmd_flush: handle_flush (fh = %p, buffer = %s);",
+                       (void *) fh, buffer);
+
+       if (strncasecmp ("FLUSH", buffer, strlen ("FLUSH")) != 0)
+       {
+               print_to_socket (fh, "-1 Cannot parse command.\n");
+               return (-1);
+       }
+       buffer += strlen ("FLUSH");
+
+       while (*buffer != 0)
        {
-               char *option = fields[i];
-               int   status = 0;
+               char *opt_key;
+               char *opt_value;
+               int status;
 
-               if (strncasecmp ("plugin=", option, strlen ("plugin=")) == 0)
+               opt_key = NULL;
+               opt_value = NULL;
+               status = parse_option (&buffer, &opt_key, &opt_value);
+               if (status != 0)
                {
-                       char *plugin = option + strlen ("plugin=");
+                       print_to_socket (fh, "-1 Parsing options failed.\n");
+                       sfree (plugins);
+                       sfree (identifiers);
+                       return (-1);
+               }
 
-                       if (0 == plugin_flush_one (timeout, plugin))
-                               ++success;
-                       else
-                               ++error;
+               if (strcasecmp ("plugin", opt_key) == 0)
+               {
+                       add_to_array (&plugins, &plugins_num, opt_value);
                }
-               else if (strncasecmp ("timeout=", option, strlen ("timeout=")) == 0)
+               else if (strcasecmp ("identifier", opt_key) == 0)
                {
-                       char *endptr = NULL;
-                       char *value  = option + strlen ("timeout=");
-
+                       add_to_array (&identifiers, &identifiers_num, opt_value);
+               }
+               else if (strcasecmp ("timeout", opt_key) == 0)
+               {
+                       char *endptr;
+                       
                        errno = 0;
-                       timeout = strtol (value, &endptr, 0);
+                       endptr = NULL;
+                       timeout = strtod (opt_value, &endptr);
 
-                       if ((endptr == value) || (0 != errno))
-                               status = -1;
-                       else if (0 >= timeout)
-                               timeout = -1;
+                       if ((endptr == opt_value) || (errno != 0) || (!isfinite (timeout)))
+                       {
+                               print_to_socket (fh, "-1 Invalid value for option `timeout': "
+                                               "%s\n", opt_value);
+                               sfree (plugins);
+                               sfree (identifiers);
+                               return (-1);
+                       }
+                       else if (timeout < 0.0)
+                       {
+                               timeout = 0.0;
+                       }
                }
                else
-                       status = -1;
-
-               if (status != 0)
                {
-                       fprintf (fh, "-1 Cannot parse option %s\n", option);
-                       fflush (fh);
+                       print_to_socket (fh, "-1 Cannot parse option %s\n", opt_key);
+                       sfree (plugins);
+                       sfree (identifiers);
                        return (-1);
                }
+       } /* while (*buffer != 0) */
+
+       /* Add NULL entries for `any plugin' and/or `any value' if nothing was
+        * specified. */
+       if (plugins_num == 0)
+               add_to_array (&plugins, &plugins_num, NULL);
+
+       if (identifiers_num == 0)
+               add_to_array (&identifiers, &identifiers_num, NULL);
+
+       for (i = 0; i < plugins_num; i++)
+       {
+               char *plugin;
+               int j;
+
+               plugin = plugins[i];
+
+               for (j = 0; j < identifiers_num; j++)
+               {
+                       char *identifier;
+                       int status;
+
+                       identifier = identifiers[j];
+                       status = plugin_flush (plugin,
+                                       DOUBLE_TO_CDTIME_T (timeout),
+                                       identifier);
+                       if (status == 0)
+                               success++;
+                       else
+                               error++;
+               }
        }
 
        if ((success + error) > 0)
        {
-               fprintf (fh, "0 Done: %i successful, %i errors\n", success, error);
+               print_to_socket (fh, "0 Done: %i successful, %i errors\n",
+                               success, error);
        }
        else
        {
-               plugin_flush_all (timeout);
-               fprintf (fh, "0 Done\n");
+               plugin_flush (NULL, timeout, NULL);
+               print_to_socket (fh, "0 Done\n");
        }
-       fflush (fh);
 
+       sfree (plugins);
+       sfree (identifiers);
        return (0);
 } /* int handle_flush */