oconfig_item_t *c = ci->children + i;
if (strcasecmp(c->key, "Connection") == 0) {
- if (cf_util_get_string(c, &conn_string) != 0 || conn_string == NULL) {
- ERROR(PLUGIN_NAME " plugin: Could not get 'Connection' parameter");
+ if (cf_util_get_string(c, &conn_string) != 0 || conn_string == NULL)
return -1;
- }
continue;
} else if (strcasecmp(c->key, "RefreshInterval") == 0) {
- if (cf_util_get_int(c, &interval) != 0) {
- ERROR(PLUGIN_NAME " plugin: Could not get 'RefreshInterval' parameter");
+ if (cf_util_get_int(c, &interval) != 0)
return -1;
- }
continue;
} else if (strcasecmp(c->key, "Domain") == 0) {
char *domain_name = NULL;
- if (cf_util_get_string(c, &domain_name) != 0 || domain_name == NULL) {
- ERROR(PLUGIN_NAME " plugin: Could not get 'Domain' parameter");
+ if (cf_util_get_string(c, &domain_name) != 0)
return -1;
- }
if (ignorelist_add(il_domains, domain_name)) {
ERROR(PLUGIN_NAME " plugin: Adding '%s' to domain-ignorelist failed",
continue;
} else if (strcasecmp(c->key, "BlockDevice") == 0) {
char *device_name = NULL;
- if (cf_util_get_string(c, &device_name) != 0 || device_name == NULL) {
- ERROR(PLUGIN_NAME " plugin: Could not get 'BlockDevice' parameter");
+ if (cf_util_get_string(c, &device_name) != 0)
return -1;
- }
if (ignorelist_add(il_block_devices, device_name) != 0) {
ERROR(PLUGIN_NAME
continue;
} else if (strcasecmp(c->key, "BlockDeviceFormat") == 0) {
char *device_format = NULL;
- if (cf_util_get_string(c, &device_format) != 0 || device_format == NULL) {
- ERROR(PLUGIN_NAME
- " plugin: Could not get 'BlockDeviceFormat' parameter");
+ if (cf_util_get_string(c, &device_format) != 0)
return -1;
- }
if (strcasecmp(device_format, "target") == 0)
blockdevice_format = target;
sfree(device_format);
continue;
} else if (strcasecmp(c->key, "BlockDeviceFormatBasename") == 0) {
- if (cf_util_get_boolean(c, &blockdevice_format_basename) != 0) {
- ERROR(PLUGIN_NAME
- " plugin: Could not get 'BlockDeviceFormatBasename' parameter");
+ if (cf_util_get_boolean(c, &blockdevice_format_basename) != 0)
return -1;
- }
continue;
} else if (strcasecmp(c->key, "InterfaceDevice") == 0) {
char *interface_name = NULL;
- if (cf_util_get_string(c, &interface_name) != 0 ||
- interface_name == NULL) {
- ERROR(PLUGIN_NAME " plugin: Could not get 'InterfaceDevice' parameter");
+ if (cf_util_get_string(c, &interface_name) != 0)
return -1;
- }
if (ignorelist_add(il_interface_devices, interface_name)) {
ERROR(PLUGIN_NAME " plugin: Adding '%s' to interface-ignorelist failed",
continue;
} else if (strcasecmp(c->key, "IgnoreSelected") == 0) {
bool ignore_selected = false;
- if (cf_util_get_boolean(c, &ignore_selected) != 0) {
- ERROR(PLUGIN_NAME " plugin: Could not get 'IgnoreSelected' parameter");
+ if (cf_util_get_boolean(c, &ignore_selected) != 0)
return -1;
- }
if (ignore_selected) {
ignorelist_set_invert(il_domains, 0);
continue;
} else if (strcasecmp(c->key, "HostnameMetadataNS") == 0) {
- if (cf_util_get_string(c, &hm_ns) != 0) {
- ERROR(PLUGIN_NAME
- " plugin: Could not get 'HostnameMetadataNS' parameter");
+ if (cf_util_get_string(c, &hm_ns) != 0)
return -1;
- }
continue;
} else if (strcasecmp(c->key, "HostnameMetadataXPath") == 0) {
- if (cf_util_get_string(c, &hm_xpath) != 0) {
- ERROR(PLUGIN_NAME
- " plugin: Could not get 'HostnameMetadataXPath' parameter");
+ if (cf_util_get_string(c, &hm_xpath) != 0)
return -1;
- }
continue;
} else if (strcasecmp(c->key, "HostnameFormat") == 0) {
continue;
} else if (strcasecmp(c->key, "InterfaceFormat") == 0) {
char *format = NULL;
- if (cf_util_get_string(c, &format) != 0 || format == NULL) {
- ERROR(PLUGIN_NAME " plugin: could not get 'InterfaceFormat' parameter");
+ if (cf_util_get_string(c, &format) != 0)
return -1;
- }
if (strcasecmp(format, "name") == 0)
interface_format = if_name;
sfree(format);
continue;
} else if (strcasecmp(c->key, "Instances") == 0) {
- if (cf_util_get_int(c, &nr_instances) != 0) {
- ERROR(PLUGIN_NAME " plugin: could not get 'Instances' parameter");
+ if (cf_util_get_int(c, &nr_instances) != 0)
return -1;
- }
if (nr_instances <= 0) {
ERROR(PLUGIN_NAME " plugin: Instances <= 0 makes no sense.");
} else if (strcasecmp(c->key, "ExtraStats") == 0) {
char *ex_str = NULL;
- if (cf_util_get_string(c, &ex_str) != 0 || ex_str == NULL) {
- ERROR(PLUGIN_NAME " plugin: could not get 'ExtraStats' parameter");
+ if (cf_util_get_string(c, &ex_str) != 0)
return -1;
- }
char *exstats[EX_STATS_MAX_FIELDS];
int numexstats = strsplit(ex_str, exstats, STATIC_ARRAY_SIZE(exstats));
}
#endif
- /* ExtraStats parsed successfully*/
+ /* ExtraStats parsed successfully */
continue;
} else if (strcasecmp(c->key, "PersistentNotification") == 0) {
- if (cf_util_get_boolean(c, &persistent_notification) != 0) {
- ERROR(PLUGIN_NAME
- " plugin: could not get 'PersistentNotification' parameter");
+ if (cf_util_get_boolean(c, &persistent_notification) != 0)
return -1;
- }
continue;
} else if (strcasecmp(c->key, "ReportBlockDevices") == 0) {
- if (cf_util_get_boolean(c, &report_block_devices) != 0) {
- ERROR(PLUGIN_NAME
- " plugin: could not get 'ReportBlockDevices' parameter");
+ if (cf_util_get_boolean(c, &report_block_devices) != 0)
return -1;
- }
continue;
} else if (strcasecmp(c->key, "ReportNetworkInterfaces") == 0) {
- if (cf_util_get_boolean(c, &report_network_interfaces) != 0) {
- ERROR(PLUGIN_NAME
- " plugin: could not get 'ReportNetworkInterfaces' parameter");
+ if (cf_util_get_boolean(c, &report_network_interfaces) != 0)
return -1;
- }
continue;
} else {
#endif /* HAVE_CPU_STATS */
#ifdef HAVE_DOM_REASON
-
-static void domain_state_submit(virDomainPtr dom, int state, int reason) {
- value_t values[] = {
- {.gauge = (gauge_t)state}, {.gauge = (gauge_t)reason},
- };
-
- submit(dom, "domain_state", NULL, values, STATIC_ARRAY_SIZE(values));
-}
-
-static int get_domain_state(virDomainPtr domain) {
+static int submit_domain_state(virDomainPtr domain) {
int domain_state = 0;
int domain_reason = 0;
return status;
}
- domain_state_submit(domain, domain_state, domain_reason);
+ value_t values[] = {
+ {.gauge = (gauge_t)domain_state}, {.gauge = (gauge_t)domain_reason},
+ };
+
+ submit(domain, "domain_state", NULL, values, STATIC_ARRAY_SIZE(values));
- return status;
+ return 0;
}
#ifdef HAVE_LIST_ALL_DOMAINS
return status;
}
- if (persistent_notification)
- domain_state_submit_notif(domain, domain_state, domain_reason);
+ domain_state_submit_notif(domain, domain_state, domain_reason);
return status;
}
* however it doesn't provide a reason for entering particular state.
* We need to get it from virDomainGetState.
*/
- GET_STATS(get_domain_state, "domain reason", domain->ptr);
+ GET_STATS(submit_domain_state, "domain reason", domain->ptr);
#endif
}
return -1;
}
+ DEBUG(PLUGIN_NAME " plugin: starting event loop");
+
virt_notif_thread_set_active(thread_data, 1);
if (pthread_create(&thread_data->event_loop_tid, NULL, event_loop_worker,
thread_data)) {
ERROR(PLUGIN_NAME " plugin: failed event loop thread creation");
+ virt_notif_thread_set_active(thread_data, 0);
virConnectDomainEventDeregisterAny(conn, thread_data->domain_event_cb_id);
+ thread_data->domain_event_cb_id = -1;
return -1;
}
/* stop event loop thread and deregister callback */
static void stop_event_loop(virt_notif_thread_t *thread_data) {
- /* stopping loop and de-registering event handler*/
- virt_notif_thread_set_active(thread_data, 0);
- if (conn != NULL && thread_data->domain_event_cb_id != -1)
- virConnectDomainEventDeregisterAny(conn, thread_data->domain_event_cb_id);
- if (pthread_join(notif_thread.event_loop_tid, NULL) != 0)
- ERROR(PLUGIN_NAME " plugin: stopping notification thread failed");
+ DEBUG(PLUGIN_NAME " plugin: stopping event loop");
+
+ /* Stopping loop */
+ if (virt_notif_thread_is_active(thread_data)) {
+ virt_notif_thread_set_active(thread_data, 0);
+ if (pthread_join(notif_thread.event_loop_tid, NULL) != 0)
+ ERROR(PLUGIN_NAME " plugin: stopping notification thread failed");
+ }
+
+ /* ... and de-registering event handler */
+ if (conn != NULL && thread_data->domain_event_cb_id != -1) {
+ virConnectDomainEventDeregisterAny(conn, thread_data->domain_event_cb_id);
+ thread_data->domain_event_cb_id = -1;
+ }
}
static int persistent_domains_state_notification(void) {
if (dom->active)
status = get_domain_metrics(dom);
#ifdef HAVE_DOM_REASON
- else
- status = get_domain_state(dom->ptr);
+ else if (extra_stats & ex_stats_domain_state)
+ status = submit_domain_state(dom->ptr);
#endif
if (status != 0)
if (lv_connect() != 0)
return -1;
- DEBUG(PLUGIN_NAME " plugin: starting event loop");
-
if (!persistent_notification) {
virt_notif_thread_init(¬if_thread);
if (start_event_loop(¬if_thread) != 0)
lv_fini_instance(i);
}
- DEBUG(PLUGIN_NAME " plugin: stopping event loop");
-
if (!persistent_notification)
stop_event_loop(¬if_thread);