utils_ovs: Avoid potential access of freed memory
authorCiara Loftus <ciara.loftus@intel.com>
Tue, 29 May 2018 13:46:31 +0000 (14:46 +0100)
committerCiara Loftus <ciara.loftus@intel.com>
Tue, 29 May 2018 13:48:49 +0000 (14:48 +0100)
Fixes #2800
Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
src/utils_ovs.c

index 3b7236c..4ca86ae 100644 (file)
@@ -1051,6 +1051,8 @@ ovs_db_t *ovs_db_init(const char *node, const char *service,
     ret = ovs_db_destroy(pdb);
     if (ret > 0)
       goto failure;
+    else
+      return NULL;
   }
 
   /* init polling thread */
@@ -1059,6 +1061,8 @@ ovs_db_t *ovs_db_init(const char *node, const char *service,
     if (ret > 0) {
       ovs_db_event_thread_data_destroy(pdb);
       goto failure;
+    } else {
+      return NULL;
     }
   }
   return pdb;