Fixed rrdtool sigsegv (datadir==NULL ptr dereferencing)
authorClaudius Zingerli <gitmail@zeuz.ch>
Tue, 5 Jan 2016 17:22:22 +0000 (18:22 +0100)
committerMarc Fournier <marc.fournier@camptocamp.com>
Wed, 13 Jan 2016 20:55:08 +0000 (21:55 +0100)
src/rrdtool.c

index 9b04d10..7cfdae6 100644 (file)
@@ -1018,11 +1018,11 @@ static int rrd_config (const char *key, const char *value)
                        return (1);
                }
 
-               len = strlen (datadir);
-               while ((len > 0) && (datadir[len - 1] == '/'))
+               len = strlen (tmp);
+               while ((len > 0) && (tmp[len - 1] == '/'))
                {
                        len--;
-                       datadir[len] = 0;
+                       tmp[len] = 0;
                }
 
                if (len == 0)
@@ -1032,7 +1032,11 @@ static int rrd_config (const char *key, const char *value)
                        return (1);
                }
 
-               sfree (datadir);
+               if (datadir != NULL)
+               {
+                       sfree (datadir);
+               }
+
                datadir = tmp;
        }
        else if (strcasecmp ("StepSize", key) == 0)