Merge branch 'sp/reflog' into next
authorJunio C Hamano <junkio@cox.net>
Wed, 31 May 2006 22:23:54 +0000 (15:23 -0700)
committerJunio C Hamano <junkio@cox.net>
Wed, 31 May 2006 22:23:54 +0000 (15:23 -0700)
* sp/reflog:
  fetch.c: do not pass uninitialized lock to unlock_ref().

fetch.c

diff --git a/fetch.c b/fetch.c
index e9347ba..1291bba 100644 (file)
--- a/fetch.c
+++ b/fetch.c
@@ -209,7 +209,7 @@ static int mark_complete(const char *path, const unsigned char *sha1)
 
 int pull(char *target)
 {
-       struct ref_lock *lock;
+       struct ref_lock *lock = NULL;
        unsigned char sha1[20];
        char *msg;
        int ret;
@@ -229,15 +229,18 @@ int pull(char *target)
 
        if (interpret_target(target, sha1)) {
                error("Could not interpret %s as something to pull", target);
-               unlock_ref(lock);
+               if (lock)
+                       unlock_ref(lock);
                return -1;
        }
        if (process(lookup_unknown_object(sha1))) {
-               unlock_ref(lock);
+               if (lock)
+                       unlock_ref(lock);
                return -1;
        }
        if (loop()) {
-               unlock_ref(lock);
+               if (lock)
+                       unlock_ref(lock);
                return -1;
        }