Tweaked the backflip timer so that Tux cannot cancel backflip after an arbitrarily...

[supertux.git] / src / object / player.cpp

diff --git a/src/object/player.cpp b/src/object/player.cpp
index a9162b5..0fc1053 100644 (file)
--- a/src/object/player.cpp
+++ b/src/object/player.cpp
@@ -74,7 +74,7 @@ static const float MAX_WALK_XM = 230;
 /** maximum run velocity (pixel/s) */
 static const float MAX_RUN_XM = 320;
 /** maximum horizontal climb velocity */
-static const float MAX_CLIMB_XM = 48;
+static const float MAX_CLIMB_XM = 96;
 /** maximum vertical climb velocity */
 static const float MAX_CLIMB_YM = 128;
 /** instant velocity when tux starts to walk */
@@ -99,6 +99,13 @@ static const float JUMP_EARLY_APEX_FACTOR = 3.0;
 
 static const float JUMP_GRACE_TIME = 0.25f; /**< time before hitting the ground that the jump button may be pressed (and still trigger a jump) */
 
+/* Tux's collision rectangle */
+static const float TUX_WIDTH = 31.8f;
+static const float RUNNING_TUX_WIDTH = 34;
+static const float SMALL_TUX_HEIGHT = 30.8f;
+static const float BIG_TUX_HEIGHT = 62.8f;
+static const float DUCKED_TUX_HEIGHT = 31.8f;
+
 bool no_water = true;
 }
 
@@ -152,8 +159,11 @@ Player::Player(PlayerStatus* _player_status, const std::string& name) :
   climbing(0)
 {
   this->name = name;
-  controller = g_main_controller;
+  controller = g_jk_controller->get_main_controller();
   scripting_controller.reset(new CodeController());
+  // if/when we have complete penny gfx, we can
+  // load those instead of Tux's sprite in the
+  // constructor
   sprite = sprite_manager->create("images/creatures/tux/tux.sprite");
   airarrow = Surface::create("images/engine/hud/airarrow.png");
   idle_timer.start(IDLE_TIME[0]/1000.0f);
@@ -179,9 +189,9 @@ void
 Player::init()
 {
   if(is_big())
-    set_size(31.8f, 62.8f);
+    set_size(TUX_WIDTH, BIG_TUX_HEIGHT);
   else
-    set_size(31.8f, 30.8f);
+    set_size(TUX_WIDTH, SMALL_TUX_HEIGHT);
 
   dir = RIGHT;
   old_dir = dir;
@@ -189,6 +199,7 @@ Player::init()
   dead = false;
 
   dying = false;
+  winning = false;
   peekingX = AUTO;
   peekingY = AUTO;
   last_ground_y = 0;
@@ -252,6 +263,15 @@ Player::set_controller(Controller* controller)
   this->controller = controller;
 }
 
+void
+Player::set_winning()
+{
+  if( ! is_winning() ){
+    winning = true;
+    invincible_timer.start(10000.0f);
+  }
+}
+
 void 
 Player::use_scripting_controller(bool use_or_release)
 {
@@ -282,6 +302,7 @@ Player::adjust_height(float new_height)
   bbox2.move(Vector(0, bbox.get_height() - new_height));
   bbox2.set_height(new_height);
 
+
   if(new_height > bbox.get_height()) {
     Rectf additional_space = bbox2;
     additional_space.set_height(new_height - bbox.get_height());
@@ -300,6 +321,8 @@ void
 Player::trigger_sequence(std::string sequence_name)
 {
   if (climbing) stop_climbing(*climbing);
+  backflipping = false;
+  backflip_direction = 0;
   GameSession::current()->start_sequence(sequence_name);
 }
 
@@ -326,9 +349,9 @@ Player::update(float elapsed_time)
   // extend/shrink tux collision rectangle so that we fall through/walk over 1
   // tile holes
   if(fabsf(physic.get_velocity_x()) > MAX_WALK_XM) {
-    set_width(34);
+    set_width(RUNNING_TUX_WIDTH);
   } else {
-    set_width(31.8f);
+    set_width(TUX_WIDTH);
   }
 
   // on downward slopes, adjust vertical velocity so tux walks smoothly down
@@ -361,7 +384,7 @@ Player::update(float elapsed_time)
   // check if we landed
   if(on_ground()) {
     jumping = false;
-    if (backflipping && (!backflip_timer.started())) {
+    if (backflipping && (backflip_timer.get_timegone() > 0.15f)) {
       backflipping = false;
       backflip_direction = 0;
 
@@ -412,6 +435,14 @@ Player::update(float elapsed_time)
     if (sprite->animation_done()) growing = false;
   }
 
+  // when climbing animate only while moving
+  if(climbing){
+    if((physic.get_velocity_x()==0)&&(physic.get_velocity_y()==0))
+      sprite->stop_animation();
+    else
+      sprite->set_animation_loops(-1);
+  }
+
 }
 
 bool
@@ -467,8 +498,8 @@ Player::handle_horizontal_input()
     }
   }
 
-  // do not run if we're holding something
-  if ( false /* grabbed_extra_heavy_object */) {
+  // do not run if we're holding something which slows us down
+  if ( grabbed_object && grabbed_object->is_hampering() ) {
     ax = dirsign * WALK_ACCELERATION_X;
     // limit speed
     if(vx >= MAX_WALK_XM && dirsign > 0) {
@@ -561,7 +592,7 @@ Player::do_duck() {
   if (does_buttjump)
     return;
 
-  if (adjust_height(31.8f)) {
+  if (adjust_height(DUCKED_TUX_HEIGHT)) {
     duck = true;
     growing = false;
     unduck_hurt_timer.stop();
@@ -579,7 +610,7 @@ Player::do_standup() {
   if (backflipping)
     return;
 
-  if (adjust_height(63.8f)) {
+  if (adjust_height(BIG_TUX_HEIGHT)) {
     duck = false;
     unduck_hurt_timer.stop();
   } else {
@@ -605,7 +636,7 @@ Player::do_backflip() {
   backflipping = true;
   do_jump(-580);
   sound_manager->play("sounds/flip.wav");
-  backflip_timer.start(0.15f);
+  backflip_timer.start(TUX_BACKFLIP_TIME);
 }
 
 void
@@ -785,7 +816,7 @@ Player::handle_input()
         dest.p1.x = bbox.get_right() + 1;
         dest.p2.x = dest.p1.x + grabbed_bbox.get_width();
       }
-      if(Sector::current()->is_free_of_movingstatics(dest)) {
+      if(Sector::current()->is_free_of_tiles(dest, true)) {
         moving_object->set_pos(dest.p1);
         if(controller->hold(Controller::UP)) {
           grabbed_object->ungrab(*this, UP);
@@ -798,6 +829,12 @@ Player::handle_input()
       log_debug << "Non MovingObject grabbed?!?" << std::endl;
     }
   }
+
+  /* stop backflipping at will */
+  if( backflipping && ( !controller->hold(Controller::JUMP) && !backflip_timer.started()) ){
+    backflipping = false;
+    backflip_direction = 0;
+  }
 }
 
 void
@@ -941,9 +978,9 @@ Player::add_bonus(BonusType type, bool animate)
 bool
 Player::set_bonus(BonusType type, bool animate)
 {
-  if(player_status->bonus == NO_BONUS) {
-    if (!adjust_height(62.8f)) {
-      printf("can't adjust\n");
+  if((player_status->bonus == NO_BONUS) && (type != NO_BONUS)) {
+    if (!adjust_height(BIG_TUX_HEIGHT)) {
+      log_debug << "Can't adjust Tux height" << std::endl;
       return false;
     }
     if(animate) {
@@ -1050,7 +1087,7 @@ Player::draw(DrawingContext& context)
     // update() will take care of cancelling when growing completed
   }
   else if (climbing) {
-    sprite->set_action(sa_prefix+"-skid"+sa_postfix);
+    sprite->set_action(sa_prefix+"-climbing"+sa_postfix);
   }
   else if (backflipping) {
     sprite->set_action(sa_prefix+"-backflip"+sa_postfix);
@@ -1202,6 +1239,11 @@ Player::collision(GameObject& other, const CollisionHit& hit)
     return FORCE_MOVE;
   }
 
+  Player* player = dynamic_cast<Player*> (&other);
+  if(player) {
+    return ABORT_MOVE;
+  }
+
   if(hit.left || hit.right) {
     try_grab(); //grab objects right now, in update it will be too late
   }
@@ -1240,7 +1282,7 @@ Player::make_invincible()
 void
 Player::kill(bool completely)
 {
-  if(dying || deactivated)
+  if(dying || deactivated || is_winning() )
     return;
 
   if(!completely && (safe_timer.started() || invincible_timer.started()))
@@ -1261,13 +1303,13 @@ Player::kill(bool completely)
       set_bonus(GROWUP_BONUS, true);
     } else if(player_status->bonus == GROWUP_BONUS) {
       safe_timer.start(TUX_SAFE_TIME /* + GROWING_TIME */);
-      adjust_height(30.8f);
+      adjust_height(SMALL_TUX_HEIGHT);
       duck = false;
       backflipping = false;
       set_bonus(NO_BONUS, true);
     } else if(player_status->bonus == NO_BONUS) {
       safe_timer.start(TUX_SAFE_TIME);
-      adjust_height(30.8f);
+      adjust_height(SMALL_TUX_HEIGHT);
       duck = false;
     }
   } else {
@@ -1305,6 +1347,7 @@ Player::kill(bool completely)
     dying_timer.start(3.0);
     set_group(COLGROUP_DISABLED);
 
+    // TODO: need nice way to handle players dying in co-op mode
     Sector::current()->effect->fade_out(3.0);
     sound_manager->stop_music(3.0);
   }
@@ -1315,11 +1358,11 @@ Player::move(const Vector& vector)
 {
   set_pos(vector);
 
-  // TODO: do we need the following? Seems irrelevant to moving the player
+  // Reset size to get correct hitbox if Tux was eg. ducked before moving
   if(is_big())
-    set_size(31.8f, 63.8f);
+    set_size(TUX_WIDTH, BIG_TUX_HEIGHT);
   else
-    set_size(31.8f, 31.8f);
+    set_size(TUX_WIDTH, SMALL_TUX_HEIGHT);
   duck = false;
   backflipping = false;
   last_ground_y = vector.y;
@@ -1443,12 +1486,16 @@ Player::set_edit_mode(bool enable)
 void 
 Player::start_climbing(Climbable& climbable)
 {
-  if (climbing == &climbable) return;
+  if (climbing || !&climbable) return;
 
   climbing = &climbable;
   physic.enable_gravity(false);
   physic.set_velocity(0, 0);
   physic.set_acceleration(0, 0);
+  if (backflipping) {
+    backflipping = false;
+    backflip_direction = 0;
+  }
 }
 
 void