Many many fixes. This version is actually kind of useable.

[onis.git] / lib / Onis / Plugins / Core.pm

diff --git a/lib/Onis/Plugins/Core.pm b/lib/Onis/Plugins/Core.pm
index 5294483..1b05bab 100644 (file)
--- a/lib/Onis/Plugins/Core.pm
+++ b/lib/Onis/Plugins/Core.pm
@@ -24,7 +24,7 @@ use Onis::Users (qw(get_realname get_link get_image ident_to_name));
 use Onis::Data::Core qw#get_all_nicks nick_to_ident ident_to_nick get_main_nick register_plugin#;
 use Onis::Data::Persistent;
 
-@Onis::Plugins::Core::EXPORT_OK = (qw(get_core_nick_counters));
+@Onis::Plugins::Core::EXPORT_OK = (qw(get_core_nick_counters get_sorted_nicklist));
 @Onis::Plugins::Core::ISA = ('Exporter');
 
 our $NickLinesCounter = Onis::Data::Persistent->new ('NickLinesCounter', 'nick',
@@ -49,6 +49,7 @@ our $NickCharsCounter = Onis::Data::Persistent->new ('NickCharsCounter', 'nick',
 our $QuoteCache = {}; # Saves per-nick information without any modification
 our $QuoteData = {};  # Is generated before output. Nicks are merged according to Data::Core.
 our $NickData = {};  # Same as above, but for nicks rather than quotes.
+our $SortedNicklist = [];
 
 our @H_IMAGES = qw#dark-theme/h-red.png dark-theme/h-blue.png dark-theme/h-yellow.png dark-theme/h-green.png#;
 our $QuoteCacheSize = 10;
@@ -361,13 +362,13 @@ sub calculate
                        $NickData->{$main}{'words_total'} = $sum;
                }
 
-               @counter = $NickWordsCounter->get ($nick);
+               @counter = $NickCharsCounter->get ($nick);
                if (@counter)
                {
                        my $sum = 0;
                        for (my $i = 0; $i < 24; $i++)
                        {
-                               $NickData->{$main}{'words'}[$i] += $counter[$i];
+                               $NickData->{$main}{'chars'}[$i] += $counter[$i];
                                $sum += $counter[$i];
                        }
                        $NickData->{$main}{'chars_total'} = $sum;
@@ -413,7 +414,7 @@ sub activetimes
 # $most_lines
        for (keys %$NickData)
        {
-               my $nick = shift;
+               my $nick = $_;
 
                for (my $i = 0; $i < 24; $i++)
                {
@@ -557,14 +558,19 @@ EOF
        print $fh "    <th>$trans</th>\n",
        "  </tr>\n";
 
-       for (sort
+       @$SortedNicklist = sort
        {
                $NickData->{$b}{"${sort_field}_total"} <=> $NickData->{$a}{"${sort_field}_total"}
-       } (@nicks))
+       } (@nicks);
+
+       @nicks = ();
+
+       for (@$SortedNicklist)
        {
                my $nick = $_;
                my $ident = nick_to_ident ($nick);
                my $name  = ident_to_name ($ident);
+               my $print = $name || $nick;
 
                $linescount++;
 
@@ -575,11 +581,11 @@ EOF
                {
                        my $quote = translate ('-- no quote available --');
 
-                       if (defined ($QuoteData->{$nick}))
+                       if (@{$QuoteData->{$nick}})
                        {
                                my $num = scalar (@{$QuoteData->{$nick}});
                                my $rand = int (rand ($num));
-                               $quote = html_escape ($QuoteData->{$nick}[$rand]);
+                               $quote = html_escape ($QuoteData->{$nick}[$rand][1]);
                        }
 
                        my $link = '';
@@ -632,11 +638,11 @@ EOF
 
                        if ($link)
                        {
-                               print $fh qq#<a href="$link">$name</a></td>\n#
+                               print $fh qq#<a href="$link">$print</a></td>\n#
                        }
                        else
                        {
-                               print $fh qq#$name</td>\n#;
+                               print $fh qq#$print</td>\n#;
                        }
                
                        if ($DISPLAY_LINES ne 'NONE')
@@ -746,7 +752,7 @@ EOF
                                qq#  <tr>\n#;
                        }
                        
-                       print $fh qq#    <td title="$title">$name ($total)</td>\n#;
+                       print $fh qq#    <td title="$title">$print ($total)</td>\n#;
                        
                        if ($row_in_this_table == $ShortLines and $col_in_this_table == 5)
                        {
@@ -786,10 +792,9 @@ EOF
 sub bar
 {
        my $max_num = shift;
-
        my $source = shift;
 
-       confess unless (ref ($source eq 'ARRAY'));
+       confess () unless (ref ($source) eq 'ARRAY');
 
        # BAR_WIDTH is a least 10
        my $max_width = $BAR_WIDTH - 4;
@@ -831,8 +836,17 @@ sub bar
 
 =item B<get_core_nick_counters> (I<$nick>)
 
-Returns the total I<lines>, I<words> and I<characters> written by the given
-nick.
+Returns a hash-ref that containes all the nick-counters available. It looks
+like this:
+
+    {
+        lines => [qw(0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0)],
+       words => [qw(0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0)],
+       chars => [qw(0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0)],
+       lines_total => 0,
+       words_total => 0,
+       chars_total => 0
+    }
 
 =cut
 
@@ -840,14 +854,24 @@ sub get_core_nick_counters
 {
        my $nick = shift;
 
-       if (defined ($NickData->{$nick}))
+       if (!defined ($NickData->{$nick}))
        {
-               return ($NickData->{$nick}{'lines_total'},
-                       $NickData->{$nick}{'words_total'},
-                       $NickData->{$nick}{'chars_total'});
+               return ({});
        }
 
-       return (qw());
+       return ($NickData->{$nick});
+}
+
+=item B<get_sorted_nicklist> ()
+
+Returns an array-ref that containes all nicks, sorted by the field given in the
+config-file.
+
+=cut
+
+sub get_sorted_nicklist
+{
+       return ($SortedNicklist);
 }
 
 =back